Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2747066imu; Sun, 27 Jan 2019 12:07:17 -0800 (PST) X-Google-Smtp-Source: ALg8bN5Vzh9Rnvlt7xNtwEArXU+p4sKZ3f9lE1yyQW8fI+bd+YeGOZcAF9DfGDXl7H+mqSwxiNK9 X-Received: by 2002:a63:5664:: with SMTP id g36mr17176656pgm.313.1548619637525; Sun, 27 Jan 2019 12:07:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548619637; cv=none; d=google.com; s=arc-20160816; b=XQ1OsQh+ELzEtQ8Jpn/eZ/uD/na6kK3BNfATssv0V+rWFdvfBKGjsAFvSAEb2z7DFK jJU3FNl7jH3+PYXEkFWS686cKEbz3e/CdmBu9AZFDhXVZRk8CZcSio3StRcsC27Wk7zS ObGJqGGMdFrlE8+ycz2b1+mCk8+BgUG+/W1WYV3jeZQu+XuZooC2QNOls3S2V5Qn1MCU Q7Wlf8YQOv/tdHYQdBupRwSYU9gNdjvf2F+UCOAtBVUGR69GL8MUEbnK3xn5wSlvOluz iuoJEhZXgpb5ANc4dKtFl7cWWEvui37dORu61wf57wifp6Yvt9BfV0JpwgTanbuvFzsl PxKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=+dGnuh3vQt6pQFsHKexpKNzwxbVjw0pX/JuqBdk6lwc=; b=ZZt1ESF9yUpuErZCdDFxG3Y2vq1kd7+rPOjH/04CiR2IXySl1ll/6BIPI4l39R7pMB VceKjYTwGcmazq5rgNZVZigzL7fw0HdktXuDU7USwDIN7PL61X94CHjZ0+rEKt+yWIVB U8Til7EdBnoIISe7bL9FOZhYBi5UjAzgGcLr0Q+ixpuNhROMDGkNUGNostsh9vObWyJU 6qhCACkICt4+m5m5lnVRLt8wkMLr1xTxcwNCBpJqFwVDhjVeaMZlAlyroklVwV0oofOB 8WFVkJLpyovaXB7xLD5yZ6AsNBUXsJSHlIM+yPsdELnfvQM1FAUpTGH49OVoWGP1m8ha 7kHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=iki.fi Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k189si10073450pgd.589.2019.01.27.12.06.42; Sun, 27 Jan 2019 12:07:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=iki.fi Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726977AbfA0T7u (ORCPT + 99 others); Sun, 27 Jan 2019 14:59:50 -0500 Received: from emh04.mail.saunalahti.fi ([62.142.5.110]:42220 "EHLO emh04.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726630AbfA0T7u (ORCPT ); Sun, 27 Jan 2019 14:59:50 -0500 Received: from localhost.localdomain (85-76-101-7-nat.elisa-mobile.fi [85.76.101.7]) by emh04.mail.saunalahti.fi (Postfix) with ESMTP id 39D5530152; Sun, 27 Jan 2019 21:59:48 +0200 (EET) From: Aaro Koskinen To: Greg Kroah-Hartman , devel@driverdev.osuosl.org Cc: linux-kernel@vger.kernel.org, Aaro Koskinen Subject: [PATCH] staging: octeon: fix broken phylib usage Date: Sun, 27 Jan 2019 21:54:50 +0200 Message-Id: <20190127195450.12480-1-aaro.koskinen@iki.fi> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 2b3e88ea6528 ("net: phy: improve phy state checking") added checks for phylib usage, and this triggers with OCTEON ethernet and results in broken networking. Fix by replacing phy_start_aneg() with phy_start(). Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking") Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet-mdio.c index 2848fa71a33d..d6248eecf123 100644 --- a/drivers/staging/octeon/ethernet-mdio.c +++ b/drivers/staging/octeon/ethernet-mdio.c @@ -170,7 +170,7 @@ int cvm_oct_phy_setup_device(struct net_device *dev) return -ENODEV; priv->last_link = 0; - phy_start_aneg(phydev); + phy_start(phydev); return 0; no_phy: -- 2.17.0