Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <6e166e2d25a56212c06c1334fd9bfb09d14beff0.camel@perches.com>
Subject: Re: [PATCH v2 1/1] int_sqrt() adjustments
From:   Joe Perches <joe@perches.com>
To:     Florian La Roche <florian.laroche@googlemail.com>,
        linux-kernel@vger.kernel.org
Cc:     Crt Mori <cmo@melexis.com>, Davidlohr Bueso <dave@stgolabs.net>,
        Will Deacon <will.deacon@arm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Florian La Roche <Florian.LaRoche@gmail.com>
Date:   Sun, 27 Jan 2019 12:46:47 -0800
In-Reply-To: <20190127203239.973-1-Florian.LaRoche@gmail.com>
References: <20190127203239.973-1-Florian.LaRoche@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.1-1build1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 2019-01-27 at 21:32 +0100, Florian La Roche wrote:
> Add __attribute_const__ and use normal ints for the right param of "<<".
[]
> diff --git a/include/linux/kernel.h b/include/linux/kernel.h
[]
> @@ -513,10 +513,10 @@ extern int __kernel_text_address(unsigned long addr);
>  extern int kernel_text_address(unsigned long addr);
>  extern int func_ptr_is_kernel_text(void *ptr);
>  
> -unsigned long int_sqrt(unsigned long);
> +__attribute_const__ unsigned long int_sqrt(unsigned long);

This might as well return u32 to be consistent with int_sqrt64