Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2784821imu; Sun, 27 Jan 2019 13:05:38 -0800 (PST) X-Google-Smtp-Source: ALg8bN5+PXH253RDL06akP1dZbh8iW3fr6/raLLjTmgMm3Vr35XqAPQPBYl7exGWAjPEjgKH1tMI X-Received: by 2002:a63:2586:: with SMTP id l128mr17837350pgl.104.1548623138376; Sun, 27 Jan 2019 13:05:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548623138; cv=none; d=google.com; s=arc-20160816; b=C66rDnuR3p1sm7ctf7GoCj0F5Kjc45vwcmHjW2xcNM1jWPNlVBbgKCyd2cn0XeCthR L9UkYSGCuvcMOTfXIbOF7b2dFl/z2LMalOGS7c6kJLmCrQ4qQGNqF/q1PuYXfX3p/b/+ uto+PA4JRJ5g5HobrglZVbAdVunJY49LYmplM0CydrSc4WUkld7G1a7bfaq32kEilLIS 6v42abXi6WqcwEN355JN8s7G0YSc+Tedw54fnn2N/yiq7RKwDVA3UAueN4eVOKFwN2uX 5tfVJsH2xvWVAc+dQYMEFiX7UCbkR8A2yZaCVavetXgdlaomWi8tTXwGX6ibDFmNtBgo 0igw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:cc:to:from :date; bh=fRria384TAsCSz2FvUbQiNKXGLx5g99lLGaGX+SHTjk=; b=I7/55rF1Hg52ZxCZ7ynEHPMhFmlvP/WNFSgXjS+6WHdPbfWeU6S0NVFNIUPSCWIZxf OzVrnNlmggGf0t1Z8yMf2bqLcJkZm0NXf2qlyRtBLc7EnX+2e96JdsHNMmgMPBfq48/G CNXV7XVqoYVeAb751coKi+jX+BvBix9EedTjQO4bJZJfAxrb2jqqYyOJaurwhZMXbbVj 8/gIuUiizWTCXBDMXjincEi1vavpOEvVuLi0Hau3F3YoPt1TLzkDrFLQLKZzNodOhKHP EFQTWDo35CrLpLq1tvhK3q68esBdFu9gpMecd8eAb08CSE+v/cL6yMJM94W95yYK37MV tWMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r12si30753437pgf.22.2019.01.27.13.05.23; Sun, 27 Jan 2019 13:05:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727237AbfA0VEm (ORCPT + 99 others); Sun, 27 Jan 2019 16:04:42 -0500 Received: from bout01.mta.xmission.com ([166.70.11.15]:40369 "EHLO bout01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727001AbfA0VEm (ORCPT ); Sun, 27 Jan 2019 16:04:42 -0500 Received: from mx01.mta.xmission.com ([166.70.13.211]) by bout01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1gnrbd-0001ga-6G; Sun, 27 Jan 2019 14:04:41 -0700 Received: from plesk14-shared.xmission.com ([166.70.198.161] helo=plesk14.xmission.com) by mx01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1gnrbc-0002MZ-Bl; Sun, 27 Jan 2019 14:04:41 -0700 Received: from hacktheplanet (c-68-50-23-202.hsd1.in.comcast.net [68.50.23.202]) by plesk14.xmission.com (Postfix) with ESMTPSA id A9D8B217B8E; Sun, 27 Jan 2019 21:04:39 +0000 (UTC) Date: Sun, 27 Jan 2019 16:04:32 -0500 From: Scott Bauer To: David Kozub Cc: Jens Axboe , Jonathan Derrick , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jonas Rabenstein Message-ID: <20190127210432.GC21149@hacktheplanet> References: <1548196307-12987-1-git-send-email-zub@linux.fjfi.cvut.cz> <1548196307-12987-4-git-send-email-zub@linux.fjfi.cvut.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548196307-12987-4-git-send-email-zub@linux.fjfi.cvut.cz> User-Agent: Mutt/1.9.4 (2018-02-28) X-XM-SPF: eid=1gnrbc-0002MZ-Bl;;;mid=<20190127210432.GC21149@hacktheplanet>;;;hst=mx01.mta.xmission.com;;;ip=166.70.198.161;;;frm=sbauer@plzdonthack.me;;;spf=none X-SA-Exim-Connect-IP: 166.70.198.161 X-SA-Exim-Mail-From: sbauer@plzdonthack.me X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa04.xmission.com X-Spam-Level: * X-Spam-Status: No, score=1.0 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01, T_TooManySym_02,XMSubLong,XM_UncommonTLD01 autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4991] * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa04 1397; Body=1 Fuz1=1 Fuz2=1] * 0.5 XM_UncommonTLD01 Less-common TLD * 0.0 T_TooManySym_01 4+ unique symbols in subject * 0.0 T_TooManySym_02 5+ unique symbols in subject X-Spam-DCC: XMission; sa04 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;David Kozub X-Spam-Relay-Country: X-Spam-Timing: total 622 ms - load_scoreonly_sql: 0.06 (0.0%), signal_user_changed: 3.9 (0.6%), b_tie_ro: 2.6 (0.4%), parse: 1.27 (0.2%), extract_message_metadata: 31 (4.9%), get_uri_detail_list: 1.44 (0.2%), tests_pri_-1000: 37 (6.0%), tests_pri_-950: 1.50 (0.2%), tests_pri_-900: 1.22 (0.2%), tests_pri_-90: 19 (3.0%), check_bayes: 17 (2.8%), b_tokenize: 6 (0.9%), b_tok_get_all: 4.9 (0.8%), b_comp_prob: 1.64 (0.3%), b_tok_touch_all: 2.5 (0.4%), b_finish: 0.71 (0.1%), tests_pri_0: 507 (81.5%), check_dkim_signature: 0.57 (0.1%), check_dkim_adsp: 2.7 (0.4%), poll_dns_idle: 0.91 (0.1%), tests_pri_10: 4.3 (0.7%), tests_pri_500: 12 (2.0%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH v3 03/16] block: sed-opal: unify space check in add_token_* X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Fri, 13 May 2016 17:07:30 -0600) X-SA-Exim-Scanned: Yes (on mx01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 22, 2019 at 11:31:34PM +0100, David Kozub wrote: > From: Jonas Rabenstein > > All add_token_* functions have a common set of conditions that have to > be checked. Use a common function for those checks in order to avoid > different behaviour as well as code duplication. > > Co-authored-by: David Kozub > Signed-off-by: Jonas Rabenstein > Signed-off-by: David Kozub Reviewed-by: Scott Bauer