Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2785711imu; Sun, 27 Jan 2019 13:06:44 -0800 (PST) X-Google-Smtp-Source: ALg8bN46tNkoP8XL4lbyVhCYzNTPRx/Ep8jy2jwTOQlZLxEdz63S6IM5nz3GMqYhhE6UXopKScsQ X-Received: by 2002:a62:75d1:: with SMTP id q200mr19444110pfc.254.1548623204213; Sun, 27 Jan 2019 13:06:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548623204; cv=none; d=google.com; s=arc-20160816; b=rVNnP+EjePu83Ejlq6zoAZnGgv2QzEWLSh8NewW3OdytGlkkXKQimd8KBG8lIL7HvP P4BgAcdHti0mVO4TYj3zBaGNnbY83DdWX0kxto1U76xaaponpZDt/isy2k3td8GRDVL4 pAdHp2/fjNcGIBge0de6YKg1BxTB8X+RLDaXAt2qeY3B9C9hVQ4Etcq2XUQM69P5QLRs r8DHTT4TJHIZvpcFMEboVU+YH/T0tw04EM+kkcNlD6PQ9olIKRo3kjeF+IsC4HjGkheY z8Pcos+sHo5l31HAd0OTWG9LyyT0OM9rwYY6aFfS1RRnGP4+nUr6kGkvlftermmPFZdM HgLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:cc:to:from :date; bh=RH+s1QZL72OMUX3mhG1KwihC9xBUsNA9KR4aS1TtS4A=; b=0vUVuSuIGB+9R3biFvFqEfAz/A5IFA2eiLhRUJbALixk+7RK9ZMWgzdoUkonirfDDP T4cloI2dR3SIYJwxaFlVL89sYnKzt2dJao7KYwv/6pmmz8CsNeutyo6tWZeYvDmT+e65 1ypJWxRWIFvZf2/CVB77za0R+1ecj8YhRW59zvQJAMcw+4nwZgqQ408DLWlmjOdrRCP7 SEdRqmEb2PC1CZcDJUa+3y91DUnJza9/ytmZKAX1UEExZXHZzRQvwzdF1EdcQTeHQodl /7SGiqqbEBHZ6lelJ/Bskuuc5Ezn/idF5f7IfVRfFXaUAMCaGbdPYPHuHOtOUA0FHh8r 6NJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h129si932776pfb.253.2019.01.27.13.06.29; Sun, 27 Jan 2019 13:06:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727271AbfA0VFv (ORCPT + 99 others); Sun, 27 Jan 2019 16:05:51 -0500 Received: from bout01.mta.xmission.com ([166.70.11.15]:40398 "EHLO bout01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726867AbfA0VFv (ORCPT ); Sun, 27 Jan 2019 16:05:51 -0500 Received: from mx02.mta.xmission.com ([166.70.13.212]) by bout01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1gnrck-0001nb-4W; Sun, 27 Jan 2019 14:05:50 -0700 Received: from plesk14-shared.xmission.com ([166.70.198.161] helo=plesk14.xmission.com) by mx02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1gnrca-00009R-H7; Sun, 27 Jan 2019 14:05:50 -0700 Received: from hacktheplanet (c-68-50-23-202.hsd1.in.comcast.net [68.50.23.202]) by plesk14.xmission.com (Postfix) with ESMTPSA id D7A86217BED; Sun, 27 Jan 2019 21:05:39 +0000 (UTC) Date: Sun, 27 Jan 2019 16:05:32 -0500 From: Scott Bauer To: David Kozub Cc: Jens Axboe , Jonathan Derrick , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jonas Rabenstein Message-ID: <20190127210532.GE21149@hacktheplanet> References: <1548196307-12987-1-git-send-email-zub@linux.fjfi.cvut.cz> <1548196307-12987-6-git-send-email-zub@linux.fjfi.cvut.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548196307-12987-6-git-send-email-zub@linux.fjfi.cvut.cz> User-Agent: Mutt/1.9.4 (2018-02-28) X-XM-SPF: eid=1gnrca-00009R-H7;;;mid=<20190127210532.GE21149@hacktheplanet>;;;hst=mx02.mta.xmission.com;;;ip=166.70.198.161;;;frm=sbauer@plzdonthack.me;;;spf=none X-SA-Exim-Connect-IP: 166.70.198.161 X-SA-Exim-Mail-From: sbauer@plzdonthack.me X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa01.xmission.com X-Spam-Level: ** X-Spam-Status: No, score=2.6 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01, XMSubMetaSxObfu_03,XMSubMetaSx_00,XM_UncommonTLD01 autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4926] * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa01 1397; Body=1 Fuz1=1 Fuz2=1] * 1.2 XMSubMetaSxObfu_03 Obfuscated Sexy Noun-People * 1.0 XMSubMetaSx_00 1+ Sexy Words * 0.0 T_TooManySym_01 4+ unique symbols in subject * 0.5 XM_UncommonTLD01 Less-common TLD X-Spam-DCC: XMission; sa01 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;David Kozub X-Spam-Relay-Country: X-Spam-Timing: total 9243 ms - load_scoreonly_sql: 0.03 (0.0%), signal_user_changed: 8 (0.1%), b_tie_ro: 6 (0.1%), parse: 0.99 (0.0%), extract_message_metadata: 17 (0.2%), get_uri_detail_list: 0.89 (0.0%), tests_pri_-1000: 16 (0.2%), tests_pri_-950: 1.07 (0.0%), tests_pri_-900: 0.87 (0.0%), tests_pri_-90: 16 (0.2%), check_bayes: 15 (0.2%), b_tokenize: 3.9 (0.0%), b_tok_get_all: 4.9 (0.1%), b_comp_prob: 1.16 (0.0%), b_tok_touch_all: 2.5 (0.0%), b_finish: 0.63 (0.0%), tests_pri_0: 124 (1.3%), check_dkim_signature: 0.39 (0.0%), check_dkim_adsp: 3.4 (0.0%), poll_dns_idle: 9036 (97.8%), tests_pri_10: 1.80 (0.0%), tests_pri_500: 9057 (98.0%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH v3 05/16] block: sed-opal: unify cmd start X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Fri, 13 May 2016 17:07:30 -0600) X-SA-Exim-Scanned: Yes (on mx02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 22, 2019 at 11:31:36PM +0100, David Kozub wrote: > Every step starts with resetting the cmd buffer as well as the comid and > constructs the appropriate OPAL_CALL command. Consequently, those > actions may be combined into one generic function. On should take care > that the opening and closing tokens for the argument list are already > emitted by cmd_start and cmd_finalize respectively and thus must not be > additionally added. > > Co-authored-by: Jonas Rabenstein > Signed-off-by: David Kozub > Signed-off-by: Jonas Rabenstein Reviewed-by: Scott Bauer