Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2785964imu; Sun, 27 Jan 2019 13:07:06 -0800 (PST) X-Google-Smtp-Source: ALg8bN41+syV+r0FYXaZnAVnS4gt4CA86Pjzgf2VwzWFud6y5AEF4swVtNz5Wi4+xIpQ5tnea67p X-Received: by 2002:a17:902:161:: with SMTP id 88mr19781709plb.306.1548623226133; Sun, 27 Jan 2019 13:07:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548623226; cv=none; d=google.com; s=arc-20160816; b=suyy7CbiYQilJ13LHb9girIPJRlICd2Z5LrvA7V0aKddA83g8d8MQMLKuKBNGujuQZ r+I+vnVj+fLSCIXNWZZkMWEQh6K/QsDmXMvcEscg92N412SHLdcIMhe/MKvMEYM/xYcv jhhk+N2wWBOnB7C2fH/U+/nNozKSGvBuj9/hLZJYdStGgAgI328N28STfIVwv8oNFwAF gRe67qggwgYCzYjL/gJbQgD8jrxO9Tpm9ZpklZuAXm5GZL/JU5Ipouz+IDMzdthBXc41 qCVo6jG/zxTR7mc0UkRF0iSt3wCu9sADVFgoBl/sIkHRaopfw1JZAhTXn7hM/U9DfAao HxdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:cc:to:from :date; bh=xcRm963aBXcSk8s/gbLQY5MLaHaxNsU/CtBREI8jZTc=; b=HGV7wVU1zAReZ68eq+ZxBSd9KkXzfwr4I643tYffr427CzkYBGnbopAwrdWpPNu8wb UlRn1DleH8qWYQjyahRX/7NSrylVw2v0qvT9JQ+FdW49axi1Xeu5E4cL1dMk2LbSpauD +gc/O7Eigmw5qowppMQyr+WpddeHzseQnbSEjRAYAh6UAdLx4oJjJlThxzRqE9GXNah9 kizWS6uo8r3WwRctYeTfc8JsdgeuPJlJs2107OQtw3lB8OQPA9aunEXfsyCcbD3uj9gT zjxO3Ac7m1BjVvDIMOjvBqQ9poDvdDUD3t2z3iMXIcjSzAehE74a9PIdKMRPTma7Ha4F CuEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w17si29953415pgl.6.2019.01.27.13.06.51; Sun, 27 Jan 2019 13:07:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727290AbfA0VGJ (ORCPT + 99 others); Sun, 27 Jan 2019 16:06:09 -0500 Received: from bout01.mta.xmission.com ([166.70.11.15]:40412 "EHLO bout01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726867AbfA0VGJ (ORCPT ); Sun, 27 Jan 2019 16:06:09 -0500 Received: from mx01.mta.xmission.com ([166.70.13.211]) by bout01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1gnrcw-0001oT-Mm; Sun, 27 Jan 2019 14:06:02 -0700 Received: from plesk14-shared.xmission.com ([166.70.198.161] helo=plesk14.xmission.com) by mx01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1gnrcw-0002dB-8q; Sun, 27 Jan 2019 14:06:02 -0700 Received: from hacktheplanet (c-68-50-23-202.hsd1.in.comcast.net [68.50.23.202]) by plesk14.xmission.com (Postfix) with ESMTPSA id 74D8C217C38; Sun, 27 Jan 2019 21:06:01 +0000 (UTC) Date: Sun, 27 Jan 2019 16:05:54 -0500 From: Scott Bauer To: David Kozub Cc: Jens Axboe , Jonathan Derrick , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jonas Rabenstein Message-ID: <20190127210554.GF21149@hacktheplanet> References: <1548196307-12987-1-git-send-email-zub@linux.fjfi.cvut.cz> <1548196307-12987-7-git-send-email-zub@linux.fjfi.cvut.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548196307-12987-7-git-send-email-zub@linux.fjfi.cvut.cz> User-Agent: Mutt/1.9.4 (2018-02-28) X-XM-SPF: eid=1gnrcw-0002dB-8q;;;mid=<20190127210554.GF21149@hacktheplanet>;;;hst=mx01.mta.xmission.com;;;ip=166.70.198.161;;;frm=sbauer@plzdonthack.me;;;spf=none X-SA-Exim-Connect-IP: 166.70.198.161 X-SA-Exim-Mail-From: sbauer@plzdonthack.me X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa07.xmission.com X-Spam-Level: * X-Spam-Status: No, score=1.0 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01,XMSubLong, XM_UncommonTLD01 autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4990] * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa07 1397; Body=1 Fuz1=1 Fuz2=1] * 0.5 XM_UncommonTLD01 Less-common TLD * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;David Kozub X-Spam-Relay-Country: X-Spam-Timing: total 257 ms - load_scoreonly_sql: 0.03 (0.0%), signal_user_changed: 2.8 (1.1%), b_tie_ro: 2.0 (0.8%), parse: 0.78 (0.3%), extract_message_metadata: 18 (6.9%), get_uri_detail_list: 0.84 (0.3%), tests_pri_-1000: 33 (13.0%), tests_pri_-950: 1.45 (0.6%), tests_pri_-900: 1.06 (0.4%), tests_pri_-90: 17 (6.7%), check_bayes: 16 (6.1%), b_tokenize: 4.9 (1.9%), b_tok_get_all: 4.8 (1.9%), b_comp_prob: 1.54 (0.6%), b_tok_touch_all: 2.3 (0.9%), b_finish: 0.67 (0.3%), tests_pri_0: 170 (66.4%), check_dkim_signature: 0.49 (0.2%), check_dkim_adsp: 2.3 (0.9%), poll_dns_idle: 0.62 (0.2%), tests_pri_10: 3.1 (1.2%), tests_pri_500: 7 (2.7%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH v3 06/16] block: sed-opal: unify error handling of responses X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Fri, 13 May 2016 17:07:30 -0600) X-SA-Exim-Scanned: Yes (on mx01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 22, 2019 at 11:31:37PM +0100, David Kozub wrote: > response_get_{string,u64} include error handling for argument resp being > NULL but response_get_token does not handle this. > > Make all three of response_get_{string,u64,token} handle NULL resp in > the same way. > > Co-authored-by: Jonas Rabenstein > Signed-off-by: David Kozub > Signed-off-by: Jonas Rabenstein Reviewed-by: Scott Bauer