Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2786016imu; Sun, 27 Jan 2019 13:07:11 -0800 (PST) X-Google-Smtp-Source: ALg8bN7qo76RI4ZZtrMTvtcJWoQEYc168vBOwcKwfHbznykWCD0genVVIXi2ZezPZ7F3aj1e0f6z X-Received: by 2002:a17:902:925:: with SMTP id 34mr18621840plm.14.1548623231396; Sun, 27 Jan 2019 13:07:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548623231; cv=none; d=google.com; s=arc-20160816; b=n+4AS5plbBZ2l1sTR/CZBNQ9GRf1YhRr9VghkumCeVltVZiMXIkC8DW0t53G2OGSyr 39kXwtsEUrisB0E8Bq3rjnn8PIhKsclA0onAHaSMA8xXvuRAON3GPE5AJchM59I0mPfg U5xbEL5ygZH9hjLP3c7xbsDY8GG3T/np+khbw2d/YrHLSx1z8O/UH7bQ8uISGdhPU8Xx PWKbeekIhGJtcoTdOUhl3ToZICbmXT0hxkPKuBhaaaZqmpYD134lNIzp4swY2RAyf8cm tddSAWc27oBACpPHG0fG7QidRaH8zam0yKXFkr2r0AMtu5IbiTUyO+MPLLundw+WGsWj EqtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:cc:to:from :date; bh=VBIleyv1HXmDgRcY7n/jAacNfXk8Sul1aHr9B0ZXnG8=; b=W8etSyohR2DtCrzgnj1QthYQq6bk3krBae3OQOlEdeIQ7OefoGjjLWADIQda9VWWuN hZESj1Ge6Z4u/ron2a8H3TY/2YJHi9RG2QaIPzKmlQyOm6hJdXiIOQghWV5QJc0C9Ll5 R3w070SnXAX1poCQyG7T0bj8+RMJqX05uvytveAE8By9D0nwAJj/Ziuba1ZQ6N722ye9 WZ0QaeBzBOengsraDbZBuZcoSTZ6X3rolR/A+RlfolXUDjWpc+pRyerYdKfJFq4SPPU6 /udbpzm2WvV4jQ8vWDBCuUdSQJktW4nomgWjvTza/JOLty9q3E6jl6qT+29yuKjpEFi1 LB9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x23si31698128pln.100.2019.01.27.13.06.56; Sun, 27 Jan 2019 13:07:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727315AbfA0VG2 (ORCPT + 99 others); Sun, 27 Jan 2019 16:06:28 -0500 Received: from bout01.mta.xmission.com ([166.70.11.15]:40420 "EHLO bout01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726867AbfA0VG2 (ORCPT ); Sun, 27 Jan 2019 16:06:28 -0500 Received: from mx02.mta.xmission.com ([166.70.13.212]) by bout01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1gnrdL-0001p2-6Z; Sun, 27 Jan 2019 14:06:27 -0700 Received: from plesk14-shared.xmission.com ([166.70.198.161] helo=plesk14.xmission.com) by mx02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1gnrdK-0000FX-Nx; Sun, 27 Jan 2019 14:06:27 -0700 Received: from hacktheplanet (c-68-50-23-202.hsd1.in.comcast.net [68.50.23.202]) by plesk14.xmission.com (Postfix) with ESMTPSA id 13387217C70; Sun, 27 Jan 2019 21:06:26 +0000 (UTC) Date: Sun, 27 Jan 2019 16:06:18 -0500 From: Scott Bauer To: David Kozub Cc: Jens Axboe , Jonathan Derrick , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jonas Rabenstein Message-ID: <20190127210618.GG21149@hacktheplanet> References: <1548196307-12987-1-git-send-email-zub@linux.fjfi.cvut.cz> <1548196307-12987-8-git-send-email-zub@linux.fjfi.cvut.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548196307-12987-8-git-send-email-zub@linux.fjfi.cvut.cz> User-Agent: Mutt/1.9.4 (2018-02-28) X-XM-SPF: eid=1gnrdK-0000FX-Nx;;;mid=<20190127210618.GG21149@hacktheplanet>;;;hst=mx02.mta.xmission.com;;;ip=166.70.198.161;;;frm=sbauer@plzdonthack.me;;;spf=none X-SA-Exim-Connect-IP: 166.70.198.161 X-SA-Exim-Mail-From: sbauer@plzdonthack.me X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa06.xmission.com X-Spam-Level: * X-Spam-Status: No, score=1.0 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01, T_TooManySym_02,XMSubLong,XM_UncommonTLD01 autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4991] * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] * 0.5 XM_UncommonTLD01 Less-common TLD * 0.0 T_TooManySym_02 5+ unique symbols in subject * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;David Kozub X-Spam-Relay-Country: X-Spam-Timing: total 301 ms - load_scoreonly_sql: 0.11 (0.0%), signal_user_changed: 3.8 (1.3%), b_tie_ro: 2.5 (0.8%), parse: 1.25 (0.4%), extract_message_metadata: 21 (7.1%), get_uri_detail_list: 1.19 (0.4%), tests_pri_-1000: 32 (10.6%), tests_pri_-950: 1.43 (0.5%), tests_pri_-900: 1.14 (0.4%), tests_pri_-90: 19 (6.2%), check_bayes: 17 (5.6%), b_tokenize: 6 (2.0%), b_tok_get_all: 4.9 (1.6%), b_comp_prob: 1.67 (0.6%), b_tok_touch_all: 2.5 (0.8%), b_finish: 0.64 (0.2%), tests_pri_0: 205 (68.0%), check_dkim_signature: 0.70 (0.2%), check_dkim_adsp: 2.7 (0.9%), poll_dns_idle: 0.57 (0.2%), tests_pri_10: 2.2 (0.7%), tests_pri_500: 12 (3.9%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH v3 07/16] block: sed-opal: reuse response_get_token to decrease code duplication X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Fri, 13 May 2016 17:07:30 -0600) X-SA-Exim-Scanned: Yes (on mx02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 22, 2019 at 11:31:38PM +0100, David Kozub wrote: > response_get_token had already been in place, its functionality had > been duplicated within response_get_{u64,bytestring} with the same error > handling. Unify the handling by reusing response_get_token within the > other functions. > > Co-authored-by: Jonas Rabenstein > Signed-off-by: David Kozub > Signed-off-by: Jonas Rabenstein Reviewed-by: Scott Bauer