Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2786136imu; Sun, 27 Jan 2019 13:07:19 -0800 (PST) X-Google-Smtp-Source: ALg8bN6aqFxsY1CI9iyfxtzTPoF3byYt5Nu9jKukOdD6tckfMgWObAHoeGAq18ibbb1ShMn9UQVv X-Received: by 2002:a17:902:722:: with SMTP id 31mr19416275pli.271.1548623239771; Sun, 27 Jan 2019 13:07:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548623239; cv=none; d=google.com; s=arc-20160816; b=RXSGBkqWsS6/INGBbGuAYY5NU7gIC/E/gQU/lElnli5ZB9XsSUBAbdaR1NkrcrbPI5 gyAEPTIZA9sN3epAvR+tiDRlh2aWlDofXmKex9lkl0/4+bbmsGyb4s8p5m/pEK39jzIM HDBnLs4Qkb9nkK3vlj5elHoBLBb3+k8cJVE5aSCNGY5P8scB+AGOXUKcd4PyCkW6pJWU rWFdsuOfRTaMWZaPBuLVn7Sc3uOrAbiDwAjtCsL0EubrMoVoNnC7k8OZJF0k+fzW+k8I 79F5BC36iCNNkJo6qC1fB0wcAJWkYwLVjjPaJUxUxg4h9frD9eRi+jWUttZdomgKyQig 2O/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:cc:to:from :date; bh=1Yg7zwa/sJg4NR278IHYyvwDmUil4zS93cC9vw8t7A0=; b=faygFLemYXS3c7pdhhCv868zMhuJKbeuQ/7qT4J9hU9vDd1mZ4BviRYGvX8zG9rtgH reJTKgjjLXFpb3CarUvQtldSJOQoAySEhs5zfmFcNqdbcROt6A2BCEf3uR2C4RleU8g1 f5nmmNa8GfBeI3FOsIwnBQemUrP58US00zFaM1Kqxv6EcFZ8HFLSvoEdfhNGP89r6oF/ 77NgfJAJLb/XrC+mbKV/WfPwPi389mQPyWsYlkcuU+XVlX87ysR6VSXhZukTzMQa7ec4 /TtWySanTNUxaEHNNlpI9uXtjSkFoyAbxQiS6GkGwak/VFVL4J+Ct+hrWk2jZsPoo6eZ iJNw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w75si31386504pfd.55.2019.01.27.13.07.04; Sun, 27 Jan 2019 13:07:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727253AbfA0VFR (ORCPT + 99 others); Sun, 27 Jan 2019 16:05:17 -0500 Received: from bout01.mta.xmission.com ([166.70.11.15]:40391 "EHLO bout01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726867AbfA0VFR (ORCPT ); Sun, 27 Jan 2019 16:05:17 -0500 Received: from mx02.mta.xmission.com ([166.70.13.212]) by bout01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1gnrcC-0001iX-9P; Sun, 27 Jan 2019 14:05:16 -0700 Received: from plesk14-shared.xmission.com ([166.70.198.161] helo=plesk14.xmission.com) by mx02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1gnrcB-0008P2-Q9; Sun, 27 Jan 2019 14:05:16 -0700 Received: from hacktheplanet (c-68-50-23-202.hsd1.in.comcast.net [68.50.23.202]) by plesk14.xmission.com (Postfix) with ESMTPSA id 0ADA4217BDF; Sun, 27 Jan 2019 21:05:14 +0000 (UTC) Date: Sun, 27 Jan 2019 16:05:07 -0500 From: Scott Bauer To: David Kozub Cc: Jens Axboe , Jonathan Derrick , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jonas Rabenstein Message-ID: <20190127210507.GD21149@hacktheplanet> References: <1548196307-12987-1-git-send-email-zub@linux.fjfi.cvut.cz> <1548196307-12987-5-git-send-email-zub@linux.fjfi.cvut.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548196307-12987-5-git-send-email-zub@linux.fjfi.cvut.cz> User-Agent: Mutt/1.9.4 (2018-02-28) X-XM-SPF: eid=1gnrcB-0008P2-Q9;;;mid=<20190127210507.GD21149@hacktheplanet>;;;hst=mx02.mta.xmission.com;;;ip=166.70.198.161;;;frm=sbauer@plzdonthack.me;;;spf=none X-SA-Exim-Connect-IP: 166.70.198.161 X-SA-Exim-Mail-From: sbauer@plzdonthack.me X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa05.xmission.com X-Spam-Level: * X-Spam-Status: No, score=1.0 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01, T_TooManySym_02,XMSubLong,XM_UncommonTLD01 autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4985] * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa05 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject * 0.0 T_TooManySym_02 5+ unique symbols in subject * 0.5 XM_UncommonTLD01 Less-common TLD X-Spam-DCC: XMission; sa05 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;David Kozub X-Spam-Relay-Country: X-Spam-Timing: total 312 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 2.7 (0.9%), b_tie_ro: 1.84 (0.6%), parse: 0.69 (0.2%), extract_message_metadata: 14 (4.5%), get_uri_detail_list: 0.69 (0.2%), tests_pri_-1000: 34 (10.9%), tests_pri_-950: 1.45 (0.5%), tests_pri_-900: 1.01 (0.3%), tests_pri_-90: 17 (5.5%), check_bayes: 16 (5.1%), b_tokenize: 5.0 (1.6%), b_tok_get_all: 4.9 (1.6%), b_comp_prob: 1.51 (0.5%), b_tok_touch_all: 2.4 (0.8%), b_finish: 0.68 (0.2%), tests_pri_0: 226 (72.5%), check_dkim_signature: 0.61 (0.2%), check_dkim_adsp: 2.3 (0.7%), poll_dns_idle: 0.70 (0.2%), tests_pri_10: 2.2 (0.7%), tests_pri_500: 10 (3.3%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH v3 04/16] block: sed-opal: close parameter list in cmd_finalize X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Fri, 13 May 2016 17:07:30 -0600) X-SA-Exim-Scanned: Yes (on mx02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 22, 2019 at 11:31:35PM +0100, David Kozub wrote: > Every step ends by calling cmd_finalize (via finalize_and_send) > yet every step adds the token OPAL_ENDLIST on its own. Moving > this into cmd_finalize decreases code duplication. > > Co-authored-by: Jonas Rabenstein > Signed-off-by: David Kozub > Signed-off-by: Jonas Rabenstein Reviewed-by: Scott Bauer