Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3154232imu; Sun, 27 Jan 2019 23:04:50 -0800 (PST) X-Google-Smtp-Source: ALg8bN646+FZVcMCI0u3udN2N32bthrbmXb8rRos0ptHUsJCaC75eqLPwOjXPb25XrT83Y6vOpa5 X-Received: by 2002:a17:902:6f09:: with SMTP id w9mr21144752plk.309.1548659090671; Sun, 27 Jan 2019 23:04:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548659090; cv=none; d=google.com; s=arc-20160816; b=cr7irM5JLq1JtBsK7QnTwt7ppf/5njfkoKox+mqesoWDwMju9qvA13DKMVYhN8GeW1 D6cQ35K5SY6U9ZEBYGKZmlhwKiTvJOm/yTE2mf34ncJIdKGDj83vnKkQXxDaVAe0O+IF QPiQYtbarMs1+hOttyEmsXQmjONc3IkeGvYa8VAlK0K0n3NQSqz1bJfA94GsNqV20Y6f iRyPd85kmi3xqbznCQ+o9LtjsToSDIw0QlybdGMZpIRggApj2Bv2Y2O5phlm24V2vM8/ zmbFwvPD91WGJoSSfTw+iZzaGrUGE8VvQ7N+cWsCKiXh+mEV0Du3ehR6PRUQMqRPcgrR /ceg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=K2NJeyMbkaQpaps87eY/f4FrMpi/9VgVY8TR+RlTk9Q=; b=ELXOchyUe88tLpwV0uYQKa0bHwjYJXUJ56FrnCACgMrDrLlM0B64chJDvh4fk/YZNc W29FhRcjF9+Jlf++1PkUidOFvjj7//8mM46rdXZy1mqP2noNtT0v7Wa0Pm8ZmPNBMsA8 ORRpqmztj4QDEJ0fvr58xMBjTZMROziYdZWPcgC6WOTPUDQtAKJXvmZNLjNHktGiZpco UcZxMTx6Tek4koZ6O8thh6Ns2CX/N2PmaRuSpyFezsDjThdMlUooZJv8Ik/N457WQv29 sGSLzjFTxbZOxH479mNfCPBZczKaWgHqzIG3xF6qSGIDpHAhyuYOm/3k7a12+TQf2EUC BpWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q5si28577284pgg.204.2019.01.27.23.04.34; Sun, 27 Jan 2019 23:04:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726852AbfA1HEI (ORCPT + 99 others); Mon, 28 Jan 2019 02:04:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27294 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726612AbfA1HEI (ORCPT ); Mon, 28 Jan 2019 02:04:08 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 316A6C049DC1; Mon, 28 Jan 2019 07:04:07 +0000 (UTC) Received: from localhost (ovpn-112-14.rdu2.redhat.com [10.10.112.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8829C83BEF; Mon, 28 Jan 2019 07:04:04 +0000 (UTC) Date: Sun, 27 Jan 2019 23:04:03 -0800 (PST) Message-Id: <20190127.230403.636736583040998189.davem@redhat.com> To: khoroshilov@ispras.ru Cc: david.wu@rock-chips.com, peppe.cavallaro@st.com, joabreu@synopsys.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] net: stmmac: dwmac-rk: fix error handling in rk_gmac_powerup() From: David Miller In-Reply-To: <1548532137-15618-1-git-send-email-khoroshilov@ispras.ru> References: <1548532137-15618-1-git-send-email-khoroshilov@ispras.ru> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 28 Jan 2019 07:04:08 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexey Khoroshilov Date: Sat, 26 Jan 2019 22:48:57 +0300 > If phy_power_on() fails in rk_gmac_powerup(), clocks are left enabled. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Applied, thank you.