Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 28 Jan 2019 09:27:05 +0100 (CET)
From:   David Kozub <zub@linux.fjfi.cvut.cz>
To:     Scott Bauer <sbauer@plzdonthack.me>
cc:     Jens Axboe <axboe@kernel.dk>,
        Jonathan Derrick <jonathan.derrick@intel.com>,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
Subject: Re: [PATCH v3 00/16] block: sed-opal: support shadow MBR done flag
 and write
In-Reply-To: <20190127211449.GP21149@hacktheplanet>
Message-ID: <alpine.LRH.2.21.1901280924090.12735@linux.fjfi.cvut.cz>
References: <1548196307-12987-1-git-send-email-zub@linux.fjfi.cvut.cz> <20190127211449.GP21149@hacktheplanet>
User-Agent: Alpine 2.21 (LRH 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 27 Jan 2019, Scott Bauer wrote:

> On Tue, Jan 22, 2019 at 11:31:31PM +0100, David Kozub wrote:
>> David Kozub (8):
>>   block: sed-opal: fix typos and formatting
>>   block: sed-opal: close parameter list in cmd_finalize
>>   block: sed-opal: unify cmd start
>>   block: sed-opal: unify error handling of responses
>>   block: sed-opal: reuse response_get_token to decrease code duplication
>>   block: sed-opal: pass steps via argument rather than via opal_dev
>>   block: sed-opal: don't repeat opal_discovery0 in each steps array
>>   block: sed-opal: rename next to execute_steps
>>
>
> You forgot to send 16/16 again in v3. I pulled and tested off your github page.
> If you send a v4 or just resend that patch you can add my reviewed-by, as I reviewed it
> on my tree/from your github.

Hi Scott. Thank you for the review.

W.r.t. the 16th patch: I think I sent it, after all I also see it in 
lore.kernel.org:

https://lore.kernel.org/lkml/1548196307-12987-17-git-send-email-zub@linux.fjfi.cvut.cz/

Anyway, if the best way forward is to send v4, I'll do it.

Best regards,
David