Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3277019imu; Mon, 28 Jan 2019 01:52:20 -0800 (PST) X-Google-Smtp-Source: ALg8bN6FJJ6v6Qlr4gE4OsdYQukOdcWfSH7Yi6iQBqGfVdbgYJn2YWRkMGFbWGndC/x0akafH/EY X-Received: by 2002:a17:902:2aaa:: with SMTP id j39mr21628591plb.335.1548669140864; Mon, 28 Jan 2019 01:52:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548669140; cv=none; d=google.com; s=arc-20160816; b=lZpx26DwLgvw5br7rk5KFf2VZxa/QdtR7K6effCABS8lO7cvtUUtOLa4k9NKf6oNmg hXYhvOC0oT3YFcyjCB82FntbZMDB28NDLIUGvMlW2tRol/i4QU0HmI/oKKbjDuxj7GK+ Q/cwTVDwBE6dGNyF0ngee6yZeY4D92uzGn5mT4dT45ZIfEg3iBcIdbWvNv/gFDzBxAqX AeyBXPTD6N8sG4FErU0FnhUHASeLGkKmakzU9Ecuj3joZu5HNAxgwmsUpyd0p5YQ6fcY SffbeobzlKWdrGQu36oQrEkhMkQu0VFhKLq6J4BuiNXlEUwmyDxWeBCW1DwdW6b1cpzu nXrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=8O3bxBrsm9s22YGoAg/SjONO2HrGWnWlxX+xHqKFC7g=; b=i42MGXbXiiTTYHUixH7nPmPXkdUD74/SnsLVXYEH5queKfw2ka5Aaw3bZl6gbww6at XnX69FR1zTTlWMJ/scm4SUoa52G4I1X7U+ahfP1fMiTebIgWliHVXaS8L+buBJnNaBzz 01KNULY/z1Ac28Qft8MhcSafF4sQ+veUxiNZTnznKEV+ngQkE0cKM3XcyQeUdCs2zp+L nGn42XNMywlHabn4gYUyQcBY1T/q7KGdgRH70a61WVpPQoy1xBVnoHA2dYdWl7cif4MJ X9dNteJ5/AeCaQL7UU8NkylsMkgLur1oB30SUDFTg2fwXDf5iEMhB35rovePgYN4/Vyl ZGug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y11si32807195plg.236.2019.01.28.01.52.05; Mon, 28 Jan 2019 01:52:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726752AbfA1Jvs (ORCPT + 99 others); Mon, 28 Jan 2019 04:51:48 -0500 Received: from mail.us.es ([193.147.175.20]:58124 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726590AbfA1Jvs (ORCPT ); Mon, 28 Jan 2019 04:51:48 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 4BBCF2325C8 for ; Mon, 28 Jan 2019 10:51:46 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 3B40ADA86E for ; Mon, 28 Jan 2019 10:51:46 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 216A1DA87B; Mon, 28 Jan 2019 10:51:46 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 11A33DA796; Mon, 28 Jan 2019 10:51:44 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Mon, 28 Jan 2019 10:51:44 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id D36034265A4E; Mon, 28 Jan 2019 10:51:43 +0100 (CET) Date: Mon, 28 Jan 2019 10:51:43 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Anders Roxell Cc: kadlec@blackhole.kfki.hu, fw@strlen.de, davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: ipt_CLUSTERIP: fix warning unused variable cn Message-ID: <20190128095143.5yxst4dn7pvodqwn@salvia> References: <20190123114811.25388-1-anders.roxell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190123114811.25388-1-anders.roxell@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 23, 2019 at 12:48:11PM +0100, Anders Roxell wrote: > When CONFIG_PROC_FS isn't set the variable cn isn't used. > > net/ipv4/netfilter/ipt_CLUSTERIP.c: In function ‘clusterip_net_exit’: > net/ipv4/netfilter/ipt_CLUSTERIP.c:849:24: warning: unused variable ‘cn’ [-Wunused-variable] > struct clusterip_net *cn = clusterip_pernet(net); > ^~ > > Rework so the variable 'cn' is declared inside "#ifdef CONFIG_PROC_FS". Applied, thanks.