Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3281569imu; Mon, 28 Jan 2019 01:58:39 -0800 (PST) X-Google-Smtp-Source: ALg8bN7eBVYvCAUlOAWLIC/Qwxvt83Mp7zuXDEJE6XklS4xheDMa9uAXvG0jIGS9/6Lp2wfi98Zu X-Received: by 2002:a65:65c9:: with SMTP id y9mr19639672pgv.438.1548669519786; Mon, 28 Jan 2019 01:58:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548669519; cv=none; d=google.com; s=arc-20160816; b=IILAmPfN6jTvPo/qkqq90IyfsIqKHSHJifJdNZNpuUTqUTtc88NyuQUbjOuj9Mq+SE arxTnqj+qB6o/d407SIw9PVotqxGc9B8bJfzpXMO6K8dhzIvbiJWhMMJUmnYxjT+glOI sguGQIylIz3AVswYp6UJGt7JhB3cz6F++BjrrXDiPzH0gJq/Oeu3/rXM+vOx0fLVpxfw 4g6RZaLiOQrX/jpPponDCmy/Q9NDrTM171NSy8HTBVNt+EgMznATG+amyP2bVx01Kd8z DSAUruejEQXFyfPxUsyP8/5IJFe7vMRjr/xMXc3vY6PuZkaApev1MmuvsI7t5zBQek9d iIqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ZTFG7gFEvB8sTKB9QlhzRykL0QQ21SrbzNmr7vxSAo4=; b=pSlN0tDEvcis92RwbdZT4mLF8GNYPKIQyrkEzfIceS5xpIHPBG3IvwAAQADiNx6Bfp CepSGYgM9jzdE0d0Pmg2mNwIl2gEGR62VDtnt6wIRgDoTF7+5ajslyqK2GEBhrQWKIBt VcHUYKOojEjAMQYhqksOVKZOrEcTjxKtalQYJpe6nAjR6f9GYucnls9wH2QzoUPSLZ0L OMtSICJY+mjz8wpVdZEf8HVIy2WfB5LajJYRRtm7ZZj5ouZtV38mySYz1eWp/983DxIz mhQswxLNidPcWhCW56O6YcZuzj+g/6sbXi/Uu/ViU5bPR4Y4b358osCT5/zMzrj14JZd PphQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u186si32002415pgd.131.2019.01.28.01.58.23; Mon, 28 Jan 2019 01:58:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726693AbfA1J6S (ORCPT + 99 others); Mon, 28 Jan 2019 04:58:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56960 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726648AbfA1J6S (ORCPT ); Mon, 28 Jan 2019 04:58:18 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CE90FC02C019; Mon, 28 Jan 2019 09:58:17 +0000 (UTC) Received: from dhcp-128-65.nay.redhat.com (ovpn-12-122.pek2.redhat.com [10.72.12.122]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 938305C234; Mon, 28 Jan 2019 09:58:13 +0000 (UTC) Date: Mon, 28 Jan 2019 17:58:09 +0800 From: Dave Young To: Borislav Petkov Cc: Pingfan Liu , kexec@lists.infradead.org, Baoquan He , Andrew Morton , Mike Rapoport , yinghai@kernel.org, vgoyal@redhat.com, Randy Dunlap , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv7] x86/kdump: bugfix, make the behavior of crashkernel=X consistent with kaslr Message-ID: <20190128095809.GC3732@dhcp-128-65.nay.redhat.com> References: <1548047768-7656-1-git-send-email-kernelfans@gmail.com> <20190125103924.GB27998@zn.tnic> <20190125134518.GA23595@dhcp-128-65.nay.redhat.com> <20190125140823.GC27998@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190125140823.GC27998@zn.tnic> User-Agent: Mutt/1.9.5 (2018-04-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 28 Jan 2019 09:58:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/25/19 at 03:08pm, Borislav Petkov wrote: > On Fri, Jan 25, 2019 at 09:45:18PM +0800, Dave Young wrote: > > AFAIK, some people prefer to explictly reserve crash memory at high > > region even if it is possible to reserve at low area. May because > > <4G memory is limited on large server, they want to leave this for other > > use. > > > > Yinghai or Vivek should know more about the history, probably they can > > recall some initial reason. > > Yes, just "prefer" is not good enough. There should be a technical > reason why that's there. > > Also, if the user doesn't care, then the code should be free to force > "high" and thus probe a different range for allocation. Another reason is in case ,high we will need automatically reserve a region in low area for swiotlb. So for example one use crashkernel=256M,high, actual reserved memory is 256M above 4G and another 256M under 4G for swiotlb. Normally it is not necessary for most people. Thus we can not make ,high as default. Thanks Dave