Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3291355imu; Mon, 28 Jan 2019 02:09:44 -0800 (PST) X-Google-Smtp-Source: ALg8bN4ZfZphH6TQXz/mxwpUuiVAtZba7SMlRxit6ikRYs7W9sFrDcH73lUUvgfQi7xsfNwoC8CW X-Received: by 2002:a63:31cc:: with SMTP id x195mr19451669pgx.52.1548670184467; Mon, 28 Jan 2019 02:09:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548670184; cv=none; d=google.com; s=arc-20160816; b=VFYdhKuaODN+hqebbficoFB352/K9mJ9i77HhSfn5NikvR/Zd4ato+P69lKRg37m01 c76U3MDUHkeema6o1AjPf3uKucTzf7xuSL21u/vYY5pKF69WHxTowXfpOd3ELB7e7lT9 zgDXUPKvvmNvCtiRYqE+j8N2U7c4NYjBfNMVjODWZEBRuW04lxdWlqN/iMIeeroH7gZ/ pS/a/Gd16i3nOOSz0CAu4w1BmGkopi3miR2D/ARUkebar8lMw+6bgMLMBlo9xSvkpjfH EKYvJyh+v4/EO7nfrkHgbQDN5t8X+TVQnM6y5Z9/RkGBjXmSZZlZbBHLf7Wv6/uvcOXj ZD9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dc+ZrSqlUl7D/bBzIUOTHMKLL7WN1ThWTOPPPpFUIFk=; b=HZQFXwoUfR7d0S4lP5Q1KAWWeoT1Twt40zV5YqmnrULYhSLsnVeRok56FasPVRFAMi 0f0kRxbUQGLvqsIK0fpaZ7e9hfTyFkQZKhamV9k7ZFlHdHd6Ogp6wcEye0AM09TXCqoP SL04V3vl1w7ukaqUuo8xAXYeR0wnoNmgx62GlOXgG84oN3Q0H4Q4EwJ0akIwE5w8IEfF NJp0yW3PNHJnUSfuHt2gxuDTh1TSYM3gMh4kGB0MDrMiwDBRSGyyKoZRphCL/zvcjav7 9HHcXHm+kVLZ0BkmkyQeF//ln1PfHnGSKc4BOg2akRBf61s7yUXvMN5wu9vuxhooUsY5 EYMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@chronox.de header.s=strato-dkim-0002 header.b=LbWGj7P0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y11si32807195plg.236.2019.01.28.02.09.29; Mon, 28 Jan 2019 02:09:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@chronox.de header.s=strato-dkim-0002 header.b=LbWGj7P0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726845AbfA1KH7 (ORCPT + 99 others); Mon, 28 Jan 2019 05:07:59 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.50]:18426 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726611AbfA1KH6 (ORCPT ); Mon, 28 Jan 2019 05:07:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1548670074; s=strato-dkim-0002; d=chronox.de; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=dc+ZrSqlUl7D/bBzIUOTHMKLL7WN1ThWTOPPPpFUIFk=; b=LbWGj7P0q2402lyeN/NJymCfwu0cqKw4cadslpmcrD6QELkA4u+mqs0qqt9Acuvlbx feG6lIM9tnUXvmFBdOGuWMyO6fGG15QO5K9VphfNutq7npjzDtGmqtDwH75+YvFMwhh2 OUwxTGKOjH5j78khPyKkvishUhKa4oJlCPCLQ6ak7j/t/jDcg2wYtXEZ+WcRYAYrv4DS 8vRIRQOSG9rMVkwkoN/6jUScfyYAt34//5Jt/Pgx8DqJzBuYR1sLcMbVwh/JKsTXkMBl kdUXmSMJeGyG51WSxVg49OrUycSWDFTlUTV3dxVWguGdKcAEBmT6vXudGtwisMWfZKXs MghA== X-RZG-AUTH: ":P2ERcEykfu11Y98lp/T7+hdri+uKZK8TKWEqNyiHySGSa9k9xmwdNnzGHXPbIfSf89Ln" X-RZG-CLASS-ID: mo00 Received: from tauon.chronox.de by smtp.strato.de (RZmta 44.9 DYNA|AUTH) with ESMTPSA id 309bcfv0SA7S4NJ (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Mon, 28 Jan 2019 11:07:28 +0100 (CET) From: Stephan Mueller To: Herbert Xu Cc: Eric Biggers , James Bottomley , Andy Lutomirski , "Lee, Chun-Yi" , "Rafael J . Wysocki" , Pavel Machek , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, keyrings@vger.kernel.org, "Rafael J. Wysocki" , Chen Yu , Oliver Neukum , Ryan Chen , David Howells , Giovanni Gherdovich , Randy Dunlap , Jann Horn , Andy Lutomirski , linux-crypto@vger.kernel.org Subject: Re: [PATCH v2 0/6] General Key Derivation Function Support Date: Mon, 28 Jan 2019 11:07:28 +0100 Message-ID: <5418064.ltLFQScYi2@tauon.chronox.de> In-Reply-To: <2082192.jPI8ve1O8G@positron.chronox.de> References: <20190103143227.9138-1-jlee@suse.com> <9733066.Vrs4h5eWcW@positron.chronox.de> <2082192.jPI8ve1O8G@positron.chronox.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 16. Januar 2019, 12:06:54 CET schrieb Stephan M=FCller: Hi Herbert, > Changes v2: > * Incorporation of all comments from Eric Biggers >=20 > Stephan Mueller (6): > crypto: add template handling for RNGs > crypto: kdf - SP800-108 Key Derivation Function > crypto: kdf - add known answer tests > crypto: hkdf - HMAC-based Extract-and-Expand KDF > crypto: hkdf - add known answer tests > crypto: tcrypt - add KDF test invocation >=20 > crypto/Kconfig | 13 + > crypto/Makefile | 2 + > crypto/hkdf.c | 272 +++++++++++++++++++ > crypto/kdf_sp800108.c | 491 ++++++++++++++++++++++++++++++++++ > crypto/rng.c | 44 +++ > crypto/tcrypt.c | 8 + > crypto/testmgr.c | 245 +++++++++++++++++ > crypto/testmgr.h | 198 ++++++++++++++ > include/crypto/internal/rng.h | 26 ++ > 9 files changed, 1299 insertions(+) > create mode 100644 crypto/hkdf.c > create mode 100644 crypto/kdf_sp800108.c Do you happen to have any comments on this patch set? Ciao Stephan