Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 28 Jan 2019 14:21:46 +0100
From:   Michal Hocko <mhocko@kernel.org>
To:     David Hildenbrand <david@redhat.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Mel Gorman <mgorman@techsingularity.net>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
        Jan Kara <jack@suse.cz>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Dominik Brodowski <linux@dominikbrodowski.net>,
        Matthew Wilcox <willy@infradead.org>,
        Vratislav Bendel <vbendel@redhat.com>,
        Rafael Aquini <aquini@redhat.com>
Subject: Re: [PATCH RFC] mm: migrate: don't rely on PageMovable() of newpage
 after unlocking it
Message-ID: <20190128132146.GK18811@dhcp22.suse.cz>
References: <20190128121609.9528-1-david@redhat.com>
 <20190128130709.GJ18811@dhcp22.suse.cz>
 <b03cae19-d02a-0ba2-69a1-010ee76748e7@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b03cae19-d02a-0ba2-69a1-010ee76748e7@redhat.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon 28-01-19 14:14:28, David Hildenbrand wrote:
> On 28.01.19 14:07, Michal Hocko wrote:
> > On Mon 28-01-19 13:16:09, David Hildenbrand wrote:
> > [...]
> >> My theory:
> >>
> >> In __unmap_and_move(), we lock the old and newpage and perform the
> >> migration. In case of vitio-balloon, the new page will become
> >> movable, the old page will no longer be movable.
> >>
> >> However, after unlocking newpage, I think there is nothing stopping
> >> the newpage from getting dequeued and freed by virtio-balloon. This
> >> will result in the newpage
> >> 1. No longer having PageMovable()
> >> 2. Getting moved to the local list before finally freeing it (using
> >>    page->lru)
> > 
> > Does that mean that the virtio-balloon can change the Movable state
> > while there are other users of the page? Can you point to the code that
> > does it? How come this can be safe at all? Or is the PageMovable stable
> > only under the page lock?
> > 
> 
> PageMovable is stable under the lock. The relevant instructions are in
> 
> mm/balloon_compaction.c and include/linux/balloon_compaction.h

OK, I have just checked __ClearPageMovable and it indeed requires
PageLock. Then we also have to move is_lru = __PageMovable(page) after
the page lock.
-- 
Michal Hocko
SUSE Labs