Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3473193imu; Mon, 28 Jan 2019 05:34:42 -0800 (PST) X-Google-Smtp-Source: ALg8bN4tE7umJPXqD16ULf+gQODezULqqEtsf5f9Ec2u+RrG2x4YHnTkNZhLQsPWGYRkd/qOO3rM X-Received: by 2002:a17:902:503:: with SMTP id 3mr22029274plf.233.1548682482787; Mon, 28 Jan 2019 05:34:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548682482; cv=none; d=google.com; s=arc-20160816; b=IOpdjFIGbi6btiKD2rgJlHOuPdCPd3/14z7/dVp932xLr5EE9Sv9c7ii4w6gjf3iKM VnLFSd4Hhgo7dV4gyGZX8TSdZQYv/oBUlPpLmk19ZQggsUBPYqdarF+9q6uVO6zRsmZe u564X/0ODj7JTuVi3ueseTwPWuVHOVJ2dyQHFAZewj1GnZ+7NMyF51Oa6P216PvajnwZ JEzO0wYML2155VD+zk+23tvU7UTThVbl20ES4zwhTeuZeCCVDSrwkUjxNm1CFOMOEoK4 7ZbPVz126TaMO5gSDwlJe4mXC2AKwnBWcWFHlJ/SLpcqeOUUlS+bknoUqSTLt0XuhOys ge5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=BQAbDTdJwdOOW82nOfAOiRyJqZt+DDRMYSPeNql1AE4=; b=BO4gZ9IFN72VZu3d693NIR4m218dWv9qCy4hOhLk9GFAGjzkzY1kwt4+9YDHoDxCOT eG46aotqEGYismok+3l+QH75rOk8spHDBxun37W60kde+eN0Zf9wHIEGnLbaCb+fdQSX RA44Nt6TdakVllI6UFyf+G56rid0RiG3oInpJ3S3EFh0diIojCZ6fG+LYZoBGbzBmGNY jKJM94pV/Sm8ayStj9WTIpIeUA0Sb6DeoQwCHVY2xfCN8Lp5jy+grMRotrdKNZh9N8Ge hlcKUfDRsrOUZ82eIaZXhk7d8ETQdCbFAZZ/16ZoTMhsszHtgianwBvlIvdTGpAh5r4Q 5dFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=h0peRGBy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a16si11156426pls.146.2019.01.28.05.34.27; Mon, 28 Jan 2019 05:34:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=h0peRGBy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726905AbfA1Ndo (ORCPT + 99 others); Mon, 28 Jan 2019 08:33:44 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:57646 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726647AbfA1Ndo (ORCPT ); Mon, 28 Jan 2019 08:33:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BQAbDTdJwdOOW82nOfAOiRyJqZt+DDRMYSPeNql1AE4=; b=h0peRGByJvJqH6vHU8SBNfBxV 0RB62rmAX25LvqvGJKbkOBYfLo4xyhPpd++X9kXIgF0AnqFgaZehugq1k4iE3uMqJ102jiPeio4VS pAPFpd6VAMS6uxhaXbJWvHkUt2epCmmSByuiHwprPwChxV+HxXFSQIA7zrlj8U3L4oZdQcJeOBQb+ dTrm/3SPpHEn1uhx5zcRabKeyJDEbynaqQwv3xFm8rFdfzBouxOaLEMomLyaLJnX9AHBOAprAUXmt afrL1FzFEAVZeNKRM8SdOxMzgDPb9hnXH8rj/0OXfQfPHyNUttc53jUpzFfqr8B3MU2klzGPD42Wd jki8W3f+Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1go72j-0001Lz-FS; Mon, 28 Jan 2019 13:33:41 +0000 Date: Mon, 28 Jan 2019 05:33:41 -0800 From: Christoph Hellwig To: Thomas Bogendoerfer Cc: Christoph Hellwig , Bjorn Helgaas , James Hogan , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-pci@vger.kernel.org, Lorenzo Pieralisi , Paul Burton , Ralf Baechle Subject: Re: [PATCH 2/7] MIPS: SGI-IP27: clean up bridge access and header files Message-ID: <20190128133341.GA5140@infradead.org> References: <20190124174728.28812-1-tbogendoerfer@suse.de> <20190124174728.28812-3-tbogendoerfer@suse.de> <20190128132003.GA744@infradead.org> <20190128142440.591d2115ac7844863713aa77@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190128142440.591d2115ac7844863713aa77@suse.de> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 28, 2019 at 02:24:40PM +0100, Thomas Bogendoerfer wrote: > I totally agreed. I only moved the original defintion around while cleaning > up the header file. Right now there is no code using it. Should I remove it > and access macros as soon there is a need for it ? Sounds good.