Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3627265imu; Mon, 28 Jan 2019 08:04:57 -0800 (PST) X-Google-Smtp-Source: ALg8bN4ii5Jn+REOYjGQ7noVhIys8aSDHHQjRWXWlmh0i7pDWozO77MWu5BMclMBaRR8CLSvI+g0 X-Received: by 2002:a62:cec6:: with SMTP id y189mr23291771pfg.100.1548691497330; Mon, 28 Jan 2019 08:04:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548691497; cv=none; d=google.com; s=arc-20160816; b=sBQTxlUovHOCz7L4ah6W8wxqowYts95Xc5bDSYgXNK+5dkXmjyvRJ403ppZkjzY3Q/ urHJqhYZ9ewq/+HAfcs6eCHs+jJeBTa/UFYzH0JMSngomplfjek299xmymGAzKw8czYI GOBPodvlFfsHuPIYKi1/z/dRYszwk9IdizTykcXIciqU80ewqbuL4jA7KfQ/42GDUivt 8o8GNzqT1kziu1013bjcdGTjnLsVc3XZ8F2bUXRCj84kczUJLG4AvE8GJdEC0MO07GnT c522FeMBSv5Ad2hbyUFdNF7jkmCVR3OR80LePwiqV+t7UK2ARHQYLv4S9yNSAlP26S8I SBJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=IVG55EPa6lcjji8U/X/godLU5YdrrwWkaPPrus+kilA=; b=JVT7t+w6+Wqjnq8uppPwtLkCtfPuMAeOt1l1UiP7PW9WTqJXkRCGPKTOMEC/vyHQW2 MjAn7T52A9ibqiK8+UJZCyT56k1IGeRncJacuccEPiVx3DgGUrhsYRCxzmkKh4O2hihF klkvfxJuFiUhYAHKk/sfDeiLa03Tl5q0BxJKYQ5g7X3Pd5B7Ezo1gCiozv1uc9OoUSzj XBESmwl4cpuT+UqadYzK2ARRQVhCY3QAZvJvGllG2691OA9zssqBBOiy5xlx7k0fYoy3 pEpu2RFht+MioIXPnLwFgaNgZOfBn+yiWU/MMxlAozTyreQtE6xLY5DQ1n7TmfEBgRJN ounw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xbwumTNz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 2si16079666pgj.104.2019.01.28.08.04.41; Mon, 28 Jan 2019 08:04:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xbwumTNz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731485AbfA1QDy (ORCPT + 99 others); Mon, 28 Jan 2019 11:03:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:49212 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731445AbfA1QDv (ORCPT ); Mon, 28 Jan 2019 11:03:51 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0A8A32175B; Mon, 28 Jan 2019 16:03:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548691431; bh=hJIh8QLmnTUJg9HEZ4nA/enTyoQ3r6pXm5y59mYhCk4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xbwumTNzRlHdqgNUglzns0M9b9BAqNN7MCbMNurnIvkG+ysffQUE7jjWT82ePfz9g ZBhr/Cy5paLMWpieYgSkemkUgQOEjvN3zk+fqnEdY4QcLCjJYqq5ZR3cttCjxGPVvq Qs9Bthd27IfzbabsfMyJilIIT3A8JoyCQSDK1bUE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Lubomir Rintel , Olof Johansson , Sasha Levin , devicetree@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 093/258] ARM: dts: mmp2: fix TWSI2 Date: Mon, 28 Jan 2019 10:56:39 -0500 Message-Id: <20190128155924.51521-93-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190128155924.51521-1-sashal@kernel.org> References: <20190128155924.51521-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lubomir Rintel [ Upstream commit 1147e05ac9fc2ef86a3691e7ca5c2db7602d81dd ] Marvell keeps their MMP2 datasheet secret, but there are good clues that TWSI2 is not on 0xd4025000 on that platform, not does it use IRQ 58. In fact, the IRQ 58 on MMP2 seems to be a signal processor: arch/arm/mach-mmp/irqs.h:#define IRQ_MMP2_MSP 58 I'm taking a somewhat educated guess that is probably a copy & paste error from PXA168 or PXA910 and that the real controller in fact hides at address 0xd4031000 and uses an interrupt line multiplexed via IRQ 17. I'm also copying some properties from TWSI1 that were missing or incorrect. Tested on a OLPC XO 1.75 machine, where the RTC is on TWSI2. Signed-off-by: Lubomir Rintel Tested-by: Pavel Machek Signed-off-by: Olof Johansson Signed-off-by: Sasha Levin --- arch/arm/boot/dts/mmp2.dtsi | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi index 766bbb8495b6..47e5b63339d1 100644 --- a/arch/arm/boot/dts/mmp2.dtsi +++ b/arch/arm/boot/dts/mmp2.dtsi @@ -220,12 +220,15 @@ status = "disabled"; }; - twsi2: i2c@d4025000 { + twsi2: i2c@d4031000 { compatible = "mrvl,mmp-twsi"; - reg = <0xd4025000 0x1000>; - interrupts = <58>; + reg = <0xd4031000 0x1000>; + interrupt-parent = <&intcmux17>; + interrupts = <0>; clocks = <&soc_clocks MMP2_CLK_TWSI1>; resets = <&soc_clocks MMP2_CLK_TWSI1>; + #address-cells = <1>; + #size-cells = <0>; status = "disabled"; }; -- 2.19.1