Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3708390imu; Mon, 28 Jan 2019 09:23:44 -0800 (PST) X-Google-Smtp-Source: ALg8bN7rOxd51sbtDIuudi7+il9w2tPvVBf9DadyfgFh7jxyxJv3EQuv4pBabPTCmgLV4GIglw6r X-Received: by 2002:a63:9501:: with SMTP id p1mr20604191pgd.149.1548696224742; Mon, 28 Jan 2019 09:23:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548696224; cv=none; d=google.com; s=arc-20160816; b=ITu47Bz/ttZIFBT/DDGmyr97xmGRgpCRJecbbLbuBPWbVLiXX3Sr1Z+sRkELiY78Yk UoaJtUDV2qEJPBvRIPYVchOmIQLIgY6fRnIgAqb5H6fsv0y37MTSDDK/QnkY0Mbzm7za +yxPJgMIQ/90zACwcX2QzC2Kd4vNHKjUodixJcGC9qe7k7dQ7vUuyCX4DpCXin7VJsWG ACZ81gRqBYAObNO4bdf3WFPp15ZaIqKY5x9KbFz5Fe5WPsZLWpjvnxrLtmbmXHukpg0K NiiyauZIWLyISndEgE1ei2HpBGwKYn285d/CXyX+ODBRcApJ9vn4oCnfBVi0vGfFbvqt mkOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=55vruckghI0CNrQauCA5Hmtstl5hw2rz4MEea9FQwQ4=; b=Nle9UJ+6d0nxP/g2/2iGDLVcU3DcyTj/QW0usjPWyai5Foz/b+CvetwrKQTkgNXyZT 5MyTPCbLfMEZSGp8K9qGqLWi//O9GWk7Foxb44LWa0R5MdsnsjaM5CIA0iss/vlO4kJA kTsPkFyieSRJQmoKwhU62Vnwpu+X4e/qpUtXmt/Qh9zjUSwDo3THcIYha8AVY6fNIRaY wa5AUi4b7zY+GNbb6xjNhhiya3Vc7lRRHAEztT99u7z/mbEA5AKgIRaQlTm26azJ8Kdf 0iq32YZIc4Df+s063TPYSySTahY+Y6xxAO3jW9sPssiz29WBNZA1L2Zfh7Ly6DSjSv2i ouGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xBnE4dNW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k26si3054555pgb.72.2019.01.28.09.23.29; Mon, 28 Jan 2019 09:23:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xBnE4dNW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731968AbfA1RVq (ORCPT + 99 others); Mon, 28 Jan 2019 12:21:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:43284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729513AbfA1RVo (ORCPT ); Mon, 28 Jan 2019 12:21:44 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1756720989; Mon, 28 Jan 2019 17:21:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548696104; bh=55vruckghI0CNrQauCA5Hmtstl5hw2rz4MEea9FQwQ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xBnE4dNWmkBgj0Sy0xp8qpSBlZGOHnYp2xUpKBHcWVxbhr+mgOmJfhpmBMUAzPKUM 99wHAbEvcIwU1WrrODmHgUyGKzVlTCmyjsep/FLIe8qzgBtKG/hX8g9mlRlJcVlMFi lyjoAxO3m0dpc/vthPffNlbOfKvwNQhvkmXWleBA= Date: Mon, 28 Jan 2019 12:21:43 -0500 From: Sasha Levin To: Jakub Kicinski Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, "David S . Miller" , oss-drivers@netronome.com, netdev@vger.kernel.org Subject: Re: [PATCH AUTOSEL 4.19 094/258] nfp: add locking around representor changes Message-ID: <20190128172143.GE3973@sasha-vm> References: <20190128155924.51521-1-sashal@kernel.org> <20190128155924.51521-94-sashal@kernel.org> <20190128082825.4c8394a6@cakuba.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190128082825.4c8394a6@cakuba.hsd1.ca.comcast.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 28, 2019 at 08:28:25AM -0800, Jakub Kicinski wrote: >On Mon, 28 Jan 2019 10:56:40 -0500, Sasha Levin wrote: >> From: Jakub Kicinski >> >> [ Upstream commit 71844fac1ed459024dd2a448d63d5b28b8c87daa ] >> >> Up until now we never needed to keep a networking locks around >> representors accesses, we only accessed them when device was >> reconfigured (under nfp pf->lock) or on fast path (under RCU). >> Now we want to be able to iterate over all representors during >> notifications, so make sure representor assignment is done >> under RTNL lock. >> >> Signed-off-by: Jakub Kicinski >> Reviewed-by: John Hurley >> Signed-off-by: David S. Miller >> Signed-off-by: Sasha Levin > >Hi Sasha! > >There is no need for backporting this unless 51a6588e8c08 ("nfp: add >offloads on representors") is also back ported (which is a feature). I'll drop it. Thanks for the heads-up. -- Thanks, Sasha