Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3734553imu; Mon, 28 Jan 2019 09:51:19 -0800 (PST) X-Google-Smtp-Source: ALg8bN4wd/1l8WZosp7kd05YTWsbm8X8p/+VBzFZ8GmnAXEQDUEq61yy3u6R2f2ANysirFvzIklk X-Received: by 2002:a65:5bc4:: with SMTP id o4mr20892150pgr.426.1548697879278; Mon, 28 Jan 2019 09:51:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548697879; cv=none; d=google.com; s=arc-20160816; b=HllE1UCpigCnaUPhguzUjn33YrHMRpBZrNdNNelpvnP7a0wBE+WcxUimi7CsDCWZp7 F1RGlh/IpA0Rg6VQAtVOiMoX2h0MYFdjS/5i2Kqub6VDqNrSOiW5hD/fWXy7b60nWG9k 4cdXwHd0ZOV66R6nmvBcJri2egCMK6d2jXe25etYvv+Edqpc35FNUS2PfUdiBG1n1+Vm PKtaLdXyCuRL3oFvssP27j4PRLpU99aD0va35Jkim8Dwo6X4JHmue+tN5gjnwj8g4nOV N/ZZk6MruPN3URECfzzoAoaF7d8ZITyCdOSf2aLfS0omeXeo8uO0CxDKlpuhSkfoMRVO B7HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=tiKrXRWXcQKuiQfu4b4nOKmW+HrB+aDLZqiEfbD/xpY=; b=EJQHSF9ztZSw+n3UlmprPZJYVu+FEJzQUtmGAXYYp/fH4bM970H2MWtpo25JjJysQ0 lFisej4nm8ur60KYFID0N3PyqR1c9P7CLQK8Q12NQ+qPZigdupZ+5hX3c+ix+buv3KnM hZO137w+xFtVISf5qzERg8j9xBbqfZiZbXcIzDRn4piex5EzxSHZXaAb81nsnlJy7Yno Y1ra0RxpEXTR9NbPSe95FT3FSKMoYL10nVe2XAB0o5E1M35Kf7r8xV/8nubREtxCyGB5 cB+tuYYUPW6jPtT7lBZpVopbkzfMB5lN1/1yKnIqkfWnKR9p4+o1HuFK87Rcn7EFsFXA zBWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v5si31855199pfe.52.2019.01.28.09.51.04; Mon, 28 Jan 2019 09:51:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727747AbfA1Ru6 (ORCPT + 99 others); Mon, 28 Jan 2019 12:50:58 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:53950 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726845AbfA1Ru4 (ORCPT ); Mon, 28 Jan 2019 12:50:56 -0500 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id D08CF2541; Mon, 28 Jan 2019 17:50:55 +0000 (UTC) Date: Mon, 28 Jan 2019 09:50:54 -0800 From: Andrew Morton To: Michal Hocko Cc: Mikhail Zaslonko , Mikhail Gavrilov , Pavel Tatashin , schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, gerald.schaefer@de.ibm.com, , LKML Subject: Re: [PATCH 0/2] mm, memory_hotplug: fix uninitialized pages fallouts. Message-Id: <20190128095054.4103093dec81f1c904df7929@linux-foundation.org> In-Reply-To: <20190128144506.15603-1-mhocko@kernel.org> References: <20190128144506.15603-1-mhocko@kernel.org> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Jan 2019 15:45:04 +0100 Michal Hocko wrote: > Mikhail has posted fixes for the two bugs quite some time ago [1]. I > have pushed back on those fixes because I believed that it is much > better to plug the problem at the initialization time rather than play > whack-a-mole all over the hotplug code and find all the places which > expect the full memory section to be initialized. We have ended up with > 2830bf6f05fb ("mm, memory_hotplug: initialize struct pages for the full > memory section") merged and cause a regression [2][3]. The reason is > that there might be memory layouts when two NUMA nodes share the same > memory section so the merged fix is simply incorrect. > > In order to plug this hole we really have to be zone range aware in > those handlers. I have split up the original patch into two. One is > unchanged (patch 2) and I took a different approach for `removable' > crash. It would be great if Mikhail could test it still works for his > memory layout. > > [1] http://lkml.kernel.org/r/20181105150401.97287-2-zaslonko@linux.ibm.com > [2] https://bugzilla.redhat.com/show_bug.cgi?id=1666948 > [3] http://lkml.kernel.org/r/20190125163938.GA20411@dhcp22.suse.cz Any thoughts on which kernel version(s) need these patches?