Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3755637imu; Mon, 28 Jan 2019 10:12:49 -0800 (PST) X-Google-Smtp-Source: ALg8bN4Z0724XD3NtDLPpKxhGZP3i9vfVIlsnOtnCiGA0etz3X9zqRbdodK/MjCH+G5fwo6HGeGl X-Received: by 2002:a17:902:3283:: with SMTP id z3mr23103409plb.76.1548699169241; Mon, 28 Jan 2019 10:12:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548699169; cv=none; d=google.com; s=arc-20160816; b=jukanGNbdYwujs/hqcVGNgQ24WB3wLKFapucNpjgu7ff0IU2aQPYqmS7zDr3+W1Ue3 cynkSQMCtxtBSC/K/57hGZvjWMYA5xah0y+7IGBKKmLXkZfyTxSf6oiRZmbi7bp71Z8N bBoP7afD7WPCMPdL1c2AG67Bt4g8E3PHPAzugCRkGLNA/nFfziUmPWhBLnAmbCWjfIHp AWaN68CPOwIaxSF2jCJE9mCyPK3RtjbWEDbhlAmNe2dqJLnm3tfXqWQSn/FjDQpCOxP/ fR9VnDr4CYxTxw6ccSvLcEPx7XDWak+iWfFUz41GiM0buvvZHSocXBTp8sigCRbliy0v Le4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6rz65wMwPx6JKLj0U1uilByOkexizZwcOOx3zNkZijo=; b=rfG/l5DXVx67JWYhcyFzac0R3nw+Slq/Q5VLUecsoqm8+7J3VtR7GLCMUoUpw7fL1m Vl6g8ZIkwyrrJNzWhwge6NE4CoL08T80VpyIQ6fT9L7PEUe7z8zDPZBsHpum/YA+aZMc v7FMx8Muf/EG8cSoNRde+/OB3pgth/onsgm+d+mVZ7Ort83wm4/G0YupjCJkOpuYjPtK e+S4J5PVV/Re+hwr4oM3ay4hc7yywguED6Rycb2DSNbABFw9m0BW1Z63MoFR0M1AMLAc MMfUGLL8QGqzp/FoVGA7mZOwHrCB+3T4lSpYrravr7rDJGh8Ep9pj5UieUizyPIlir38 ej2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=q1IvTayn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 9si32905431pgn.524.2019.01.28.10.12.32; Mon, 28 Jan 2019 10:12:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=q1IvTayn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727052AbfA1SKo (ORCPT + 99 others); Mon, 28 Jan 2019 13:10:44 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:39840 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726813AbfA1SKn (ORCPT ); Mon, 28 Jan 2019 13:10:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6rz65wMwPx6JKLj0U1uilByOkexizZwcOOx3zNkZijo=; b=q1IvTaynFHN1BL8y2u5k5Ulg4 NIfPexZIfLk2CmjsCKouFG2BjmaoyVvLUPjpaVPY27GByqiCQukZ+wZeIG/hoEKRNPahVlLVYT88R O2bxqAxvva/7zarmzSLFl+8xoH3daRZdObubkoHdWwMISzbGlh8bcfiz7iO8plWzqMVrs=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1goBMl-00038Y-Mt; Mon, 28 Jan 2019 18:10:39 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id B1A241127D29; Mon, 28 Jan 2019 18:10:38 +0000 (GMT) Date: Mon, 28 Jan 2019 18:10:38 +0000 From: Mark Brown To: Jonas Bonn Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org Subject: Re: [PATCH v3 1/2] spi: support inter-word delay requirement for devices Message-ID: <20190128181038.GF11699@sirena.org.uk> References: <20190126163220.26421-1-jonas@norrbonn.se> <20190126163220.26421-2-jonas@norrbonn.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uTRFFR9qmiCqR05s" Content-Disposition: inline In-Reply-To: <20190126163220.26421-2-jonas@norrbonn.se> X-Cookie: I think we're in trouble. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --uTRFFR9qmiCqR05s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Jan 26, 2019 at 05:32:19PM +0100, Jonas Bonn wrote: > @@ -164,6 +166,7 @@ struct spi_device { > char modalias[SPI_NAME_SIZE]; > const char *driver_override; > int cs_gpio; /* chip select gpio */ > + uint16_t word_delay; /* inter-word delay (us) */ This needs some code in the core joining it up with the per-transfer word delay similar to what we have for speed_hz and bits_per_word in __spi_validate(). Then the controller drivers can just look at the per-transfer value and support both without having to duplicate logic. --uTRFFR9qmiCqR05s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlxPRZ0ACgkQJNaLcl1U h9Ac7Qf+PnvdYqut3vqHiLuZnIkM0rUN8LzkQjuzbXAcNDhc1Mng0wacMxY8/197 iHfg/0ZtyZGvI3LXfVstZaUtryS7tT5sUzuf7zLhUMANNTPT73J+RxabEMojYVdC gXAcYSvZklqJW1C8SPR+KyxvrrkVJzfTDOt1QjIP2RuKTzqqrXZMXsUyw+8ZveMP kfDi8HPRqFwpN3TnofAUG8pXYFWUnuBqYBZtZ1p44E741r3DXPP2aT3JMNEvl3lI Du0WLYv06i4T8VjinvD7aChUtWcPdBYBjh157S+/E7YExhJvqXFKav7BtPc54VJu Z/iGAOazu9hGpRh6EnHpkMMyFfyNqA== =ilNl -----END PGP SIGNATURE----- --uTRFFR9qmiCqR05s--