Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262071AbUCDSrN (ORCPT ); Thu, 4 Mar 2004 13:47:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262070AbUCDSrN (ORCPT ); Thu, 4 Mar 2004 13:47:13 -0500 Received: from fw.osdl.org ([65.172.181.6]:51405 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S262072AbUCDSrC (ORCPT ); Thu, 4 Mar 2004 13:47:02 -0500 Date: Thu, 4 Mar 2004 10:53:15 -0800 (PST) From: Linus Torvalds To: Brian Gerst cc: Meelis Roos , linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH] PnP BIOS exception fixes In-Reply-To: <404769B5.7080900@quark.didntduck.org> Message-ID: References: <404769B5.7080900@quark.didntduck.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 914 Lines: 23 On Thu, 4 Mar 2004, Brian Gerst wrote: > > This patch fixes two errors in fixup_exception() for PnP BIOS faults: > - Check for the correct segments used for the BIOS > - Fix asm constraints so that EIP and ESP are properly reloaded I'm almost certain that you should NOT use "g" as a constraint, since that allows the address to be on the stack frame, so when we compile without frame pointers and the compiler uses a %esp-relative thing for the branch address, that will totally screw up when we just re-loaded %esp inside the asm. Can you use "r" instead, and test that it all works for you, and send an updated patch? Or just explain why I'm wrong. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/