Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 28 Jan 2019 17:48:04 -0300
From:   Paul Cercueil <paul@crapouillou.net>
Subject: Re: Add Ingenic X1000 RTC support.
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     Zhou Yanjie <zhouyanjie@zoho.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
        a.zummo@towertech.it, robh+dt@kernel.org, paul.burton@mips.com,
        mark.rutland@arm.com, syq@debian.org, jiaxun.yang@flygoat.com,
        772753199@qq.com
Message-Id: <1548708484.7511.3@crapouillou.net>
In-Reply-To: <20190128201014.GB18309@piout.net>
References: <1548696599-53639-1-git-send-email-zhouyanjie@zoho.com>
        <20190128201014.GB18309@piout.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

> Hello,
> 
> This seems like a useless renaming to me, can you elaborate a bit 
> more?
> 
> I'd also like to have Paul and Lars-Peter comment.

According to the patchset, the RTC in the X1000 does not behave any 
different
than the one in the JZ4780 SoC. Therefore patches 1/2 should be dropped.
In your devicetree bindings, just use the "ingenic,jz4780-rtc" 
compatible
string instead. The same goes for all the drivers (e.g. the uart one).

I don't really mind the renaming, maybe replace "Ingenic JZ47xx SoCs" 
with
just "Ingenic SoCs" since XBurst is just the name of the CPU inside 
these
SoCs.

Regards,
-Paul