Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3922183imu; Mon, 28 Jan 2019 13:23:19 -0800 (PST) X-Google-Smtp-Source: ALg8bN77RkmnVu+bDnGWXASvcxuBjSdSITTyEO2H/s9iWOA/wT6hjeqoOYqArMouioX3RSFthdzl X-Received: by 2002:a17:902:9a9:: with SMTP id 38mr22993715pln.204.1548710599620; Mon, 28 Jan 2019 13:23:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548710599; cv=none; d=google.com; s=arc-20160816; b=SOzlk73QpyMgDsMgNS3zsBOOsicLEohcNqr/pBhFVYjCevKx7yCTXuNXWghiyc2ygK l7ueZREg534ZUf6XwgpsahsB9aVTE3tNbda8B2/A/RRbeZBmKmMLyucZoQI5oYSP47gJ cCLrV3zzliCFP0j7DU6AtrdQCUT2kWFtZqwjEqH7NcnfaOknIixFfiY505AmldZi0KqJ dUg6qgT6gD+pp6X5XKDLMsDgQwf7VfDpOwUBFcYO2RD+Lktj0mMmrP571TFw6zmiXKro yQFsj21lklt4wirJNjqDBZeME288vbzHMSd+OfuF/wDuP1z+YsCi0FkD1miJO2v8Zfrh kEAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=R1tczXKUFzCTDG0EEeYL9B/rEiyBaMRbEigEvPcalsM=; b=o0u8DFUfrpUIFpp5y55TH/nGCw3CBs0vSNVO7Mm7KnfGfSohmu02u6uvrTOMjR+bqK aRzw+uZubAdzF7c6lIygRdcLIhh7nXy/KkZ3naCpQv1cLTziYBFvJGPIDi5CHoLiNlAQ m76syGXgVgkqwHMiLGiMZn3hH1nMM9IpkuIl27OQOmHzjJHwNDpaz80eiTmWT+maMVKn K3mbx8/YmXIa2Q6AY8Kl3uK7uA51yT8CpvX65P4030TdA7Txa6JkVHe0bgHV2XwgYcNP 2hEbRRWI2M681HVuUUU46d92WxUgfN0dkTbtKJUQIzmz8kcm7WOr6DjuHgZNcN+QjXmF 5NGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=BWUNZDIv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z136si22821135pgz.28.2019.01.28.13.23.03; Mon, 28 Jan 2019 13:23:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=BWUNZDIv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727039AbfA1VWL (ORCPT + 99 others); Mon, 28 Jan 2019 16:22:11 -0500 Received: from mail-yb1-f195.google.com ([209.85.219.195]:41355 "EHLO mail-yb1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726744AbfA1VWK (ORCPT ); Mon, 28 Jan 2019 16:22:10 -0500 Received: by mail-yb1-f195.google.com with SMTP id n6so1913023ybg.8 for ; Mon, 28 Jan 2019 13:22:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=R1tczXKUFzCTDG0EEeYL9B/rEiyBaMRbEigEvPcalsM=; b=BWUNZDIv09sdTYAuXBiMqvx25t8xYdms70LlJhXdraVVD4ND8QZS1Egu8kl28LrAv4 2rsNe0xfjtXsa/7pAXDQX6XO7sQieqd+EoOUKyCtprrkAymp9xe1Aeo74Y3eoOJVKeVx I0w6f357EMaAsZhJCUprEfPEHCLSP0tmMJuLaozqSHfrax7T2Pd23uVXFhJM/TXo9Rtj PtLwtSrHs9eF41prnQYcst3HKBz6IZj/I4ryQ30PPfy07J7OPxoEMq7LNSjHJp/VE7vL sg4s3VlxembefLFtixuvyf9Ov0Z+CqLqVM1dYMADBiaWsKBM2idCLIzQtE30kWIsBQOi 9yig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=R1tczXKUFzCTDG0EEeYL9B/rEiyBaMRbEigEvPcalsM=; b=Re8QqoU1TNOIRFZGnSwepsZQKfOXoOD73l+9CzZVgthleUTr37LJv7k4Uhn8ajfJ4q 9ALfDLVo73xRMkcKEMKPDWNSVrw4hguu6IfAkVxaRZrK1aaeG+AS9LkbEe22KaZh+BSO q5q8Pv4cmJybzvepNcDO+NkgR0fjRA64dN3UblpIaH1o9ZnC1VCgDoRG3KwAFkBjkv7p TXH0uRDKEqLYsiRm8607YeOyMWdjACiiy4uWsE8BvoHufke9wJOJ9uNO5t9mrrqNfN6i vYqR5HiVPhSO0ZN8fbwKbpK+YIxtkzl9qe6b/QOlSg6N4/QJekbl4hzz0NUdzzDr96cQ Abhw== X-Gm-Message-State: AJcUukceSFMbNrJBvyND6ar6qlL1QmzXdT0eoRHfNaSb4hjqzq22CwLQ sVf8UGAGMFssTZ1vg3Hy3DYU+g== X-Received: by 2002:a25:cc04:: with SMTP id l4mr16091947ybf.50.1548710529969; Mon, 28 Jan 2019 13:22:09 -0800 (PST) Received: from localhost ([2620:10d:c091:200::5:42c8]) by smtp.gmail.com with ESMTPSA id i128sm13849151ywb.82.2019.01.28.13.22.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Jan 2019 13:22:09 -0800 (PST) Date: Mon, 28 Jan 2019 16:22:08 -0500 From: Johannes Weiner To: Suren Baghdasaryan Cc: gregkh@linuxfoundation.org, tj@kernel.org, lizefan@huawei.com, axboe@kernel.dk, dennis@kernel.org, dennisszhou@gmail.com, mingo@redhat.com, peterz@infradead.org, akpm@linux-foundation.org, corbet@lwn.net, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v3 3/5] psi: introduce state_mask to represent stalled psi states Message-ID: <20190128212208.GA1416@cmpxchg.org> References: <20190124211518.244221-1-surenb@google.com> <20190124211518.244221-4-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190124211518.244221-4-surenb@google.com> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 24, 2019 at 01:15:16PM -0800, Suren Baghdasaryan wrote: > The psi monitoring patches will need to determine the same states as > record_times(). To avoid calculating them twice, maintain a state mask > that can be consulted cheaply. Do this in a separate patch to keep the > churn in the main feature patch at a minimum. > This adds 4-byte state_mask member into psi_group_cpu struct which > results in its first cacheline-aligned part to become 52 bytes long. > Add explicit values to enumeration element counters that affect > psi_group_cpu struct size. > > Signed-off-by: Suren Baghdasaryan Acked-by: Johannes Weiner