Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3925956imu; Mon, 28 Jan 2019 13:28:15 -0800 (PST) X-Google-Smtp-Source: ALg8bN6/VtWLweR57OHI3e42ehfk1h9lh1Tw31NmPZl6WmMm+u2qCRlbSSzGw0SuPk18F/jnm1QS X-Received: by 2002:a62:7a8b:: with SMTP id v133mr23905029pfc.159.1548710895431; Mon, 28 Jan 2019 13:28:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548710895; cv=none; d=google.com; s=arc-20160816; b=02DfrWmYrq84U6re28Cvxh4XqmFe4XyhLuOqI4NyTiVau5DnNHEMLAEMnVMI7BK5Nq gwKPOLPwHq9U+ov6L9y3D9e0G0CLTNPdqpbpjpAGREyARugslYKcXkiUQEcimEFSsUF8 RNNSYbzCNE53p1HFLekDKDa2WPRhGVGQC91B6QrEdtgxsLqF9eilVfr75Loomp7pRUWX RwPiDgM5LbtcX8xSf1HVnhWGg6UPf2UZu88NHjHFEk9Q5HfegaQ4/5C0Nw8hFj/3GchY TCUiGZ3WW51/oCHFyzQkdQux3LLnBoXzcqbGNb5kXRE72fEtH2k10E55r2hrC+G4WtyP lIcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=xTo5Ja+pGcWl6jpPNnYiTtK2+nvCWhFDYZSf8GBSXJs=; b=zT2W6RNvlDjoacAivWdGaXK0xSpkqbuBOZtYJmNRy5L2y0fMHGZ+NzzUtBWBV7hnmC bg8A6vlBGzabzNFgFjxoYMctKBiPEBlUS8U1IUYCMc8QNTr2e++gHGKsX8HAfpyT3BvU pHNrJOvhWzRDLGIXN8FYLOoQ04cT8BjOXKRvmfPZ/hY2t0QKqWt23lpIvB0axPevRKDK C3CPMEXw3ynACX8kQgWRzHcGiYSDBsgUj5Dub7Yywngyf+Saq+C2PXJe6ljS4c6gJzB8 h49XKcNoq/Dzc6lGybNVSCjBk8tvCW2JNqy+k1NafvnxJeUO6jOeo1vRjUY3KWF0zFSv t9eA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j14si12000661pgg.44.2019.01.28.13.28.00; Mon, 28 Jan 2019 13:28:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728153AbfA1VYq (ORCPT + 99 others); Mon, 28 Jan 2019 16:24:46 -0500 Received: from mail-yb1-f181.google.com ([209.85.219.181]:39527 "EHLO mail-yb1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726798AbfA1VYq (ORCPT ); Mon, 28 Jan 2019 16:24:46 -0500 Received: by mail-yb1-f181.google.com with SMTP id s17so7322630ybp.6; Mon, 28 Jan 2019 13:24:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=xTo5Ja+pGcWl6jpPNnYiTtK2+nvCWhFDYZSf8GBSXJs=; b=GLIxy9h411ezcpVwyFzTZdYRFLLwbEbhq/7umVQ/MlDnva6rbLM9A8iOIF+Od9kU2c Ntxk0hmuiZYo5sUaZbvvJTPVY4cs4LeYXP3Blr0iRdSwHLa9T+ZrU4JGtVUBFy9vPf9s 6HeuLX0/xCkskh1YfNi8vfZz0Tl/JgpQwPzzQiTF4fC2lZ34Se09HkNYINzrQfbqKdfO d3jp2RVVrTsh06RRBFxtI7qpRwRpRHWKRfGrIkt4mepqLIcaOb3NAWKCSj9qVITFy+qq vk79I0ZfTDIToiVJbiGL9tnosKKSdXUQOy5NWozNhuqQrw6yGB3Ev00XwzfhNnajwa5e WTUw== X-Gm-Message-State: AHQUAuZadDrLawtNVFedSRyIr/CuWP5WSbYU6rV1QKjh7GwfBmTC6tnl 2xlktrMv1iDjF/RtFELuwPY9O7JF X-Received: by 2002:a5b:806:: with SMTP id x6mr2514601ybp.352.1548710684707; Mon, 28 Jan 2019 13:24:44 -0800 (PST) Received: from dennisz-mbp.thefacebook.com ([199.201.65.135]) by smtp.gmail.com with ESMTPSA id a7sm24170415ywb.18.2019.01.28.13.24.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 28 Jan 2019 13:24:43 -0800 (PST) From: Dennis Zhou To: David Sterba , Josef Bacik , Chris Mason , Omar Sandoval , Nick Terrell Cc: kernel-team@fb.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Dennis Zhou Subject: [PATCH 00/11] btrfs: add zstd compression level support Date: Mon, 28 Jan 2019 16:24:26 -0500 Message-Id: <20190128212437.11597-1-dennis@kernel.org> X-Mailer: git-send-email 2.13.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi everyone, This is a respin of [1] which aims to add zstd compression level support. V3 moves away from the using set_level() to resize workspaces in favor of just allocating a workspace of the appropriate level and using a timer to reclaim unused workspaces. Zstd compression requires different amounts of memory for each level of compression. The prior patches implemented indirection to allow for each compression type to manage their workspaces independently. This patch uses this indirection to implement compression level support for zstd. As mentioned above, a requirement that differs zstd from zlib is that higher levels of compression require more memory. To manage this, each compression level has its own queue of workspaces. A global LRU is used to help with reclaim. To guarantee forward progress, a max level workspace is preallocated and hidden from the LRU. When getting a workspace, it uses a bitmap to identify the levels that are populated and scans up. If it finds a workspace that is greater than it, it uses it, but does not update the last_used time and the corresponding place in the LRU. This provides a mechanism to decrease memory utilization as we only keep around workspaces that are sized appropriately for the in use compression levels. By knowing which compression levels have available workspaces, we can recycle rather than always create new workspaces as well as take advantage of the preallocated max level for forward progress. If we hit memory pressure, we sleep on the max level workspace. We continue to rescan in case we can use a smaller workspace, but eventually should be able to obtain the max level workspace or allocate one again should memory pressure subside. The memory requirement for decompression is the same as level 1, and therefore can use any of available workspace. The number of workspaces is bound by an upper limit of the workqueue's limit which currently is 2 (percpu) limit). Second, a reclaim timer is used to free inactive/improperly sized workspaces. The reclaim timer is set to 67s to avoid colliding with transaction commit (every 30s) and attempts to reclaim any unused workspace older than 45s. Repeating the experiment from v2 [1], the Silesia corpus was copied to a btrfs filesystem 10 times and then read back after dropping the caches. The btrfs filesystem was on an SSD. Level Ratio Compression (MB/s) Decompression (MB/s) 1 2.658 438.47 910.51 2 2.744 364.86 886.55 3 2.801 336.33 828.41 4 2.858 286.71 886.55 5 2.916 212.77 556.84 6 2.363 119.82 990.85 7 3.000 154.06 849.30 8 3.011 159.54 875.03 9 3.025 100.51 940.15 10 3.033 118.97 616.26 11 3.036 94.19 802.11 12 3.037 73.45 931.49 13 3.041 55.17 835.26 14 3.087 44.70 716.78 15 3.126 37.30 878.84 [1] https://lore.kernel.org/linux-btrfs/20181031181108.289340-1-terrelln@fb.com/ This patchset contains the following 11 patches: 0001-btrfs-add-macros-for-compression-type-and-level.patch 0002-btrfs-rename-workspaces_list-to-workspace_manager.patch 0003-btrfs-manage-heuristic-workspace-as-index-0.patch 0004-btrfs-unify-compression-ops-with-workspace_manager.patch 0005-btrfs-add-helper-methods-for-workspace-manager-init-.patch 0006-btrfs-add-compression-interface-in-get-put-_workspac.patch 0007-btrfs-move-to-fn-pointers-for-get-put-workspaces.patch 0008-btrfs-plumb-level-through-the-compression-interface.patch 0009-btrfs-change-set_level-to-bound-the-level-passed-in.patch 0010-btrfs-zstd-use-the-passed-through-level-instead-of-d.patch 0011-btrfs-add-zstd-compression-level-support.patch 0001 adds macros for type_level conversion. 0002 renames workspaces_list to workspace_manager. 0003 moves back to managing the heuristic workspaces as the index 0 compression level. 0004-0007 unify operations with the workspace_manager with 0007 moving to compression types owning their workspace_manager. 0008-0010 plumbs level throughout the compression level getting interface and converts set_level() to be a bounding function rather than setting level on a workspace. 0011 adds zstd compression level support. This patchset is on top of kdave#master d73aba1115cf. diffstats below: Dennis Zhou (11): btrfs: add macros for compression type and level btrfs: rename workspaces_list to workspace_manager btrfs: manage heuristic workspace as index 0 btrfs: unify compression ops with workspace_manager btrfs: add helper methods for workspace manager init and cleanup btrfs: add compression interface in (get/put)_workspace() btrfs: move to fn pointers for get/put workspaces btrfs: plumb level through the compression interface btrfs: change set_level() to bound the level passed in btrfs: zstd use the passed through level instead of default btrfs: add zstd compression level support fs/btrfs/compression.c | 251 ++++++++++++++++++-------------------- fs/btrfs/compression.h | 39 +++++- fs/btrfs/ioctl.c | 2 +- fs/btrfs/lzo.c | 31 ++++- fs/btrfs/super.c | 10 +- fs/btrfs/tree-checker.c | 4 +- fs/btrfs/zlib.c | 45 +++++-- fs/btrfs/zstd.c | 261 ++++++++++++++++++++++++++++++++++++++-- 8 files changed, 485 insertions(+), 158 deletions(-) Thanks, Dennis