Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-PHdr: =?us-ascii?q?9a23=3AzZIUQB0jcRTnjap/smDT+DRfVm0co7zxezQtwd8Z?=
 =?us-ascii?q?se0eKPad9pjvdHbS+e9qxAeQG9mDu7Qc06L/iOPJYSQ4+5GPsXQPItRndiQuro?=
 =?us-ascii?q?EopTEmG9OPEkbhLfTnPGQQFcVGU0J5rTngaRAGUMnxaEfPrXKs8DUcBgvwNRZv?=
 =?us-ascii?q?JuTyB4Xek9m72/q99pHPYAhEniaxba9vJxiqsAvdsdUbj5F/Iagr0BvJpXVIe+?=
 =?us-ascii?q?VSxWx2IF+Yggjx6MSt8pN96ipco/0u+dJOXqX8ZKQ4UKdXDC86PGAv5c3krgfM?=
 =?us-ascii?q?QA2S7XYBSGoWkx5IAw/Y7BHmW5r6ryX3uvZh1CScIMb7Vq4/Vyi84Kh3SR/okC?=
 =?us-ascii?q?YHOCA/8GHLkcx7kaZXrAu8qxBj34LYZYeYNP9/fqPGZtMaRGxBXslMXCJfG423?=
 =?us-ascii?q?coUPD+sfMuZcsob2ul8CoBWiCQWpAu7k1z1GiWLs3aAi0+ovDxzI0gIjEdwJq3?=
 =?us-ascii?q?nYsMn5Ob0OXe2v0KXE0TPOZO5W1zfn74jIdwgsrvONXbNxccrR1E4vHB7Cg1SQ?=
 =?us-ascii?q?qI3lPyma1uURv2SH4edtTv+vhHI9qw1rvDeg29osh5DPi4kIyV7E7T10zJgpKd?=
 =?us-ascii?q?C8UkJ2Yt6pHIFOuy2HOIZ6WN4uTmVstSoi17ELuJq2cDIUxJkpxxPTceKLfomS?=
 =?us-ascii?q?7h/hW+ucJypzimh/d7KlnRmy9FCtyuj7VsapzllHtjFFktzQtnAV0BzT99SHRu?=
 =?us-ascii?q?N9/ki/3TaP0Bje6uReLkA1karXMoYhwrotmpYKv0TPAyv7lUHsgK+ZcUUk/eeo?=
 =?us-ascii?q?6+D5bbn8upCcMIp0hhn/MqQohMO/Hfw1PhYSU2Wf4+ix173u8VfnTLlXgfA6iL?=
 =?us-ascii?q?TVvZTeKMgDo662GQ5V0oIt6xalCDem1cwVnHkGLVJFYh2HjpTlN03ALf3jEPew?=
 =?us-ascii?q?n06snC11yP/bI73tGo/NIWTbkLf9YbZ97FZRyA4yzdBZ+pJVBagNIPHtVU/rst?=
 =?us-ascii?q?zXEBs5Pheqw+boFtp9zJkSWWGRDa+DNqPdr1uI6vgoI+mWa49G8BjnLP1w1v/8?=
 =?us-ascii?q?jWI+0QsMb6mg3MNPM1ilFe4gLkmENym/yuwdGHsH61JtBNfhj0ePBHsMP3s=3D?=
From:   Yizhuo <yzhai003@ucr.edu>
Cc:     csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, Yizhuo <yzhai003@ucr.edu>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH] gpu: ipu-v3: Variable "val" in function ipu_prg_get_pre() could be uninitialized
Date:   Mon, 28 Jan 2019 14:55:24 -0800
Message-Id: <20190128225524.14865-1-yzhai003@ucr.edu>
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

In function ipu_prg_get_pre(), local variable "val" could
be uninitialized if function regmap_read() returns -EINVAL.
However, this value is used in if statement. This is
potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
---
 drivers/gpu/ipu-v3/ipu-prg.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/ipu-v3/ipu-prg.c b/drivers/gpu/ipu-v3/ipu-prg.c
index 0013ca9f72c8..df12777d9be7 100644
--- a/drivers/gpu/ipu-v3/ipu-prg.c
+++ b/drivers/gpu/ipu-v3/ipu-prg.c
@@ -210,6 +210,7 @@ static int ipu_prg_get_pre(struct ipu_prg *prg, int prg_chan)
 		if (!ret) {
 			u32 val, mux;
 			int shift;
+			int err;
 
 			prg->chan[prg_chan].used_pre = i;
 
@@ -221,7 +222,12 @@ static int ipu_prg_get_pre(struct ipu_prg *prg, int prg_chan)
 
 			/* check other mux, must not point to same channel */
 			shift = (i == 1) ? 14 : 12;
-			regmap_read(prg->iomuxc_gpr, IOMUXC_GPR5, &val);
+			err = regmap_read(prg->iomuxc_gpr, IOMUXC_GPR5, &val);
+			if (err < 0) {
+				dev_err(prg->dev, "read IOMUXC_GPRS failed\n");
+				return err;
+			}
+
 			if (((val >> shift) & 0x3) == mux) {
 				regmap_update_bits(prg->iomuxc_gpr, IOMUXC_GPR5,
 						   0x3 << shift,
-- 
2.17.1