Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3998211imu; Mon, 28 Jan 2019 15:03:55 -0800 (PST) X-Google-Smtp-Source: ALg8bN7DPgwfofphgTX5JfUBUpvUJSozCGCy/pCSMtfeIIPMRq5yU1oO6Tt8oohXOXLROslBG8Hf X-Received: by 2002:a62:1289:: with SMTP id 9mr24075749pfs.102.1548716635896; Mon, 28 Jan 2019 15:03:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548716635; cv=none; d=google.com; s=arc-20160816; b=lv76MMPkpilvYLQQkgF199EwH5ZD5o5exUiS7LNGWHUs+yRKtcaXR4hJhV2rR18nzm ZsIevIl2g0lxw1I9R788hMPum1LxqKmtyKCRYv0GgNaE661BMTLrGoTS3rb4XT1074fa s48+5c95mR0Z5wH2axeRzbfHStHcmg2Uz6N9q1W7kj/EtJCZCOV9aHStrStau7PZB1bO o38a/Ihi/IRhBDa6yoamCkF425NJg9q7owg9trUxWU5vVoCoMrJmOmMDjYgyCI/cNgGS 3nzZIUV9luzYyI5UKPlAMf+rBN5ZUvRR/V64PUFEmRLiwE3Ql999LeNRA6FFR/xYEPR2 CFwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=vxgoQPA6ZPYEYvlFa80nTtCjSTPua4RFULptDtxyoro=; b=Aoxn3tirP9MirPUFiETEy682ZWjv9X7l6V1oH4UgHmgnTLp5NMPVNpNiVwewxde8EU ARJaLhlfIAqgQN+GrEx2LpazCMaiGCE3sNpgdCnjeELSLOVzDW8m/1XFVf73cRT8hSNg Sb/JcniAvqVcUbDrH7ikw/qZFgC37WNTtcc/KJPsikwKKCdhbU9d7JVDwNFvoiMaC9GW bmJbf5xftYSo1dj5QmmJw+fyRKcSH7FOA0uahhhpJuvuSj4DmSH5XijFxPuLoaKawgNZ jyW1oToCfrmaHEWoDNMd65yZzn8YBddMoBbUK4385ceX6EG7x6Rc+LWQAG3QYF5+PqyF aIdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ffnL71qR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g17si3414997pgi.578.2019.01.28.15.03.38; Mon, 28 Jan 2019 15:03:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ffnL71qR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726977AbfA1XBx (ORCPT + 99 others); Mon, 28 Jan 2019 18:01:53 -0500 Received: from mail-yb1-f193.google.com ([209.85.219.193]:34390 "EHLO mail-yb1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726678AbfA1XBx (ORCPT ); Mon, 28 Jan 2019 18:01:53 -0500 Received: by mail-yb1-f193.google.com with SMTP id k9so6917882ybg.1 for ; Mon, 28 Jan 2019 15:01:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vxgoQPA6ZPYEYvlFa80nTtCjSTPua4RFULptDtxyoro=; b=ffnL71qRlAnZTtFGlt0tV8/oBIKgUbazgwFjcSNAP3j3TtaFNQ31yI4TV0qI1Cgsth cnjSWNDrhNzaSiRCAmKQnAp+p8r9ENst3w8mS9MyRIk47sNRKJpksXNZJTCSLBa+RvqC rMQisXqBkhPPlChjyExdnINQ69derhJCtmHt4t4Dtg0jGVcShfdxwuzmLwn1oT/0w95y bvfjq9tW/HVRSk3cOcPnInCl7hGYaE3pMqyctAySJ5ghakHJAK0RVt7gm5qjVIlTrncj sCd+4zaVmF7QdbhIrs/k7sBgZiDKTbn2EqncBLmI2EMZrHivMjZg6CNyUsdHb4mzpdiq tIGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=vxgoQPA6ZPYEYvlFa80nTtCjSTPua4RFULptDtxyoro=; b=DtoV1GWZPr22dQjoAoWr1VRiWSdkjm7r6hKL3j/ZKN+zIpnKbI0TDji0myxjhgRMxs tAULYq+hUMYvJQNa8Cq8O/Cny1rciEdYkXEP/b2d7qlRLnB6MgI4laMCUa2jYuU4WL4o Ld72GdD4tS2MJ1ANTuLZeUGmHQUAL55V29c0b+G82nO70wA/Qv/9uBHIQm7+dyKpoJDs 6ygRPjuwpDJGFGVnXSqVHHwcy8u7nV0gghhWRxvE0mk9mu+9P01xjGp4Kczg8jSRmSgW py5oB3RDgI0NFF9RdYw4gApIYZETzfRU1sIpkijNI6u0/MRepvSNHJ+CG8pnBto/bRig UzMA== X-Gm-Message-State: AHQUAuYPPtdNvK96pDh3d4OubwJgh1O2mMg4MzwdR2Kx8E85ZSCiizsZ IjAYq12Ck1ZY1nC8R7MBk0g= X-Received: by 2002:a25:bcc3:: with SMTP id l3mr1677649ybm.478.1548716512207; Mon, 28 Jan 2019 15:01:52 -0800 (PST) Received: from localhost ([2620:10d:c091:200::7:31a1]) by smtp.gmail.com with ESMTPSA id m126sm14426774ywd.39.2019.01.28.15.01.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 15:01:51 -0800 (PST) Date: Mon, 28 Jan 2019 15:01:49 -0800 From: Tejun Heo To: Johannes Weiner Cc: Peter Zijlstra , Andrew Morton , Suren Baghdasaryan , Lai Jiangshan , linux-kernel@vger.kernel.org Subject: Re: [PATCH] psi: fix aggregation idle shut-off Message-ID: <20190128230149.GW50184@devbig004.ftw2.facebook.com> References: <20190116193501.1910-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190116193501.1910-1-hannes@cmpxchg.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Wed, Jan 16, 2019 at 02:35:01PM -0500, Johannes Weiner wrote: > +/** > + * wq_worker_last_func - retrieve worker's last work function > + * > + * Determine the last function a worker executed. This is called from > + * the scheduler to get a worker's last known identity. Maybe it can describe better why this is safe in this use case and not suitable as a generic interface but other than that, Acked-by: Tejun Heo Thanks. -- tejun