Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp383698imu;
        Fri, 25 Jan 2019 04:07:36 -0800 (PST)
X-Google-Smtp-Source: ALg8bN5/suY0JanJxKFgnAlG4gIWVi/Zz/5FfI2iascKY76NWQ20k8mEED4couYP3lEbM/Y/3hIX
X-Received: by 2002:a17:902:7588:: with SMTP id j8mr10838381pll.215.1548418056799;
        Fri, 25 Jan 2019 04:07:36 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1548418056; cv=none;
        d=google.com; s=arc-20160816;
        b=zX1fgxN3LPPNKucnk6m83hI6odx/NDREE0GADzFSBCxQ4AwpPlak+fhdKR/bItYWuL
         8D72eJ+HzARthmL2/Itp4KewCZdBcCS/D4c1pNoA7/g241mhxvCfsOVelsM8zZmvX6K7
         wktbycQaHRoTYO2TIkrLZuwzgV5uYUHbtSoT71B7gL5Fhw0oN6XuLg39rk81j4DD8Nbf
         hS1e4qKbAgE7+31zxbpuPWQua6TuAgNBdwhb4taP9PKpC7Q1A3S211KP5IPxN5bEfCCL
         us8KIUYDzfG8Z/LQ9THNQFNtBDBbEkjnKdp9GvGxrw61oz/5mG6WK7i0zhL49YMWkDXM
         sB7g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:references:cc:to:from:subject;
        bh=52DdgeQgGbRQd70/mlPU5RXi/79u+o+2v3jVDcM9BgY=;
        b=v3fF8Sut19lenFy32z0tIYwn7ClkJ0eYPaNPqz+N9TgAzFWfWS5IcikTs7NqA/c5t5
         V5FLV4WPqgEYxV2CbrWctfVx8Ugm9lBY5s5eY+p+QXwI7Ini/sCA/rbFgkVEzLEaaOw0
         ZLzHm1rc3IId+oiPmbWjhcUHWYK81HUw8EpgBVGAtDqgmVzkaGM7XE8+6qq1eyCLveyw
         u+wCdlDVy02lFWhQaItzTNbebXB9c7/+DQzpqiybcaUg4dOMf1zfrPDt3NT9PfArbiM0
         lH/l2dBOwUVLWMKJiQS7qkKG5lowxNhz1oCcLOimHEmjihkmYS8vKwPboHBdJVjYgrrS
         MG0Q==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=m4Ye+8NM;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id u20si4131535plj.129.2019.01.25.04.07.20;
        Fri, 25 Jan 2019 04:07:36 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=m4Ye+8NM;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728238AbfAYMGx (ORCPT <rfc822;zcyberian@gmail.com> + 99 others);
        Fri, 25 Jan 2019 07:06:53 -0500
Received: from hqemgate15.nvidia.com ([216.228.121.64]:9446 "EHLO
        hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726026AbfAYMGv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 25 Jan 2019 07:06:51 -0500
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5c4afbc10002>; Fri, 25 Jan 2019 04:06:25 -0800
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Fri, 25 Jan 2019 04:06:50 -0800
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Fri, 25 Jan 2019 04:06:50 -0800
Received: from [10.21.132.148] (10.124.1.5) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 25 Jan
 2019 12:06:48 +0000
Subject: Re: [PATCH 1/6] dt-bindings: timer: add Tegra210 timer
From:   Jon Hunter <jonathanh@nvidia.com>
To:     Joseph Lo <josephl@nvidia.com>,
        Thierry Reding <thierry.reding@gmail.com>
CC:     <devicetree@vger.kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        <linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        <linux-arm-kernel@lists.infradead.org>
References: <20190107032810.13522-1-josephl@nvidia.com>
 <20190107032810.13522-2-josephl@nvidia.com>
 <a5fec080-d388-5362-7f44-b50f7d7e1adf@nvidia.com>
 <285bd3f7-e1c0-0767-6381-4b1d748bd6db@nvidia.com>
 <381f94c0-6c19-0f5b-df06-91353455a4c0@nvidia.com>
Message-ID: <709e24fa-02e1-96ea-2b20-acf150caff00@nvidia.com>
Date:   Fri, 25 Jan 2019 12:06:47 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <381f94c0-6c19-0f5b-df06-91353455a4c0@nvidia.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1548417985; bh=52DdgeQgGbRQd70/mlPU5RXi/79u+o+2v3jVDcM9BgY=;
        h=X-PGP-Universal:Subject:From:To:CC:References:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=m4Ye+8NMkqSLhS5/KxFM7SBEYqyiWBqAZb+3coUEbF8JAsV6SakU6K4Q1V00I60xM
         0BNaWEjLfKf25MLfX23QhREbXFWLRF3DgHNCR1MNNnGo4A4zj4vr6BdqJ8LtaUHqbX
         E91NNE/ILifqJY9XtLj4Ekx5PC2j2oYYgXlBoOkG3OoEhI/NS+UeTljtn+IzAFnEI2
         HRUxhpIOQlyWlS0mnFobhs94e87kilRsp9AKFxzKA2AA6oylIVwwPLLpeLwazIxa/Q
         WqgY7QKQOuhNtR6bnlCGYPkGfxP3OHHCBCDGpXLrWmS4/w3Gr0YsRYyWmCnvirrJgD
         Kseuf97osfG9Q==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 25/01/2019 12:01, Jon Hunter wrote:
>=20
> On 25/01/2019 03:23, Joseph Lo wrote:
>> Hi Jon,
>>
>> Thanks for reviewing.
>>
>> On 1/24/19 6:30 PM, Jon Hunter wrote:
>>>
>>> On 07/01/2019 03:28, Joseph Lo wrote:
>>>> The Tegra210 timer provides fourteen 29-bit timer counters and one
>>>> 32-bit
>>>> timestamp counter. The TMRs run at either a fixed 1 MHz clock rate
>>>> derived
>>>> from the oscillator clock (TMR0-TMR9) or directly at the oscillator
>>>> clock
>>>> (TMR10-TMR13). Each TMR can be programmed to generate one-shot periodi=
c,
>>>> or watchdog interrupts.
>>>>
>>>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>>>> Cc: Thomas Gleixner <tglx@linutronix.de>
>>>> Cc: linux-kernel@vger.kernel.org
>>>> Cc: devicetree@vger.kernel.org
>>>> Signed-off-by: Joseph Lo <josephl@nvidia.com>
>>>> ---
>>>> =C2=A0 .../bindings/timer/nvidia,tegra210-timer.txt=C2=A0 | 25 +++++++=
++++++++++++
>>>> =C2=A0 1 file changed, 25 insertions(+)
>>>> =C2=A0 create mode 100644
>>>> Documentation/devicetree/bindings/timer/nvidia,tegra210-timer.txt
>>>>
>>>> diff --git
>>>> a/Documentation/devicetree/bindings/timer/nvidia,tegra210-timer.txt
>>>> b/Documentation/devicetree/bindings/timer/nvidia,tegra210-timer.txt
>>>> new file mode 100644
>>>> index 000000000000..ba511220a669
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/timer/nvidia,tegra210-timer.tx=
t
>>>> @@ -0,0 +1,25 @@
>>>> +NVIDIA Tegra210 timer
>>>> +
>>>> +The Tegra210 timer provides fourteen 29-bit timer counters and one
>>>> 32-bit
>>>> +timestamp counter. The TMRs run at either a fixed 1 MHz clock rate
>>>> derived
>>>> +from the oscillator clock (TMR0-TMR9) or directly at the oscillator
>>>> clock
>>>> +(TMR10-TMR13). Each TMR can be programmed to generate one-shot,
>>>> periodic,
>>>> +or watchdog interrupts.
>>>> +
>>>> +Required properties:
>>>> +- compatible : "nvidia,tegra210-timer".
>>>> +- reg : Specifies base physical address and size of the registers.
>>>> +- interrupts : A list of 4 interrupts; one per each of TMR10 through
>>>> TMR13.
>>>
>>> Why do we only add the interrupts for TMR10 - TMR13? What about the
>>> others?
>>>
>>
>> The others (TMR0-TMR9) are occupied for other usages. TMR5 is occupied
>> for the watchdog timer in the upstream kernel. And others (still in
>> TMR0-TMR9) are occupied for different usages in our downstream kernel.
>=20
> Where is TMR5 reserved for the watchdog? I don't see this?

I see it now, it is hard-coded in the driver. I was looking at arm64 to
see where it is used.

Cheers
Jon

--=20
nvpublic