Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 29 Jan 2019 10:51:44 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Andrea Parri <andrea.parri@amarulasolutions.com>
Cc:     Elena Reshetova <elena.reshetova@intel.com>,
        linux-kernel@vger.kernel.org, keescook@chromium.org,
        Alan Stern <stern@rowland.harvard.edu>,
        Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH] refcount_t: add ACQUIRE ordering on success for
 dec(sub)_and_test variants
Message-ID: <20190129095144.GH28467@hirez.programming.kicks-ass.net>
References: <1548677377-22177-1-git-send-email-elena.reshetova@intel.com>
 <20190128142910.GA7232@andrea>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190128142910.GA7232@andrea>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jan 28, 2019 at 03:29:10PM +0100, Andrea Parri wrote:

> > diff --git a/arch/x86/include/asm/refcount.h b/arch/x86/include/asm/refcount.h
> > index dbaed55..ab8f584 100644
> > --- a/arch/x86/include/asm/refcount.h
> > +++ b/arch/x86/include/asm/refcount.h
> > @@ -67,16 +67,29 @@ static __always_inline void refcount_dec(refcount_t *r)
> >  static __always_inline __must_check
> >  bool refcount_sub_and_test(unsigned int i, refcount_t *r)
> >  {
> > -	return GEN_BINARY_SUFFIXED_RMWcc(LOCK_PREFIX "subl",
> > +	bool ret = GEN_BINARY_SUFFIXED_RMWcc(LOCK_PREFIX "subl",
> >  					 REFCOUNT_CHECK_LT_ZERO,
> >  					 r->refs.counter, e, "er", i, "cx");
> > +
> > +    if (ret) {
> > +               smp_acquire__after_ctrl_dep();
> > +               return true;
> > +    }
> > +
> > +    return false;
> 
> There appears to be some white-space damage (here and in other places);
> checkpatch.pl should point these and other style problems out.

It's worse...

patch: **** malformed patch at line 81: diff --git a/arch/x86/include/asm/refcount.h b/arch/x86/include/asm/refcount.h

And yes, there's a lot of whitespace damage all around. Lots of trailing
spaces too.