Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4462776imu; Tue, 29 Jan 2019 01:53:03 -0800 (PST) X-Google-Smtp-Source: ALg8bN6wNzTkMnzQ7CXztFlcVmPzdky0H2qt4ULsExMVKqOarbTqzJuqUmhIie0qM6mF9PLcpvKi X-Received: by 2002:a62:670f:: with SMTP id b15mr25309799pfc.212.1548755583036; Tue, 29 Jan 2019 01:53:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548755583; cv=none; d=google.com; s=arc-20160816; b=pPUHLCcr88KkEO6zgMR7Z8FaDygRzEMSlNNpop9/HzGzhKJ60e/uY92Ny918rAuNAi 8wIaZUyrGyr75W6Nd9RA3999XLEQBny+Fo/MQQ4Q/qCgx3X7PwN6mI1k4A5Ywz5Ej+pz zX4maxOHV7n9zGZxxHKTXFUGniF32uu8SRBCM7nLyjeUBeIrCb6KENoT+wtZsCrUV730 j9VoLW4lnpiI6vaH8+l6vPTbOV1/xjgtkiVx2Ba386S3OcDKqt+enr9Pp3bkLlE/5DkJ XQ0Q3WNvF2yB8CXgKWf+yBVJ0VBekxE4vcLhUu73FhxpoNqG4cXfJu4QbGZhMAUiP8UP k3DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=e5JIdfOLXA7vK5jRrayApluVxSs2X8eqtZM51YBaQSk=; b=bcwUiibSuc36Xw3TkKvl2KDRD0OS86S1KoMPGtc9f5FkuDTBBNOMQ/Gz2Uce69u75+ VOIJTC5rFGWGdoLqeK48ejccs6o7GqrzrjxoHe6MLIn2bRN7gn7v75za2ADSBmVLVjR3 grtcHsVipJ/hKtVSYnlxVVSqHtrZrIqFEazyieUWn4eAQ1gvZEUQetLpLnK7jHxzIZdr f12cD+u+XYdl/G5tVYcuWK3U2kLYNOV8aOjlbz6ke4UMcCfSHx2iWqxTB8QIBVDgaMY7 J3noSmbVrnhsTMZAuGsxWIhQvhyagHl6PLChU/CGXyeP3qLMvxqGYUQ/stliWwEWrMnj 9r0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y40si37370162pla.251.2019.01.29.01.52.46; Tue, 29 Jan 2019 01:53:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728173AbfA2Jwf (ORCPT + 99 others); Tue, 29 Jan 2019 04:52:35 -0500 Received: from ozlabs.org ([203.11.71.1]:35429 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727039AbfA2Jwe (ORCPT ); Tue, 29 Jan 2019 04:52:34 -0500 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 43phcK6Xzfz9s9h; Tue, 29 Jan 2019 20:52:17 +1100 (AEDT) From: Michael Ellerman To: Mike Rapoport , linux-mm@kvack.org Cc: Andrew Morton , Catalin Marinas , Christoph Hellwig , "David S. Miller" , Dennis Zhou , Geert Uytterhoeven , Greentime Hu , Greg Kroah-Hartman , Guan Xuetao , Guo Ren , Heiko Carstens , Mark Salter , Matt Turner , Max Filippov , Michal Simek , Paul Burton , Petr Mladek , Rich Felker , Richard Weinberger , Rob Herring , Russell King , Stafford Horne , Tony Luck , Vineet Gupta , Yoshinori Sato , devicetree@vger.kernel.org, kasan-dev@googlegroups.com, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-usb@vger.kernel.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp, x86@kernel.org, xen-devel@lists.xenproject.org, Christophe Leroy , Mike Rapoport Subject: Re: [PATCH v2 02/21] powerpc: use memblock functions returning virtual address In-Reply-To: <1548057848-15136-3-git-send-email-rppt@linux.ibm.com> References: <1548057848-15136-1-git-send-email-rppt@linux.ibm.com> <1548057848-15136-3-git-send-email-rppt@linux.ibm.com> Date: Tue, 29 Jan 2019 20:52:17 +1100 Message-ID: <871s4vssdq.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mike Rapoport writes: > From: Christophe Leroy > > Since only the virtual address of allocated blocks is used, > lets use functions returning directly virtual address. > > Those functions have the advantage of also zeroing the block. > > [ MR: > - updated error message in alloc_stack() to be more verbose > - convereted several additional call sites ] > > Signed-off-by: Christophe Leroy > Signed-off-by: Mike Rapoport > --- > arch/powerpc/kernel/dt_cpu_ftrs.c | 3 +-- > arch/powerpc/kernel/irq.c | 5 ----- > arch/powerpc/kernel/paca.c | 6 +++++- > arch/powerpc/kernel/prom.c | 5 ++++- > arch/powerpc/kernel/setup_32.c | 26 ++++++++++++++++---------- > 5 files changed, 26 insertions(+), 19 deletions(-) LGTM. Acked-by: Michael Ellerman cheers