Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4563236imu; Tue, 29 Jan 2019 03:52:31 -0800 (PST) X-Google-Smtp-Source: ALg8bN6OHDN+Z+jEQXhvmecOTbnF3mFlI6S4sD4lQ50UWy/RTX5H7wh9+1T/885p793144K0c/M2 X-Received: by 2002:a63:86c1:: with SMTP id x184mr23203920pgd.305.1548762751869; Tue, 29 Jan 2019 03:52:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548762751; cv=none; d=google.com; s=arc-20160816; b=gJ+8QfByasyUu5mY963UMC7sHhhXIzCegQExWgxhJVFCT6Sl3b1A28STEHcmpKTnPw clV3QZ0qxn2Y2wScaQC5cLweAPIlLWXY7KenPgXRAPA4IY5ugJddoQY3Z5KOv8xeFlsT RXpFDrWQ4Ygpz4PObJWb/DbUe4PknbpnYKMIv15RA9BmPqVUbHPPubdPQvg2f0ZX1shP 3O9z5+xfv2tdO+PzJOtAGzB5tN70DSLk4SAccEA8qh94GyBEF/hHe4A863x/q1aSg2P2 L5woltzmmkkbtyJHUNZOJFNF6r05kVEg1x7NXTJgHsiFhVtx9G8+P0Tj3qv/iSJ82S61 h94w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=X3YUZp5U+nv681/+8TCLzkKwPAris6IIGSQBwXon5qw=; b=qD7R/df6HRKITlzM4+orZ6X2ECPkjpnaD5RHFUN2ADPwtYapqPkxPgISor/8KIadqB +W5Hc/3XvkXzGHxPwVNsQe8oiIVu3tJa5hlBhCplzHB6qhQjUVEqVjkDFd5WUG8Ei5YG dAubYS0iWPeBuEc8rh7n8ZVnhk9lNwOuPzoncumJXyrI1ObiECQ6Ss9K8lcGbdEOrCQn tY2E+Okqmg7CvgsbQMTqEWVkJK/q9gyCdV6pSHbgeUQjMtZFn2T6gsjYFbZsAVZ4U5uJ IZup6jdAnmOoNgFa9455JdfStFqnQ60EEsX6kv6KH2b36WBi2NspkHVkJc1WSyJuSgqR kRrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=D1GsSi+8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g22si34654112pfj.222.2019.01.29.03.52.16; Tue, 29 Jan 2019 03:52:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=D1GsSi+8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731765AbfA2Lu4 (ORCPT + 99 others); Tue, 29 Jan 2019 06:50:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:42238 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731737AbfA2Luu (ORCPT ); Tue, 29 Jan 2019 06:50:50 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5FF6B2083B; Tue, 29 Jan 2019 11:50:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548762649; bh=IeAGCL3jREYY2iQBpEUVSXUjshhnVaoQnElImzJs5tY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D1GsSi+8sx5W7ROey4eDWfZpaCvvGAmUg9p6qKDTAq2j4/ABlrlOQvXWzlOzsDaoO HH2Q2AXR5UIa9s9f+E3QL49SKm6D3J61pFPOqez9o4DWFAN1Hb7MZaGSPXK8mtPikq MIvlkyU2IGA7XNigyQx8N7E9kGjZhJcDwWd48Rfo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kangjie Lu , Pierre-Louis Bossart , Mark Brown Subject: [PATCH 4.9 11/44] ASoC: atom: fix a missing check of snd_pcm_lib_malloc_pages Date: Tue, 29 Jan 2019 12:36:06 +0100 Message-Id: <20190129113140.978372292@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190129113139.826927690@linuxfoundation.org> References: <20190129113139.826927690@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kangjie Lu commit 44fabd8cdaaa3acb80ad2bb3b5c61ae2136af661 upstream. snd_pcm_lib_malloc_pages() may fail, so let's check its status and return its error code upstream. Signed-off-by: Kangjie Lu Acked-by: Pierre-Louis Bossart Signed-off-by: Mark Brown Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- sound/soc/intel/atom/sst-mfld-platform-pcm.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) --- a/sound/soc/intel/atom/sst-mfld-platform-pcm.c +++ b/sound/soc/intel/atom/sst-mfld-platform-pcm.c @@ -399,7 +399,13 @@ static int sst_media_hw_params(struct sn struct snd_pcm_hw_params *params, struct snd_soc_dai *dai) { - snd_pcm_lib_malloc_pages(substream, params_buffer_bytes(params)); + int ret; + + ret = + snd_pcm_lib_malloc_pages(substream, + params_buffer_bytes(params)); + if (ret) + return ret; memset(substream->runtime->dma_area, 0, params_buffer_bytes(params)); return 0; }