Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4564568imu; Tue, 29 Jan 2019 03:54:14 -0800 (PST) X-Google-Smtp-Source: ALg8bN6LbiDIoc3LBh29eDm5u5Cw2ukuEUYJzzhx+l+KurdKWc6hX7z+ZyRf2tB7ADDIDGQi2+bO X-Received: by 2002:a17:902:7791:: with SMTP id o17mr25386105pll.60.1548762854418; Tue, 29 Jan 2019 03:54:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548762854; cv=none; d=google.com; s=arc-20160816; b=xanLL2CFvzoFcnvwhHhKgHHl801Ws4KmbhBuz2laQ8WFcE26jH0Pf1RxPOIqjflMe4 d6b2z/ZgHsvH1k2oLzwUj3EIk9k1dSgB6QERKQCO9JyDPm+PpUvy2sZYnYM2xzZVsyb9 djXdcxX9ghu27eihKScglw4WnJNOXBLrtMmfO4wL8vqVgvdrDyt03snf7rV05qOWsVsE 8GoSjrLrsA+WXWNXCoipr3QeuuHN2LVsHMcmEuyCgnoS4ZE0qe0qIOe45N2oeGMBFVnG T0ap6BFJ5P29x8dRIv47R8bRO9UBLp20Ly7T7MEwovFLJWMN8WFG/HPnsuUs+pPFdaIZ zDvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4ULqarLSOXBVAOjhaiPLXSvrd56XSm8tEBZorJrdgjY=; b=u1V+9/GTeW5kbNPK7MgyBx5zu4jdh5HXgYW7ZBDXvrE+ZQZgcl9zNTiVk2PxlSczoh cSfM3fVQfasTaFct1ugG6+7+IOuy2qDXz8Qw0qK2LNmvFo77rxttA2+6X+Md3iB2KbXm pLZipNwAwZ9AnM014k4enmlM6lyVpzHEm+QwgDVV9Frv7xdpy/xDjREWYPJShHM7YRB5 s2IP2Wr6wZAXB2a0JjTs5YchhTqktgIPY2F2IN37CuhXElLs1dROA46gz6B8mWmfwdHc 1SnJBh3hRFf7+3gUprH3Py5+0NGILZGhuL9VhwD1yb3TbWNyyXomiiN03vHhnrzdzSHw rxQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eZy9Te1X; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x16si26993616pga.407.2019.01.29.03.53.59; Tue, 29 Jan 2019 03:54:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eZy9Te1X; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732024AbfA2LwH (ORCPT + 99 others); Tue, 29 Jan 2019 06:52:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:43744 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732014AbfA2LwE (ORCPT ); Tue, 29 Jan 2019 06:52:04 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D0E42083B; Tue, 29 Jan 2019 11:52:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548762723; bh=XM6UhFt1ViQEe8x++zj0IkKDZfWwJuWbOaNgdN1rCvw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eZy9Te1XMRdlmyN04mr4hJpVu3CFipTub9SiEcs7fOROF5Q7mmNfb6i7pxwmT2deg kDkk8gpowlQobh5exTqhw6vlQt5Abbau7Qep2Ym/8ZBBPcRETO5ENTcY5Yl8tD39rB t+U0Wv+2bofpTFYurYmcbx03XfwewHa+0Ozr57CA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Martin Vuille , Adrian Hunter , David Ahern , Jiri Olsa , Namhyung Kim , Wang Nan , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 4.9 36/44] perf unwind: Unwind with libdw doesnt take symfs into account Date: Tue, 29 Jan 2019 12:36:31 +0100 Message-Id: <20190129113142.838754010@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190129113139.826927690@linuxfoundation.org> References: <20190129113139.826927690@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 3d20c6246690219881786de10d2dda93f616d0ac ] Path passed to libdw for unwinding doesn't include symfs path if specified, so unwinding fails because ELF file is not found. Similar to unwinding with libunwind, pass symsrc_filename instead of long_name. If there is no symsrc_filename, fallback to long_name. Signed-off-by: Martin Vuille Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/r/20180211212420.18388-1-jpmv27@aim.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/util/unwind-libdw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/unwind-libdw.c b/tools/perf/util/unwind-libdw.c index b46e1cf347e5..b34085ae3e32 100644 --- a/tools/perf/util/unwind-libdw.c +++ b/tools/perf/util/unwind-libdw.c @@ -48,7 +48,7 @@ static int __report_module(struct addr_location *al, u64 ip, if (!mod) mod = dwfl_report_elf(ui->dwfl, dso->short_name, - dso->long_name, -1, al->map->start, + (dso->symsrc_filename ? dso->symsrc_filename : dso->long_name), -1, al->map->start, false); return mod && dwfl_addrmodule(ui->dwfl, ip) == mod ? 0 : -1; -- 2.19.1