Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4579605imu; Tue, 29 Jan 2019 04:08:52 -0800 (PST) X-Google-Smtp-Source: ALg8bN7LlMvCMQuYRNgDeTP46cOjkWSFPs2l636zbFTqdNzRC5ffowMmU6gQgrVeAMAaTrDKFIzs X-Received: by 2002:a17:902:704b:: with SMTP id h11mr25906230plt.157.1548763732475; Tue, 29 Jan 2019 04:08:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548763732; cv=none; d=google.com; s=arc-20160816; b=sktw6EtpMnIgpiatRyKpg7yCuvLCoQ/k4eYS8Ac1t54cdQJRIwqLvBNtUpY1PUk4ym SRbaJhRhteAp5mMklYNJ+PI0TU6S9eBLrPSV58AvzLnlPK9w9b4LkCMxdUodnmAFA6rz et2ors9cmNM6CrQQH9ViLj6EZ1ORUNeBNMg94i2wjPoLot1KYtCC3uahiKj1m9Y0Ps5p 19iz/u+XwNaoiPsJ3GJLZczxPmRRKPYneL3q60N2fhkHoGuU/GlnOgsVZBRZD1KKdcjA ghGRbfvewD3X6M7UWAnNjrr6ggFwD8lFWXUr8IzPDXSdJ8Kfi2wSl2XT90llahRfir35 SyqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=/kdpBqisujruXP32lcD3Lc7Y4/WWzZazhZWdns6RvPc=; b=Yk/ZX40+3xAMufqFyCiS0DFxiSwo9s9ZDyUAJbSFuRKQktVHYiBWgSc1ikGvwOKTwu 6b80ii4qv3lrqEoy3w1O+4r7mI1Z/fXz+guxkp4zaLCW/e8N3GG08U32vF6SdJngQMc3 Yw1iaHNBidzAIO4fBymjTaGHP6XbYcInXTM8i+5ltXU+RJ6r+D1UfkQfQ8sl9zHZONA6 l8DQ2NfmQKG1pCv5VnGxJev0VsPSyzUUjyu3tPxvNLtHM1n3xMygoC916wHkUqzTorKY Rk+F46BYLzA0dJvyCpM/XbLO/w0yvQ6igETFFuuzcSavvSjaC4oDG9CzqixJ1T3IQQAi evDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y8si1659876pfn.26.2019.01.29.04.08.36; Tue, 29 Jan 2019 04:08:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729412AbfA2LjV (ORCPT + 99 others); Tue, 29 Jan 2019 06:39:21 -0500 Received: from foss.arm.com ([217.140.101.70]:34732 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729404AbfA2LjS (ORCPT ); Tue, 29 Jan 2019 06:39:18 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DA353EBD; Tue, 29 Jan 2019 03:39:17 -0800 (PST) Received: from e107981-ln.cambridge.arm.com (e107981-ln.cambridge.arm.com [10.1.197.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 37ABF3F589; Tue, 29 Jan 2019 03:39:15 -0800 (PST) Date: Tue, 29 Jan 2019 11:39:10 +0000 From: Lorenzo Pieralisi To: "Z.q. Hou" , "l.subrahmanya@mobiveil.co.in" Cc: "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bhelgaas@google.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "shawnguo@kernel.org" , Leo Li , "catalin.marinas@arm.com" , "will.deacon@arm.com" , Mingkai Hu , "M.h. Lian" , Xiaowei Bao Subject: Re: [PATCHv3 00/27] PCI: refactor Mobiveil driver and add PCIe Gen4 driver for NXP Layerscape SoCs Message-ID: <20190129113910.GA7467@e107981-ln.cambridge.arm.com> References: <20190129080926.36773-1-Zhiqiang.Hou@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190129080926.36773-1-Zhiqiang.Hou@nxp.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 29, 2019 at 08:08:28AM +0000, Z.q. Hou wrote: > From: Hou Zhiqiang > > This patch set is aim to refactor the Mobiveil driver and add > PCIe support for NXP Layerscape series SoCs integrated Mobiveil's > PCIe Gen4 controller. > > Hou Zhiqiang (27): > PCI: mobiveil: uniform the register accessors > PCI: mobiveil: format the code without function change > PCI: mobiveil: correct the returned error number > PCI: mobiveil: remove flag MSI_FLAG_MULTI_PCI_MSI > PCI: mobiveil: correct PCI base address in MEM/IO outbound windows > PCI: mobiveil: replace the resource list iteration function > PCI: mobiveil: use WIN_NUM_0 explicitly for CFG outbound window > PCI: mobiveil: use the 1st inbound window for MEM inbound transactions > PCI: mobiveil: correct inbound/outbound window setup routines > PCI: mobiveil: fix the INTx process error > PCI: mobiveil: only fix up the Class Code field > PCI: mobiveil: move out the link up waiting from mobiveil_host_init > PCI: mobiveil: move irq chained handler setup out of DT parse > PCI: mobiveil: initialize Primary/Secondary/Subordinate bus number > dt-bindings: pci: mobiveil: change gpio_slave and apb_csr to optional > PCI: mobiveil: refactor Mobiveil PCIe Host Bridge IP driver > PCI: mobiveil: fix the checking of valid device > PCI: mobiveil: continue to initialize the host upon no PCIe link > PCI: mobiveil: disabled IB and OB windows set by bootloader > PCI: mobiveil: add Byte and Half-Word width register accessors > PCI: mobiveil: make mobiveil_host_init can be used to re-init host > dt-bindings: pci: Add NXP Layerscape SoCs PCIe Gen4 controller > PCI: mobiveil: add PCIe Gen4 RC driver for NXP Layerscape SoCs > PCI: mobiveil: ls_pcie_g4: add Workaround for A-011577 > PCI: mobiveil: ls_pcie_g4: add Workaround for A-011451 > arm64: dts: freescale: lx2160a: add pcie DT nodes > arm64: defconfig: Enable CONFIG_PCI_LAYERSCAPE_GEN4 Subrahmanya, Either you review this series or I will have to drop you from the MAINTAINERS list for this driver, I am sorry but I asked you before to no avail. Thanks, Lorenzo > .../bindings/pci/layerscape-pci-gen4.txt | 52 ++ > .../devicetree/bindings/pci/mobiveil-pcie.txt | 2 + > MAINTAINERS | 10 +- > .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 163 ++++ > arch/arm64/configs/defconfig | 1 + > drivers/pci/controller/Kconfig | 11 +- > drivers/pci/controller/Makefile | 2 +- > drivers/pci/controller/mobiveil/Kconfig | 34 + > drivers/pci/controller/mobiveil/Makefile | 5 + > .../controller/mobiveil/pci-layerscape-gen4.c | 306 +++++++ > .../controller/mobiveil/pcie-mobiveil-host.c | 640 +++++++++++++ > .../controller/mobiveil/pcie-mobiveil-plat.c | 54 ++ > .../pci/controller/mobiveil/pcie-mobiveil.c | 246 +++++ > .../pci/controller/mobiveil/pcie-mobiveil.h | 229 +++++ > drivers/pci/controller/pcie-mobiveil.c | 861 ------------------ > 15 files changed, 1743 insertions(+), 873 deletions(-) > create mode 100644 Documentation/devicetree/bindings/pci/layerscape-pci-gen4.txt > create mode 100644 drivers/pci/controller/mobiveil/Kconfig > create mode 100644 drivers/pci/controller/mobiveil/Makefile > create mode 100644 drivers/pci/controller/mobiveil/pci-layerscape-gen4.c > create mode 100644 drivers/pci/controller/mobiveil/pcie-mobiveil-host.c > create mode 100644 drivers/pci/controller/mobiveil/pcie-mobiveil-plat.c > create mode 100644 drivers/pci/controller/mobiveil/pcie-mobiveil.c > create mode 100644 drivers/pci/controller/mobiveil/pcie-mobiveil.h > delete mode 100644 drivers/pci/controller/pcie-mobiveil.c > > -- > 2.17.1 >