Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Reshetova, Elena" <elena.reshetova@intel.com>
To:     Peter Zijlstra <peterz@infradead.org>,
        Andrea Parri <andrea.parri@amarulasolutions.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "keescook@chromium.org" <keescook@chromium.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Dmitry Vyukov <dvyukov@google.com>
Subject: RE: [PATCH] refcount_t: add ACQUIRE ordering on success for
 dec(sub)_and_test variants
Thread-Topic: [PATCH] refcount_t: add ACQUIRE ordering on success for
 dec(sub)_and_test variants
Thread-Index: AQHUtwJjl6FToBsL5EumdKDVAgvWOaXEvaUAgAFE0QCAAD1W8A==
Date:   Tue, 29 Jan 2019 13:39:17 +0000
Message-ID: <2236FBA76BA1254E88B949DDB74E612BA4B98D02@IRSMSX102.ger.corp.intel.com>
References: <1548677377-22177-1-git-send-email-elena.reshetova@intel.com>
 <20190128142910.GA7232@andrea>
 <20190129095144.GH28467@hirez.programming.kicks-ass.net>
In-Reply-To: <20190129095144.GH28467@hirez.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

 
> On Mon, Jan 28, 2019 at 03:29:10PM +0100, Andrea Parri wrote:
> 
> > > diff --git a/arch/x86/include/asm/refcount.h b/arch/x86/include/asm/refcount.h
> > > index dbaed55..ab8f584 100644
> > > --- a/arch/x86/include/asm/refcount.h
> > > +++ b/arch/x86/include/asm/refcount.h
> > > @@ -67,16 +67,29 @@ static __always_inline void refcount_dec(refcount_t *r)
> > >  static __always_inline __must_check
> > >  bool refcount_sub_and_test(unsigned int i, refcount_t *r)
> > >  {
> > > -	return GEN_BINARY_SUFFIXED_RMWcc(LOCK_PREFIX "subl",
> > > +	bool ret = GEN_BINARY_SUFFIXED_RMWcc(LOCK_PREFIX "subl",
> > >
> REFCOUNT_CHECK_LT_ZERO,
> > >  					 r-
> >refs.counter, e, "er", i, "cx");
> > > +
> > > +    if (ret) {
> > > +               smp_acquire__after_ctrl_dep();
> > > +               return true;
> > > +    }
> > > +
> > > +    return false;
> >
> > There appears to be some white-space damage (here and in other places);
> > checkpatch.pl should point these and other style problems out.
> 
> It's worse...
> 
> patch: **** malformed patch at line 81: diff --git
> a/arch/x86/include/asm/refcount.h b/arch/x86/include/asm/refcount.h
> 
> And yes, there's a lot of whitespace damage all around. Lots of trailing
> spaces too.


I am very sorry about this, smth is really wrong with my system, in addition to all
above, I haven't even received Andrea reply to my inbox, neither this patch itself. 

I will fix all the whitespacing/trailing stuff and address this comment from Andrea:

"Mmh, this property (A-cumulativity) isn't really associated to ACQUIREs
in the LKMM; I'd suggest to simply remove the last sentence."

Anything else that needs fixing, content-wise? 

Best Regards,
Elena.