Subject: Re: [PATCH] For test only: pmac_zilog fixes (cups lockup at boot):
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: "debian-powerpc@lists.debian.org" <debian-powerpc@lists.debian.org>,
       Linux Kernel list <linux-kernel@vger.kernel.org>,
       Matthias Urlichs <smurf@smurf.noris.de>,
       =?ISO-8859-1?Q?Martin-=C9ric?= Racine <q-funk@pp.fishpool.fi>
In-Reply-To: <20040305092422.C22156@flint.arm.linux.org.uk>
References: <1078473270.5703.57.camel@gaston>
	 <20040305085838.B22156@flint.arm.linux.org.uk>
	 <1078477504.5700.69.camel@gaston>
	 <20040305092422.C22156@flint.arm.linux.org.uk>
Content-Type: text/plain
Message-Id: <1078478951.5698.82.camel@gaston>
Mime-Version: 1.0
Date: Fri, 05 Mar 2004 20:29:12 +1100
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 714
Lines: 20


> Yes, I know - but the point is its impossible to review, and I think
> you at least have an extra level of locking which isn't needed.
> 
> But I wouldn't know because of the huge number of changes which make
> it impossible to read.

That semaphore locking is only used to guard open/close against the
power management callback. It greatly simplify the deal with the shared
irq (the irq is shared between both ports). It's not used during
normal operations.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/