Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4818014imu; Tue, 29 Jan 2019 08:02:20 -0800 (PST) X-Google-Smtp-Source: ALg8bN70wi2aZK3jv/V8Oez/9jDYywgdfdy95N6g94XE6ECGql8Cxh1KY42ub50buw1GiA/7zNGu X-Received: by 2002:a63:cd4c:: with SMTP id a12mr24576480pgj.252.1548777740631; Tue, 29 Jan 2019 08:02:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548777740; cv=none; d=google.com; s=arc-20160816; b=MyfyGWROzhDndwXtBACdk9QkWWvKqEl0T5fE5JPfUbm7zqW3OOOqDg52nhzgxPapSf 8YLTsKbW1qX1pZAaRCEC6UePz9RUTvPV9idyN/wyBaxnrnKokLGEygJFzH4XbK5UKqsn w+5S4a4r0vp2VxMtUyMawDebOEUfVnl9Ojbqr1f4MAtApCVvowtEkOwYoAb34GSFvuFA UyR9PRF+YC9ofjwpdJfPJmj8C0fxYrNB+0N/MRR6jCLhxsXkofWvIRUuenJDM7cgG7ye FW5eMUv9Bta1BQ0ONcB0r4t6fw+xH3agMWNPsbLtczsyVW6Z24Gnavw3JbTsUAqfcEgU 9u6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=L79AbGo2tCtDTdo/SJugeGQ8jz44FIMnGWETOxJC0W4=; b=05LdtAo09upOFVVRoyNTUxOF3lSVO2Dq8A9HspySGl+ELKJJVT63l+nY2mGXPoJoaF 9VeYr3wiURos287064XiZlk7VkMlwGN3RwltCNTMMRviF9WQufFZRm5F6Hae60VYjivB NwMebwmtZ40XDx0MvwdziExAYuNAJ/kscZU9J3NihqI15AZSMFIzXp333gvkU+oVHpTO bEbygp7kQiz5unbBskzzUFizcK443o77lrlo22+XQ0MQArGURL5BcOnoy5mCUOHE6VoX aoo9BfceMPfaZtQyHLikCIUwTck0UUNuMOGMZncn0uyDz4/xgSfYOpW7lKF8zwOMFkk8 COVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YyxIi8nh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f63si500875pfg.136.2019.01.29.08.02.04; Tue, 29 Jan 2019 08:02:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YyxIi8nh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727499AbfA2QBd (ORCPT + 99 others); Tue, 29 Jan 2019 11:01:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:34216 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725794AbfA2QBd (ORCPT ); Tue, 29 Jan 2019 11:01:33 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 218932087E; Tue, 29 Jan 2019 16:01:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548777692; bh=+TMEg19uHPDseH/5sgT51/L59/zG9LXUogtoRycIMI0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YyxIi8nhoV0MI8wSZPxGP+6CiKcVgYk/cPLk2R90YM4DfDWcJndDiimdp7rDwwpYF bSJw08Ckb9b8oDe+4yS9qB0UAXB+pjUN+Zp6MqNE9nVoDdOlXNnL4V/sdWIiL23r+/ 1KG8/tkmxd2t8gnEIiOgKNogz4SSK+zgNelkmubg= Date: Tue, 29 Jan 2019 17:01:30 +0100 From: Greg Kroah-Hartman To: Vladimir Kondratiev Cc: Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: [PATCH] lib: 64bit IO Message-ID: <20190129160130.GA19439@kroah.com> References: <20190129154102.17655-1-vladimir.kondratiev@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190129154102.17655-1-vladimir.kondratiev@linux.intel.com> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 29, 2019 at 05:41:02PM +0200, Vladimir Kondratiev wrote: > implement missing io{read|write}64 > > For 64-bit platforms, these 64-bit io functions are defined in > include/asm-generic/iomap.h, > but actual implementation missing. Provide it. What is in include/asm-generic/io.h? $ git grep iowrite64be | grep generic include/asm-generic/io.h:#ifndef iowrite64be include/asm-generic/io.h:#define iowrite64be iowrite64be include/asm-generic/io.h:static inline void iowrite64be(u64 value, volatile void __iomem *addr) include/asm-generic/iomap.h:extern void iowrite64be(u64, void __iomem *); so are you sure this is needed? What code is failing to build for you? thanks, greg k-h