Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4894864imu; Tue, 29 Jan 2019 09:15:15 -0800 (PST) X-Google-Smtp-Source: ALg8bN5L/b74OW7+TSgKf9Fp0+5s7r6KyZCRio3tM2BLGrgI8kkOfKdxFBPQuD0yBlKsrfp+FJa7 X-Received: by 2002:a62:4886:: with SMTP id q6mr27731310pfi.182.1548782115000; Tue, 29 Jan 2019 09:15:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548782114; cv=none; d=google.com; s=arc-20160816; b=AVsaUTS/1rGJKgNArjBvOe8aZsXuRVCBk2MqQeJ/l3R9b5/Ua3nHN6eL7f0REtyKSF BNmcsDNifAePpTCLIbDdUR4gqF9glhZtmk3j3bHy0hcWa0auBSE4JEmNnPqtguimpt2b pyAXeCtYuCkTMEgcwcUZrR3bf54wD3Lt+B4bKUWnFuXP59o9GFS5ldJYYGh1P3A+rBft 6GEUQmRdTOnVV4CVjpxTSh8AM5PdYjOOqvryoqhRYg2erRLfK/SBr/UQw633zhBGXmMm Pv0Cce4JMSrqQWYXg2A3cqd3ob6GYuJMlPBBuTkttWY5nYU5ozhm034Zdku/YcCxAnhz nTKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=P7NtdndmXAxz+9pxbO6SddaXCYIu2GHtOByHm4AknhE=; b=v1ayy8CiX0PIGO6PDKiYm2sKEPv8XQWHpLSGMyL5CfhHFu6a88CiqKwzDZBat+cxZQ unXX8HlvFqb3979XZWd05OoL2htz7yBDjcaKniE4yPF0hG2eebsgxXJEJLwD8FjMr7pX XASEPWn4g+z+pZnG4juxs8qSGJsTIaiBogfCkafDayI7eH3N+vtpIwJAvH3mcUgnT94F 4WwQ8wYceBOWO0RNbYZq5cZ26EB9q+wiCYYyqBV0HZdUBUXkO5PCEbe1OzPRngXARa5d y/aSolJ8PiL6Ac11a1GWs1+Y3sVXhcDvgR909SNfPbhzU+2zfKCwW+9ABPX5S5sgyqNP Jt3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y1si21521062plt.356.2019.01.29.09.14.48; Tue, 29 Jan 2019 09:15:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729075AbfA2RNz (ORCPT + 99 others); Tue, 29 Jan 2019 12:13:55 -0500 Received: from verein.lst.de ([213.95.11.211]:47392 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725794AbfA2RNy (ORCPT ); Tue, 29 Jan 2019 12:13:54 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id E2B0C68D93; Tue, 29 Jan 2019 18:13:52 +0100 (CET) Date: Tue, 29 Jan 2019 18:13:52 +0100 From: Christoph Hellwig To: Joerg Roedel Cc: "Michael S . Tsirkin" , Jason Wang , Konrad Rzeszutek Wilk , Christoph Hellwig , Jens Axboe , virtualization@lists.linux-foundation.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, jfehlig@suse.com, jon.grimm@amd.com, brijesh.singh@amd.com, jroedel@suse.de Subject: Re: [PATCH 5/5] virtio-blk: Consider virtio_max_dma_size() for maximum segment size Message-ID: <20190129171352.GE15195@lst.de> References: <20190129084342.26030-1-joro@8bytes.org> <20190129084342.26030-6-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190129084342.26030-6-joro@8bytes.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 29, 2019 at 09:43:42AM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > Segments can't be larger than the maximum DMA mapping size > supported on the platform. Take that into account when > setting the maximum segment size for a block device. > > Reviewed-by: Konrad Rzeszutek Wilk > Signed-off-by: Joerg Roedel Looks good: Reviewed-by: Christoph Hellwig