Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4900349imu; Tue, 29 Jan 2019 09:20:15 -0800 (PST) X-Google-Smtp-Source: ALg8bN6JZR1CjfbV0E894mNW5Rq/jH7adhMbVeBX6sjHYgj+IEiocda8hf1YL/9YrdJFhH9wkULU X-Received: by 2002:a62:83ce:: with SMTP id h197mr26813990pfe.187.1548782415539; Tue, 29 Jan 2019 09:20:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548782415; cv=none; d=google.com; s=arc-20160816; b=sWY1DSnWPALHx7vAWcdLQLsqzXjEKbyTtU/mihPvRBdfKmcP8TWSxrPJLXXbpRCkQL CYN0knMvxvYJIo1rU8J4V7+WiuVjWIMt1FUbNzD4YA0IVqabm/Xap2DpfOH84elp/FuK bYGGj7chh4XzekOZnXkRem610oqKx+q5tvnXt3Ay534qyWKl5cbpGMxg98VSflO8PdBW tE8BlQyut4byl3P2yieDl84065iXIbubMNDaZeggdXqxVknQ0mUWEcjztKdNwe5gfmG+ TEQi8fCpu2+9nMhERxPuaAdSq3dx0Smhg0Dq6BejR8tnQJFIc9eC/kC49kkwVChiK+sa Juzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=aHcUSrfNQOiE45arHspE14mKaGaiYpAOhDSpRRREifg=; b=WWJ+mmLdim8tRPWeeFE6sEoyWeKWt3xWICkSraPbJmEH8qWbyUP3VyVyhSM1ebEg45 WtJioDklaroeU7n+KfshSerX4HODnzOXIWzyfQMcDl23VtFwCZpncSrh8buslWgllni+ ImIFBcDLIgCDN0BIODDkL6U9r+iiADHJZ36G3BGQmXrGrTe43kanMGHWgRYSEBHiPrac e17RRVOdtce6D+hZqh8hUri2rfNdrPcsWqW8Vj+saBABzmuNs10o9FahloQj0M8B2+zu 3nvAxhTu1hOtjkLlj8wyma+fACThxHpvqUQoCFSKWIOop3wJRAH6R54q7tq1FzUWpooD jBig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zl49vcoq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a11si37840927pln.78.2019.01.29.09.19.54; Tue, 29 Jan 2019 09:20:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zl49vcoq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728704AbfA2RSt (ORCPT + 99 others); Tue, 29 Jan 2019 12:18:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:35242 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727100AbfA2RSs (ORCPT ); Tue, 29 Jan 2019 12:18:48 -0500 Received: from earth.universe (dyndsl-091-248-209-252.ewe-ip-backbone.de [91.248.209.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AACE72087E; Tue, 29 Jan 2019 17:18:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548782327; bh=aHcUSrfNQOiE45arHspE14mKaGaiYpAOhDSpRRREifg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zl49vcoq27xt712Ww+Il5anGsgEtFqy1+6hvWMACwlCuAaijh/sLElIY4Et5riSGR e4NqfZ8L1UYhUcI9mD5Vs6UGE9caKqQn0mxoCAOoFolrafZhBoj52wUizqPjtuHKLO mWMmyBo3XC4oan9+mVILGeNys2mZ93sxPgFfJPuA= Received: by earth.universe (Postfix, from userid 1000) id ECCEA3C08DE; Tue, 29 Jan 2019 18:18:44 +0100 (CET) Date: Tue, 29 Jan 2019 18:18:44 +0100 From: Sebastian Reichel To: Tony Lindgren Cc: Douglas Anderson , Mark Brown , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Subject: Re: New underflow of regulator enable count warnings in v5.0-rc1 Message-ID: <20190129171844.n6wflw4ehfdy3izs@earth.universe> References: <20190129164813.GA5720@atomide.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nxdsms3oudxktwtr" Content-Disposition: inline In-Reply-To: <20190129164813.GA5720@atomide.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nxdsms3oudxktwtr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Jan 29, 2019 at 08:48:13AM -0800, Tony Lindgren wrote: > Looks like commit 5451781dadf8 ("regulator: core: Only count load for > enabled consumers") started showing new warnings with v5.0-rc cycle: >=20 > regulator-dummy: Underflow of regulator enable count >=20 > I'm seeing this at least with my pwm-vibra test case: >=20 > # rumble-test /dev/input/by-path/platform-vibrator-event 0xffff > pwm-vibrator vibrator: vibrator supply vcc not found, using dummy regulat= or > input: pwm-vibrator as /devices/platform/vibrator/input/input4 > regulator-dummy: Underflow of regulator enable count > Upload rumble effect... id=3D0 > regulator-dummy: Underflow of regulator enable count >=20 > Are these bogus warnings for dummy regulator or do we have > real unpaired regulator calls or somewhere? There are real unpaired regulator calls in the pwm-vibrator driver, that I did not notice when I wrote the driver :(. Good news is, that Pawe=C5=82 Chmiel and Jonathan Bakker are already working on fixing my mess: https://lore.kernel.org/patchwork/patch/1032759/ On Droid 4 it's a dummy regulator, since I did not know what regulator is being used to supply the vibrator. Probably directly =66rom the battery. -- Sebastian --nxdsms3oudxktwtr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAlxQivIACgkQ2O7X88g7 +prOCw/+OTUVuiiDL1E9MnpFholjz2hyATTT2hLR5GIbulVgaypDSmK9lj/D+3Lh m6XSToHBxskFyx4ZEbxmijxtF15l7wIzBzhDUzoFjzkAiAiSFoRVzfxG638lGULs 2X+ZOVpKv2fURtknjO2OUA7XavVl/XQLY5Ry3gCHYQm3W0V8gC/6fEtNBOvE4/nw SJ3Y3cIzZ7OktP5sVp7bfXuPuHmc5XqnBR4GUMtjkds4fdRonyPW8rEPQkMxkIT6 kAGxT2v8bElbCb4DWz4CD+eYbX286ino5gjcOIOeJd0lVjaDZzT3vKy+Q9oTyhhr OY2KRiuYxTJbz8qCAgK+DCnAIy/ev1t6wJRdH5SGfqHk6/Sp5WWi7fOLkzCclolp qWOD0fG7fKVD5/PCwi7HjHuCa5A6QSJkB3eBu4YIayQF2x5miBDlIpmu3pISWaxc 3LX5pUDxrUW3qbM33uVTMPO++tm3ZxauYTkJSZTMnogYOeNtthh/9AkuTkJpPBhn Rnve1dkHLNZrKA/3JtJWj6JVVP6Sy3j/2NXkeX2xnreYYYqcN19OQMchD19ogPVn 3rdvfuoOMDpB4RjoN87D7bIgbsBVWJJIvLtvtvdy09u0qn6ztgpq0SX7f4Z01tg2 rEjKoeBi54HCEr38Ti6uxAPh3rl83BmgWJ4qDVnd0tMhBUOCNiQ= =l1E0 -----END PGP SIGNATURE----- --nxdsms3oudxktwtr--