Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4923185imu; Tue, 29 Jan 2019 09:43:34 -0800 (PST) X-Google-Smtp-Source: ALg8bN7dHIn/X2wa7gvm/nA48BTB/M1PPZ7DwByirJ5prttVof2R05JfdBuuCtRYbtOoqB2JJaIi X-Received: by 2002:a17:902:31a4:: with SMTP id x33mr26396104plb.41.1548783814293; Tue, 29 Jan 2019 09:43:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548783814; cv=none; d=google.com; s=arc-20160816; b=iqvZog2BJDbGdJhroNWX9IpGz0OKYS7oj/vsWmNu4UbqVD6QTDJzETwTAM2Spfzd6J Yk954EqsmH4x7/Yu//fOLMOXQZ2Aad/rYeHcK/aDGi8gTzZABXgO+9N7TIAN6oB/IdXk VxZuBz3KP0KlaaZ1BcexAAN11W2DsX65zlbSQFvTiuDtA6ESQo8ygLZ0lob1Ill6MC+w 2upTHx2jH1hNsphKo5965PEgHs1R6aWgBio9VDLjcORcy7WfJLCJ6nymBxUpKLj26RIi Zjq50rf/QLG9tQj/ERw/jC7SHPGytfQ72uioZxDIntnIJbaZCgsuTAgP0CXD92O5fbrm 48cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=obliAzNSGHsByMr25c9abbGU3HKrNFFFcCfLLDnQMyc=; b=yb0ThFjM4FcrAkXU+Wu1FVWRCAi3j89ChALjM2p8l5c8w9UMDg383WRRNuSoxWvvAO NPcpQv6cqiFhIAu8xDkyAWbB3UR9iGyy3Wfnu39eTgjjwIRGWydj50HJmbY+l5kpu1Y2 dtoQvDf1FtVg+66o7xCxnILgm8Aw1JESkjrVaupouEK7TOveGX5cb4csfzS59PUq4KEv B3Qj30r3OOxXVM3PV/+W+JEvQ84rYeLUnze2+qATCl0B+1ZsgKtZajPuEV5gb5zJDQu3 IY2lKYhckbeGPBR1WyEmGIhBQGKYykMr7jCY0ZtXFFsGO5vX3vRixc5ZKb//2gOBiKyU BDNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b10si35510043plz.233.2019.01.29.09.43.17; Tue, 29 Jan 2019 09:43:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729181AbfA2RlZ (ORCPT + 99 others); Tue, 29 Jan 2019 12:41:25 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:33126 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726852AbfA2RlY (ORCPT ); Tue, 29 Jan 2019 12:41:24 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1DAC414F14B77; Tue, 29 Jan 2019 09:41:24 -0800 (PST) Date: Tue, 29 Jan 2019 09:41:23 -0800 (PST) Message-Id: <20190129.094123.395728867400146205.davem@davemloft.net> To: harini.katakam@xilinx.com Cc: nicolas.ferre@microchip.com, claudiu.beznea@microchip.com, brandon.streiff@ni.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michal.simek@xilinx.com, harinikatakamlinux@gmail.com Subject: Re: [PATCH v2] net: macb: Apply RXUBR workaround only to versions with errata From: David Miller In-Reply-To: <1548755403-361-1-git-send-email-harini.katakam@xilinx.com> References: <1548755403-361-1-git-send-email-harini.katakam@xilinx.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 Jan 2019 09:41:24 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Harini Katakam Date: Tue, 29 Jan 2019 15:20:03 +0530 > The interrupt handler contains a workaround for RX hang applicable > to Zynq and AT91RM9200 only. Subsequent versions do not need this > workaround. This workaround unnecessarily resets RX whenever RX used > bit read is observed, which can be often under heavy traffic. There > is no other action performed on RX UBR interrupt. Hence introduce a > CAPS mask; enable this interrupt and workaround only on affected > versions. > > Signed-off-by: Harini Katakam Applied, thank you.