Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4936447imu; Tue, 29 Jan 2019 09:58:38 -0800 (PST) X-Google-Smtp-Source: ALg8bN7yUgpHIHE7FKNxwRrYo5pfXAu8rtucR4lbTKbyHiZbUovctANYSuzbcGFBlIivbmaoZjtC X-Received: by 2002:a62:1b50:: with SMTP id b77mr27290828pfb.36.1548784718132; Tue, 29 Jan 2019 09:58:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548784718; cv=none; d=google.com; s=arc-20160816; b=D4Hpk/i33AvbU0XnAHoBky3J0/eGIgyM+EuzGIaLcpPBPbWXMQVO+VPlI8UJzaVoT0 EnQNuQSBJT1fQNMdBl6vlLpfC3HIh4MGu+QF2hKfugblhpcUGv7jL44i2JRJJ5vAPGbX PCMzEsSqTSCydxGdWBrdSnz/EvYKIY8bUjVnASuAdbdGFQksGjA9aowGZdaJqvqbB/yY Dw/mhYsxuAZyc4YWzvMNI6KAuYtkt2PgAQZbT0hWTBw2be6BLJboaQsgPjljRl+uYtG6 YfwMckRdp3S1Ni51mTaOsGvrDlfLtCLz3bzdVgmcymbIjmrFE/CiDyDXw7BQZxnXcvxh XKtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=TK5Q823N9cdnhH5uLAjCRM7lh8nNdY6bySdVO5kXkJY=; b=0S3klgLylqFXCUppEfYkzMd8zQzefEW58zNaSsIC4wIbHzcTI2Q51t+wodZM72Mw2z odVBrSE0/JXx7DLohTKPrXx0UXLu/WPV0osVmxYfByXXQ2wuwk6uezcMbfT981x61GHh DowzMl2f+rytYvXfJw4U3FRH4wuPyZsEXHyy5+bCwYpcwELD2hBSCRFMPZusNFhNCJPf ARFHOKiiJ+glWhsdTYQNn7Z9VpXnNL44pAVT7T+feYTItZcH/MO/dw+U3rH1CdR4Baz8 EtiAs1P6N8iBVQH6d7iSYhROpTJcEdyJ0wZV/qCYV9tGxX3Jg1K09sw1bFUp+emYfaj6 5nGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=nvXS2ieJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s4si35792715pga.377.2019.01.29.09.58.22; Tue, 29 Jan 2019 09:58:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=nvXS2ieJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728719AbfA2R5F (ORCPT + 99 others); Tue, 29 Jan 2019 12:57:05 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:37086 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727198AbfA2R5F (ORCPT ); Tue, 29 Jan 2019 12:57:05 -0500 Received: by mail-qt1-f193.google.com with SMTP id t33so23228626qtt.4 for ; Tue, 29 Jan 2019 09:57:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TK5Q823N9cdnhH5uLAjCRM7lh8nNdY6bySdVO5kXkJY=; b=nvXS2ieJhUJo1q93q2C4dgblvLoIVTtzfhlOML7Pv2s4Ya/MPzD98iRLtvagakVjpD nd6cj/MZlvF76e7FLdkqTWb5Gjp15kFb3VbD2uRSLlaBrl8n8DR/qFLsTElhlFCSN1wk i0HqCIrtZO6lDTT8g2TSn8Z0xXgfpWw0Jqqph7fuyG/YY5htb9vlO/R8DGmYQk47Ss27 NpJxvdeU8c1U94NfqBn8rH9dOBykC0ANE/oBMbxyXLO8KGJ8ai+fEXoxlekaCJ6TbtUz BOhI4f35Wr1PtThunHWZCd0y7v8SxkUzUmz5eKp+PSljI7euZwcr0HvXqH9K4EyJttnV OpYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TK5Q823N9cdnhH5uLAjCRM7lh8nNdY6bySdVO5kXkJY=; b=rW2M9O4q9wXs1fAYuht7uA70WLx0x+HJ1RjiOFkv4z1H+rWHQA+n+8rQ4LI94BX3/q rDqhxg0I3hCnYbmL8v3unfoQZWy5QdigePMA1bBypUQvG/p9YDyHSw69gaCh6py12gsu UQG7AuFrHSqeLqrJbopylkhdkBSDgXRX1DnKbfH9GNkxfYSUv/VRZ7o/AmqJdjb32MmH d1u2shi4ULR3F3BG0jmUfG+gfax04EMoHQn4U2SyKfJUOxE8/sf6Ej292pyn+NzFbTO9 /naRcPb2fluOfKHsvaFEes0jp6C+lLBh/wsUEKBwRITCdLag+kz+21+zqHCYlwuixz+3 H+6g== X-Gm-Message-State: AJcUukfyQcYMiuAAfw4eiz5NamaMYiwJUS22spW3tvORonQh+tM4hvQ4 LF5rc4oOIq6bGsv5qviPiAELcg== X-Received: by 2002:a0c:df12:: with SMTP id g18mr24827625qvl.208.1548784624452; Tue, 29 Jan 2019 09:57:04 -0800 (PST) Received: from localhost ([107.15.81.208]) by smtp.gmail.com with ESMTPSA id g19sm44610190qke.2.2019.01.29.09.57.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 09:57:03 -0800 (PST) Date: Tue, 29 Jan 2019 12:57:02 -0500 From: Josef Bacik To: Dennis Zhou Cc: David Sterba , Josef Bacik , Chris Mason , Omar Sandoval , Nick Terrell , kernel-team@fb.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/11] btrfs: add macros for compression type and level Message-ID: <20190129175701.auj22biuwwrwtufd@MacBook-Pro-91.local> References: <20190128212437.11597-1-dennis@kernel.org> <20190128212437.11597-2-dennis@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190128212437.11597-2-dennis@kernel.org> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 28, 2019 at 04:24:27PM -0500, Dennis Zhou wrote: > It is very easy to miss places that rely on a certain bitshifting for > decyphering the type_level overloading. Make macros handle this instead. > > Signed-off-by: Dennis Zhou Reviewed-by: Josef Bacik Thanks, Josef