Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 29 Jan 2019 18:05:47 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Charles Keepax <ckeepax@opensource.cirrus.com>
Cc:     Axel Lin <axel.lin@ingics.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: lochnagar: Fix n_voltages setting for VDDCORE
Message-ID: <20190129180547.GI10524@sirena.org.uk>
References: <20190129030156.2024-1-axel.lin@ingics.com>
 <20190129095438.GJ3837@imbe.wolfsonmicro.main>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="svExV93C05KqedWb"
Content-Disposition: inline
In-Reply-To: <20190129095438.GJ3837@imbe.wolfsonmicro.main>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--svExV93C05KqedWb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jan 29, 2019 at 09:54:38AM +0000, Charles Keepax wrote:

> Hmm... I think this might need a little more investigation, it
> does indeed fail at present (amazing that it works upto exactly 1.2V
> which is common the usecase) but this feels more like a core
> problem. There are indeed only 57 valid voltage settings as the
> range is 0x8 - 0x41, but it seems that presently the core treats
> this less as n_voltages and more like max_selector. Should we
> perhaps be teaching the core to understand the min_selector
> instead?

We've not had a need for this before but that seems like a reasonable
addition.

--svExV93C05KqedWb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlxQlfoACgkQJNaLcl1U
h9CWCwf/ZxzfLoEjq12l4scqJJJmpfhVqlHEDdjHea26783vz7S0ktdWmF0FMQ+x
tRo+YaqxCs4jk/lufyvubY3jPaurP7388NSTZg7bpcZGO9MncO9UcGYq2FgjSlkS
VkKSl4qFZ9rtZbSX+Mqav7+QPpTJak+6wLbN3x0MRgMmoemOfJOZl2PjBtmqpXF9
ikRcZaBKu2u+6P2RfTE83VUrNjgLW5BbYhWnzypmu09rNLIfbnwu22mV1jp1n1oW
FfVFyCtp/pJHsOVOvNJymhi7fIbVSk2gxVo76Y8oJO+N8EG26urGLgEpZiHeWJ4Q
LU9tlH8DlbkVpi7Dii7duNa5ocjLbw==
=SbyI
-----END PGP SIGNATURE-----

--svExV93C05KqedWb--