Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 29 Jan 2019 11:30:51 -0800 (PST)
Message-Id: <20190129.113051.1765896152662794323.davem@davemloft.net>
To:     jelsasser@appneta.com
Cc:     josh@elsasser.ca, ecree@solarflare.com, ktkhai@virtuozzo.com,
        jiri@mellanox.com, petrm@mellanox.com, edumazet@google.com,
        amritha.nambiar@intel.com, alexander.h.duyck@intel.com,
        lirongqing@baidu.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: set default network namespace in
 init_dummy_netdev()
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190126223835.14613-1-jelsasser@appneta.com>
References: <20190126223835.14613-1-jelsasser@appneta.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Josh Elsasser <jelsasser@appneta.com>
Date: Sat, 26 Jan 2019 14:38:33 -0800

> Assign a default net namespace to netdevs created by init_dummy_netdev().
> Fixes a NULL pointer dereference caused by busy-polling a socket bound to
> an iwlwifi wireless device, which bumps the per-net BUSYPOLLRXPACKETS stat
> if napi_poll() received packets:
> 
>   BUG: unable to handle kernel NULL pointer dereference at 0000000000000190
>   IP: napi_busy_loop+0xd6/0x200
>   Call Trace:
>     sock_poll+0x5e/0x80
>     do_sys_poll+0x324/0x5a0
>     SyS_poll+0x6c/0xf0
>     do_syscall_64+0x6b/0x1f0
>     entry_SYSCALL_64_after_hwframe+0x3d/0xa2
> 
> Fixes: 7db6b048da3b ("net: Commonize busy polling code to focus on napi_id instead of socket")
> Signed-off-by: Josh Elsasser <jelsasser@appneta.com>

Applied and queued up for -stable.