Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5065654imu; Tue, 29 Jan 2019 12:10:17 -0800 (PST) X-Google-Smtp-Source: ALg8bN682hZ9t1vOiOfGsg1VjvOHxMKBjq/kISCw6ZnBMhc5VGbC5hsf3hk+ofdMbLpuYkJtEnjC X-Received: by 2002:a62:931a:: with SMTP id b26mr28848706pfe.65.1548792617273; Tue, 29 Jan 2019 12:10:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548792617; cv=none; d=google.com; s=arc-20160816; b=vgAqrwugxS4XJoh9VKkD5gYlsKz+REuRkRgVmFvLrxCvrvRfwbM1lvT6zYlfFvw87a 9JjUyyC3dmp7sMqoOiZFePosCssxHx4FlMPzjCNiWtJ8/f2kGE3mIDN8V65dS/83jgxw /d0oPq5klryswqH+HukZDN+zqOYxEZugAig5DAkLBan72V0+XwT1OS6xRO/rRD9EYB1y Q7c+e7CfinJLyNfBb6SVc6z0gt+0wkvRnWY590kaIkkZsUqNknj/c2cRxC0Ml8I3O20h +EB99g0xzFbuy1M+/BR3GNL0WcFdpEbmYXFUACgMZClftguLwfmX0iwFuGAosFm7URyP CBlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-id:user-agent:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:cc:to :from:dkim-signature; bh=yJQtleUq3yiL3hu/ArSCi9Yh5NdG+6QL9LtU8WnN+Vs=; b=Ya+EJ9zxSLIgHsgxwuk/nxP+LNQPrEbL5G60W0gZ8ZdBR926Zw4PPrZsb+05Xf7IdV yOjQlaOiojhCTKm/uTi5xo9keGYYmjfMhzaPZPj2JYsD0Q9NXVpuLH4ZAtZmq2eaL9s5 w1odq60TUWzw73W46n1w5FBP5Rv1D6B8FhwwimELm0EV6ovqeVoqjUY1OLlEXxz9H/Bv kebXn1ikfEoXyP8eLDXFplyQ5EF5ZwU9nJr3HSnYCPbqGCskNukraXEn4OVM0ORUtrAJ NxtfD8bu3Yg9QDehPEmloJckN8HzI6gNs3OH2HRSmS5Hlghv311bkR6QlQf+23nG6bZE LRYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@wavesemi.onmicrosoft.com header.s=selector1-wavecomp-com header.b=DggUPO1n; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u20si16762529plj.129.2019.01.29.12.10.01; Tue, 29 Jan 2019 12:10:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@wavesemi.onmicrosoft.com header.s=selector1-wavecomp-com header.b=DggUPO1n; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729329AbfA2UJr (ORCPT + 99 others); Tue, 29 Jan 2019 15:09:47 -0500 Received: from mail-eopbgr750129.outbound.protection.outlook.com ([40.107.75.129]:60096 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727229AbfA2UJq (ORCPT ); Tue, 29 Jan 2019 15:09:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wavesemi.onmicrosoft.com; s=selector1-wavecomp-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yJQtleUq3yiL3hu/ArSCi9Yh5NdG+6QL9LtU8WnN+Vs=; b=DggUPO1n35n+kOigQ7fmR8/tIpeGLhuOVYQRnQDod9BgXfnNV6f8GUvecgmDA6hOS/x3MBpCPT8aahc7m6IEwvh0OmdGwtnlYO+O/7PqhF2mGbJWVL+QB6EFKMTVLVPAPIDWf4EpNkiy1ECeVgdPih8zvj2JfEbKJQJti7O/P9k= Received: from MWHPR2201MB1277.namprd22.prod.outlook.com (10.174.162.17) by MWHPR2201MB1582.namprd22.prod.outlook.com (10.174.167.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1558.19; Tue, 29 Jan 2019 20:09:07 +0000 Received: from MWHPR2201MB1277.namprd22.prod.outlook.com ([fe80::7d5e:f3b0:4a5:4636]) by MWHPR2201MB1277.namprd22.prod.outlook.com ([fe80::7d5e:f3b0:4a5:4636%9]) with mapi id 15.20.1558.023; Tue, 29 Jan 2019 20:09:07 +0000 From: Paul Burton To: Nishad Kamdar CC: Greg Kroah-Hartman , NeilBrown , Ralf Baechle , James Hogan , Joe Perches , Matthias Brugger , Sergio Paracuellos , Kees Cook , "devel@driverdev.osuosl.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , "linux-mips@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] MIPS: Select PINCTRL_RT2880 when RALINK is enabled Thread-Topic: [PATCH] MIPS: Select PINCTRL_RT2880 when RALINK is enabled Thread-Index: AQHUt+bkNR8KLJ2FGECDdb70JPYxtKXGrSqA Date: Tue, 29 Jan 2019 20:09:07 +0000 Message-ID: <20190129200905.vnb3amouxq6o57fn@pburton-laptop> References: <20190129152522.GA24872@nishad> In-Reply-To: <20190129152522.GA24872@nishad> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR02CA0063.namprd02.prod.outlook.com (2603:10b6:a03:54::40) To MWHPR2201MB1277.namprd22.prod.outlook.com (2603:10b6:301:24::17) user-agent: NeoMutt/20180716 authentication-results: spf=none (sender IP is ) smtp.mailfrom=pburton@wavecomp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [67.207.99.198] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR2201MB1582;6:UtDWYpe7x0b5z9L9mQ4b7J8jeTg8MmooBEYA5wL3Wp3Mq52PbkGfRbCWWcPcOsmVek/vDwjV0jkY/gcZaxsaVXEfl5XYVHLEX8NOH1eEE+h+5s0Xek7jC7540kkEZoUmw7WUrygfqFOcvj913/Wvfd4ZDArSEGqNbr26aJTvKa4XgBt+8v6x3bScFGQ1V7e2oZjqHYg/7rdnZP927cQd+x8cJ4ryqR7vvWy8RbMAaKHdT7pjmMVw66zbanLbigu62g+tZ6MEkFRCXplnvWf6JQ2oYzOBLsY9pXJ1cEL4V0jteeuUI/tMtYk+lHjIOrOhAu4swe7clxVNOY0XkdAwndV+WBzA8P5eW29Z6cE7zjxSuEfGJPW4ob7l67KVVR0TF1GpnKyNZSHCqyDbGoce5pHMxtlM0vUyxgyTt7e8PvJzRyhQocjIKRezcXzr4T7hCEm0dQxF2MVrQXmSVwc8xA==;5:I0WhWJ8OZbK4uxnRWqgJm1nlQvOKxqSWaDON1383RV/ZLwJqaX6DXtSOw+o1gcGgMtR0FrCVJoDxpK2fvYZTOVBS5mYwV4jiLyuF+V1i0zR1wPc8pUv+8ZoKQqZghH9B66JTinikfZSSTnLT3VJ58bphO5nVG1wQ8Wm/nxQRh/be/hhwA80SWxQ53RCNc2NnWrL9YLU7zV7chkgdAN8tDw==;7:xsfrMjiHJn1m+1w9SrLDj1IB1qCBdFLUMWchYIJzpEmwXEmeqjEUyGEtqDcoUszdTNCgVG5kedO5ksIlfPnQHN/cNkqwxtvW3AwhS2ietMB0A87CuH56ea/jWZhirliiPR4Hf8GSUipwS06ijzWlRQ== x-ms-office365-filtering-correlation-id: fbd46eba-dc03-459d-7de8-08d686259f7d x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(2017052603328)(7153060)(7193020);SRVR:MWHPR2201MB1582; x-ms-traffictypediagnostic: MWHPR2201MB1582: x-microsoft-antispam-prvs: x-forefront-prvs: 093290AD39 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(7916004)(396003)(346002)(39850400004)(366004)(376002)(136003)(189003)(199004)(386003)(6506007)(2906002)(102836004)(4744005)(97736004)(105586002)(8936002)(6116002)(3846002)(33716001)(7416002)(256004)(476003)(1411001)(446003)(26005)(25786009)(1076003)(305945005)(11346002)(8676002)(81166006)(186003)(66066001)(106356001)(81156014)(42882007)(6916009)(52116002)(9686003)(6512007)(486006)(6246003)(14454004)(99286004)(6436002)(4326008)(58126008)(53936002)(478600001)(76176011)(33896004)(39060400002)(44832011)(7736002)(71190400001)(71200400001)(68736007)(316002)(6486002)(54906003)(229853002);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR2201MB1582;H:MWHPR2201MB1277.namprd22.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: wavecomp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: +eRIWNlwAM61e8BwR4iQFudLnssU1OOz+mGTJckCuSXZhBuNCI3fm7Y45ttIrKas1NWPnp8Gf8t0hqN7SCgszDU3sgFAAvx+UqY9lwjg+bUMv8/2cD0xGhqkG5Ul3tl0xF7nk+fPLFd5O8FWqZ4RdLx5XHpW7goxUjY9LFxa8R2zOJCFY/tCWzDKB57gdtLa4t+skaNgaGXtX7JfMt3lvdiJro+C2Rlv+KtJE2uv/afuv8ypm2bvhAFGPUKnjgUXiD6rZxjbX0s0nNOY2lAtKN+pO3sq6T5DK7L3o4kU4lyxaRQmWtcTpftl+/3espeT30i2Opj3L2IGHY8s6UKXeDabWaHzkiuxyEZPZUjRXtcBaMeiva7Zztr4nfa+4WTaJDxvdRnQqD0OYsYhEG5iZV8LlZ1j0LkXAct0lsFfAOA= Content-Type: text/plain; charset="us-ascii" Content-ID: <335B6EC3D6EAD047885765D40FEEF4B3@namprd22.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: mips.com X-MS-Exchange-CrossTenant-Network-Message-Id: fbd46eba-dc03-459d-7de8-08d686259f7d X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2019 20:09:06.6592 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 463607d3-1db3-40a0-8a29-970c56230104 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR2201MB1582 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nishad, On Tue, Jan 29, 2019 at 08:55:27PM +0530, Nishad Kamdar wrote: > This patch selects config PINCTRL_RT2880 when config RALINK is > enabled as per drivers/staging/mt7621-pinctrl/TODO list. PINCTRL > is also selected when RALINK is enabled to avoid config dependency > warnings. >=20 > Signed-off-by: Nishad Kamdar > --- > arch/mips/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index e2fc88da0223..cea529cf6284 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -623,6 +623,8 @@ config RALINK > select CLKDEV_LOOKUP > select ARCH_HAS_RESET_CONTROLLER > select RESET_CONTROLLER > + select PINCTRL > + select PINCTRL_RT2880 > =20 > config SGI_IP22 > bool "SGI IP22 (Indy/Indigo2)" Wouldn't this also require selecting STAGING? Perhaps that's why it wasn't done in the first place? Thanks, Paul