Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5076125imu; Tue, 29 Jan 2019 12:20:54 -0800 (PST) X-Google-Smtp-Source: ALg8bN7RbPkJCLJBX7Q4mSHtjjGMM4Lg/sAnAksshsxpv+Jd8vKRjH3YggSAAI9kcC37iXeFuD3G X-Received: by 2002:a62:7f93:: with SMTP id a141mr27835584pfd.96.1548793254116; Tue, 29 Jan 2019 12:20:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548793254; cv=none; d=google.com; s=arc-20160816; b=vEzFfkwoxOIZVygozvNtTYt/MIDMFTCitQaPxysesYhZaOcKBlT5Ae14rGXYxUCKq9 60Dwt2tICNAXyYdVRVcZsNXl7KwoFP9e6GPRZ2cvXcd9VKzCuOUT8lV2f8NRdpguupOz 7imclQABsbrOxuwFi6uWxF9eJfRxiSkLfKFgeAMmPJoTBHeqDFNe7BHmaTLm/yenu5eJ oIgv8Lz3l2OB0ZSqQ6CA49VdMK6sfDqKde8dnqIYx5ft2clerR0oN72Sq1SEZrI0SQOQ CfFaFDxPcfm5W3x1/iBYJnmvG5U0ggH1snLGmWejm/uOMYyov30w7Yye324TtkLuj9uG sHSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date; bh=9DSSwc3iTzQ+ZKAGhU8PGVZHMPY6xvnNmQ1MVu4YL/0=; b=nv3JtYjZ9TVBHnrNSH5O3iGT2fkI7P+BezvJVu4nmZYY/l17Jf7mw9kKGwtzim2ERH UhxAieS2nnC+Ys1iTLL1aV3YTX6e5nXZHxJyxK2dN8IfxbqWsrWFZwaGjyvx575khAp5 glT1P/7onCRQ91YtDW0fKEHrKijJ9A0zwHg9zxfe+cvWzFltGdGxx6eumJOE9GLs6o8Q 7n77wD3Jk2QoCk1pqe6kVTZ887J7/dy8FpJbO0rK4i3PPckO1VpaNUSyny93lcyEREiM GHnjOXseqU2lsoLpWt+3RuchYV7RbnSRnVGJRDzSz+YfMPHK5Lo/bLkl47vO6j22M/lX AfbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z6si36604068pgl.109.2019.01.29.12.20.38; Tue, 29 Jan 2019 12:20:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729462AbfA2UUM (ORCPT + 99 others); Tue, 29 Jan 2019 15:20:12 -0500 Received: from gateway30.websitewelcome.com ([192.185.179.30]:12470 "EHLO gateway30.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727308AbfA2UUM (ORCPT ); Tue, 29 Jan 2019 15:20:12 -0500 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway30.websitewelcome.com (Postfix) with ESMTP id C03E57DF1 for ; Tue, 29 Jan 2019 14:20:10 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id oZregTSx6dnCeoZregVJzb; Tue, 29 Jan 2019 14:20:10 -0600 X-Authority-Reason: nr=8 Received: from [189.250.130.205] (port=48556 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1goZrd-001B58-TT; Tue, 29 Jan 2019 14:20:10 -0600 Date: Tue, 29 Jan 2019 14:20:06 -0600 From: "Gustavo A. R. Silva" To: David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] drm/savage: mark expected switch fall-throughs Message-ID: <20190129202005.GA25789@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.130.205 X-Source-L: No X-Exim-ID: 1goZrd-001B58-TT X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.130.205]:48556 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 8 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/gpu/drm/savage/savage_state.c:301:8: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/gpu/drm/savage/savage_state.c:438:8: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/gpu/drm/savage/savage_state.c:559:8: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/gpu/drm/savage/savage_state.c:697:8: warning: this statement may fall through [-Wimplicit-fallthrough=] Warning level 3 was used: -Wimplicit-fallthrough=3 This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/savage/savage_state.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/savage/savage_state.c b/drivers/gpu/drm/savage/savage_state.c index 7559a820bd43..ebb8b7d32b33 100644 --- a/drivers/gpu/drm/savage/savage_state.c +++ b/drivers/gpu/drm/savage/savage_state.c @@ -299,6 +299,7 @@ static int savage_dispatch_dma_prim(drm_savage_private_t * dev_priv, case SAVAGE_PRIM_TRILIST_201: reorder = 1; prim = SAVAGE_PRIM_TRILIST; + /* fall through */ case SAVAGE_PRIM_TRILIST: if (n % 3 != 0) { DRM_ERROR("wrong number of vertices %u in TRILIST\n", @@ -436,6 +437,7 @@ static int savage_dispatch_vb_prim(drm_savage_private_t * dev_priv, case SAVAGE_PRIM_TRILIST_201: reorder = 1; prim = SAVAGE_PRIM_TRILIST; + /* fall through */ case SAVAGE_PRIM_TRILIST: if (n % 3 != 0) { DRM_ERROR("wrong number of vertices %u in TRILIST\n", @@ -557,6 +559,7 @@ static int savage_dispatch_dma_idx(drm_savage_private_t * dev_priv, case SAVAGE_PRIM_TRILIST_201: reorder = 1; prim = SAVAGE_PRIM_TRILIST; + /* fall through */ case SAVAGE_PRIM_TRILIST: if (n % 3 != 0) { DRM_ERROR("wrong number of indices %u in TRILIST\n", n); @@ -695,6 +698,7 @@ static int savage_dispatch_vb_idx(drm_savage_private_t * dev_priv, case SAVAGE_PRIM_TRILIST_201: reorder = 1; prim = SAVAGE_PRIM_TRILIST; + /* fall through */ case SAVAGE_PRIM_TRILIST: if (n % 3 != 0) { DRM_ERROR("wrong number of indices %u in TRILIST\n", n); -- 2.20.1