Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Zhoujie Wu <zjwu@marvell.com>
To:     "hans@owltronix.com" <hans@owltronix.com>,
        Matias Bjorling <mb@lightnvm.io>
CC:     "javier@javigon.com" <javier@javigon.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Hans Holmberg <hans.holmberg@cnexlabs.com>
Subject: RE: [EXT] [PATCH] lightnvm: pblk: extend line wp balance check
Thread-Topic: [EXT] [PATCH] lightnvm: pblk: extend line wp balance check
Thread-Index: AQHUt69Wxp69Whgu/EagayzimjQ1m6XGzhiQ
Date:   Tue, 29 Jan 2019 22:10:20 +0000
Message-ID: <MWHPR1801MB20300A1F6E55F7979DC0072ECA970@MWHPR1801MB2030.namprd18.prod.outlook.com>
References: <20190129084737.718-1-hans@owltronix.com>
In-Reply-To: <20190129084737.718-1-hans@owltronix.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: aaa0fcff-43c0-473a-9de5-08d686368ef1
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2019 22:10:20.2217
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1801MB2045
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-01-29_17:,,
 signatures=0
X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0
 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0
 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.0.1-1810050000 definitions=main-1901290158
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Sorry that my Linux email client has configuration issue and can't reply em=
ail. Used my outlook to reply as plain text and hope that I won't corrupt t=
he format.
Tested on my board and it works well. Since this is a good fix, I think you=
 don't need to do it based on my previous v3 patch and can directly apply y=
ours:)

Tested-by: Zhoujie Wu <zjwu@marvell.com>


-----Original Message-----
From: hans@owltronix.com <hans@owltronix.com>=20
Sent: Tuesday, January 29, 2019 12:48 AM
To: Matias Bjorling <mb@lightnvm.io>
Cc: javier@javigon.com; Zhoujie Wu <zjwu@marvell.com>; linux-block@vger.ker=
nel.org; linux-kernel@vger.kernel.org; Hans Holmberg <hans.holmberg@cnexlab=
s.com>
Subject: [EXT] [PATCH] lightnvm: pblk: extend line wp balance check

External Email

----------------------------------------------------------------------
From: Hans Holmberg <hans.holmberg@cnexlabs.com>

pblk stripes writes of minimal write size across all non-offline chunks in =
a line, which means that the maximum write pointer delta should not exceed =
the minimal write size. Extend the line write pointer balance check to cove=
r this case.

Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
---

This patch applies on top of Zhoujie's V3 of
"lightnvm: pblk: ignore bad block wp for pblk_line_wp_is_unbalanced

 drivers/lightnvm/pblk-recovery.c | 60 ++++++++++++++++++++------------
 1 file changed, 37 insertions(+), 23 deletions(-)

diff --git a/drivers/lightnvm/pblk-recovery.c b/drivers/lightnvm/pblk-recov=
ery.c
index 02d466e6925e..d86f580036d3 100644
--- a/drivers/lightnvm/pblk-recovery.c
+++ b/drivers/lightnvm/pblk-recovery.c
@@ -302,41 +302,55 @@ static int pblk_pad_distance(struct pblk *pblk, struc=
t pblk_line *line)
 	return (distance > line->left_msecs) ? line->left_msecs : distance;  }
=20
-static int pblk_line_wp_is_unbalanced(struct pblk *pblk,
-				      struct pblk_line *line)
+/* Return a chunk belonging to a line by stripe(write order) index */=20
+static struct nvm_chk_meta *pblk_get_stripe_chunk(struct pblk *pblk,
+						  struct pblk_line *line,
+						  int index)
 {
 	struct nvm_tgt_dev *dev =3D pblk->dev;
 	struct nvm_geo *geo =3D &dev->geo;
-	struct pblk_line_meta *lm =3D &pblk->lm;
 	struct pblk_lun *rlun;
-	struct nvm_chk_meta *chunk;
 	struct ppa_addr ppa;
-	u64 line_wp;
-	int pos, i, bit;
+	int pos;
=20
-	bit =3D find_first_zero_bit(line->blk_bitmap, lm->blk_per_line);
-	if (bit >=3D lm->blk_per_line)
-		return 0;
-	rlun =3D &pblk->luns[bit];
+	rlun =3D &pblk->luns[index];
 	ppa =3D rlun->bppa;
 	pos =3D pblk_ppa_to_pos(geo, ppa);
-	chunk =3D &line->chks[pos];
=20
-	line_wp =3D chunk->wp;
+	return &line->chks[pos];
+}
=20
-	for (i =3D bit + 1; i < lm->blk_per_line; i++) {
-		rlun =3D &pblk->luns[i];
-		ppa =3D rlun->bppa;
-		pos =3D pblk_ppa_to_pos(geo, ppa);
-		chunk =3D &line->chks[pos];
+static int pblk_line_wps_are_unbalanced(struct pblk *pblk,
+				      struct pblk_line *line)
+{
+	struct pblk_line_meta *lm =3D &pblk->lm;
+	int blk_in_line =3D lm->blk_per_line;
+	struct nvm_chk_meta *chunk;
+	u64 max_wp, min_wp;
+	int i;
=20
-		if (chunk->state & NVM_CHK_ST_OFFLINE)
-			continue;
+	i =3D find_first_zero_bit(line->blk_bitmap, blk_in_line);
+
+	/* If there is one or zero good chunks in the line,
+	 * the write pointers can't be unbalanced.
+	 */
+	if (i >=3D (blk_in_line - 1))
+		return 0;
=20
-		if (chunk->wp > line_wp)
+	chunk =3D pblk_get_stripe_chunk(pblk, line, i);
+	max_wp =3D chunk->wp;
+	if (max_wp > pblk->max_write_pgs)
+		min_wp =3D max_wp - pblk->max_write_pgs;
+	else
+		min_wp =3D 0;
+
+	i =3D find_next_zero_bit(line->blk_bitmap, blk_in_line, i + 1);
+	while (i < blk_in_line) {
+		chunk =3D pblk_get_stripe_chunk(pblk, line, i);
+		if (chunk->wp > max_wp || chunk->wp < min_wp)
 			return 1;
-		else if (chunk->wp < line_wp)
-			line_wp =3D chunk->wp;
+
+		i =3D find_next_zero_bit(line->blk_bitmap, blk_in_line, i + 1);
 	}
=20
 	return 0;
@@ -362,7 +376,7 @@ static int pblk_recov_scan_oob(struct pblk *pblk, struc=
t pblk_line *line,
 	int ret;
 	u64 left_ppas =3D pblk_sec_in_open_line(pblk, line) - lm->smeta_sec;
=20
-	if (pblk_line_wp_is_unbalanced(pblk, line))
+	if (pblk_line_wps_are_unbalanced(pblk, line))
 		pblk_warn(pblk, "recovering unbalanced line (%d)\n", line->id);
=20
 	ppa_list =3D p.ppa_list;
--
2.17.1