Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5188862imu; Tue, 29 Jan 2019 14:32:04 -0800 (PST) X-Google-Smtp-Source: ALg8bN5/Umomo5Sy+iN6wpizltBoT7wRaQBB1nQyRekrE6hk5DIRYK+84gASxBYeyBSIEhXieH4+ X-Received: by 2002:a63:9d05:: with SMTP id i5mr23510206pgd.98.1548801124529; Tue, 29 Jan 2019 14:32:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548801124; cv=none; d=google.com; s=arc-20160816; b=RUAZPbX30kYxGLtb4jmgWH3c9XPolL1OlJwix1sgocd5CwHJbAmiZ8pB0K8ZROkZ9t ZKI/3yUT6jEJlBuT4vaBbWea2+g1fSFE5cxaoP9O6AZlbHMPsQxf5wuuzP5Iz5Qn5mwQ b5GZb3L1jIEpx6RtqSL0OgfYq+dSJOVubYvU3n4YwJpQn1YM+cJ+8XRS5doCiVxb7MeD cY2dKeVsE2SbAX0P8IaxqrrPO41nv7IvJBkJbirPlPgLmNRp4DEpxtw0lfBSauiC7bys pIsmryDKgW4aj9tGP2BEsmN7Ap1gEDASv6zYqo56+ldL7lH2CAOdlwNOKMOpuqgea0kJ U14A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=x6Giq421sxtdfJWNiSSytBDXQh1YZE9ZyfoS1SwI2aQ=; b=p42wpU6klY7UuwwdJiHvtVK49k36suyd+QK4abNe0b9D72kDgVrgZvBzBjYUGHbvfR J5/vT81cV2YX3Y9YRpcWpgJtVJ6QpIo9Of6fbsrSSec/65H5LeXcAKwhO4EbY3hCSQTT BUvn5wqWWXN9YRzG7kBvA09sJ1U0RiTHukCGYRiwGsHIllpcq6C22rvhgkpaBRyCSXA0 0WptdmvfWZ23GWPgd+i265N8emx0t+A9Dz6GNxv+Q8t4z0/RGh6vhjVEicJrXaQk1l1g ox7OE/FcwA9t5WGJ3YgaJazk0frDD6rxezdx+bAy4gQ5bQXFfXLIlK61+yJk7hRP0bZq fUTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eEa7536u; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f17si30560820pff.171.2019.01.29.14.31.48; Tue, 29 Jan 2019 14:32:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eEa7536u; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729734AbfA2WbE (ORCPT + 99 others); Tue, 29 Jan 2019 17:31:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:43466 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727545AbfA2WbD (ORCPT ); Tue, 29 Jan 2019 17:31:03 -0500 Received: from mail-yw1-f53.google.com (mail-yw1-f53.google.com [209.85.161.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1E8E12147A; Tue, 29 Jan 2019 22:31:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548801062; bh=8mchtL/kda+QX5rreOUh8RrpnFpvoBbcXfLnACnhg74=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=eEa7536ucEFh2k5Ul7LJ0hYHP6HXe8zryDPiyEvKTt3Zc6NSK69j+CM/EDjgHRGKL wBzBh72QsQ4krwy6gq9miA7v0WREbn6759yL1EQfi5YdpZgc9fTiraJg4u+BmgXbmM KEELf6bYMjkawB1SY17aJ/hQmYVx+kCmByef6tTE= Received: by mail-yw1-f53.google.com with SMTP id d190so8842577ywd.12; Tue, 29 Jan 2019 14:31:02 -0800 (PST) X-Gm-Message-State: AJcUukfYh8tIqJYFrLLAee7USsaPy2zvYltvirp4/07XwXrUwAXJgSLc sZ03KujdxyDu672rJhlTiwRLzQ3/KTqMM/qKE3M= X-Received: by 2002:a81:8c1:: with SMTP id 184mr27309701ywi.392.1548801061366; Tue, 29 Jan 2019 14:31:01 -0800 (PST) MIME-Version: 1.0 References: <20190129200858.19773-1-goldsimon@gmx.de> In-Reply-To: <20190129200858.19773-1-goldsimon@gmx.de> From: Alan Tull Date: Tue, 29 Jan 2019 16:30:25 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: socfpga: fix base address of SDR controller To: Simon Goldschmidt Cc: Dinh Nguyen , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-fpga@vger.kernel.org, linux-kernel , Moritz Fischer , Rob Herring , Mark Rutland , Russell King , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 29, 2019 at 2:09 PM Simon Goldschmidt wrote: Hi Simon, Thanks for submitting. A couple of things... > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi > index f365003f0..8f6c1a5d6 100644 > --- a/arch/arm/boot/dts/socfpga.dtsi > +++ b/arch/arm/boot/dts/socfpga.dtsi > @@ -788,9 +788,9 @@ > reg = <0xfffec000 0x100>; > }; > > - sdr: sdr@ffc25000 { > + sdr: sdr@ffc20000 { > compatible = "altr,sdr-ctl", "syscon"; > - reg = <0xffc25000 0x1000>; > + reg = <0xffc20000 0x6000>; The binding doc will also need this change (in a separate patch) Documentation/devicetree/bindings/arm/altera/socfpga-sdram-controller.txt > diff --git a/arch/arm/mach-socfpga/self-refresh.S b/arch/arm/mach-socfpga/self-refresh.S > index f2d7f883e..bd7759357 100644 > --- a/arch/arm/mach-socfpga/self-refresh.S > +++ b/arch/arm/mach-socfpga/self-refresh.S > @@ -19,8 +19,8 @@ > #define MAX_LOOP_COUNT 1000 > > /* Register offset */ > -#define SDR_CTRLGRP_LOWPWREQ_ADDR 0x54 > -#define SDR_CTRLGRP_LOWPWRACK_ADDR 0x58 > +#define SDR_CTRLGRP_LOWPWREQ_ADDR 0x5054 > +#define SDR_CTRLGRP_LOWPWRACK_ADDR 0x5058 These offsets are used for ldr/sdr and are limited to 12 bits. This won't build if CONFIG_SOCFPGA_SUSPEND is enabled. /home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S: Assembler messages: /home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S:65: Error: bad immediate value for offset (20564) /home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S:67: Error: bad immediate value for offset (20564) /home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S:72: Error: bad immediate value for offset (20568) /home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S:101: Error: bad immediate value for offset (20564) /home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S:103: Error: bad immediate value for offset (20564) /home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S:108: Error: bad immediate value for offset (20568) /home/atull/repos/linux-socfpga/scripts/Makefile.build:367: recipe for target 'arch/arm/mach-socfpga/self-refresh.o' failed Thanks, Alan