Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <a8ae5209f676171a97cae7211411e7ced3ebefbc.camel@perches.com>
Subject: Re: [PATCH] iio:potentiostat:lmp91000: solve codestyle WARNINGs and
 CHECKs
From:   Joe Perches <joe@perches.com>
To:     Lucas Oshiro <lucasseikioshiro@gmail.com>, jic23@kernel.org,
        knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-usp@googlegroups.com,
        Anderson Reis <andersonreisrosa@gmail.com>
Date:   Tue, 29 Jan 2019 14:48:19 -0800
In-Reply-To: <20190129183656.15656-1-lucasseikioshiro@gmail.com>
References: <20190129183656.15656-1-lucasseikioshiro@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.1-1build1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2019-01-29 at 16:36 -0200, Lucas Oshiro wrote:
> Solve most of the checkpatch.pl WARNINGs and CHECKs on lmp9100.c. They
> are the following:
> 
> lmp91000.c:116: CHECK: Unnecessary parentheses around 'state != channel'
> lmp91000.c:116: CHECK: Unnecessary parentheses around 'channel == LMP91000_REG_MODECN_TEMP'
> lmp91000.c:214: CHECK: braces {} should be used on all arms of this statement
> lmp91000.c:216: CHECK: Unbalanced braces around else statement
> lmp91000.c:258: WARNING: line over 80 characters
> lmp91000.c:279: CHECK: Please don't use multiple blank lines

Some will say this is too many things to do at once.
I think it's mostly fine, but there are a few nits
that also could use fixing.

> diff --git a/drivers/iio/potentiostat/lmp91000.c b/drivers/iio/potentiostat/lmp91000.c
[]
> @@ -211,9 +211,9 @@ static int lmp91000_read_config(struct lmp91000_data *data)
>  
>  	ret = of_property_read_u32(np, "ti,tia-gain-ohm", &val);
>  	if (ret) {
> -		if (of_property_read_bool(np, "ti,external-tia-resistor"))
> +		if (of_property_read_bool(np, "ti,external-tia-resistor")) {
>  			val = 0;
> -		else {
> +		} else {
>  			dev_err(dev, "no ti,tia-gain-ohm defined");
>  			return ret;
>  		}

This could use inverting the test

	if (ret) {
		if (!of_property_read_bool(...)) {
			dev_err(dev, "no ti,ti-gain-ohm defined\n");
			return ret;
		}
		val = 0;
	}

Also the dev_err is missing a '\n' termination