Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5272289imu; Tue, 29 Jan 2019 16:16:41 -0800 (PST) X-Google-Smtp-Source: ALg8bN79FPw9lZOzkLwSMnUIZukaOddD3V9BQ2VuC6BhF/TeGdx9jqpkSWr8jsSLfAb998WZGHPs X-Received: by 2002:a63:b34f:: with SMTP id x15mr25807405pgt.243.1548807401419; Tue, 29 Jan 2019 16:16:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548807401; cv=none; d=google.com; s=arc-20160816; b=taqSOIfwT64oQiv3Rl4y+yOXLMTv3Lj07DPt/fcHaX9gtfyMv8bBAKUIVQWdt5Hn2M GelrzgaGaV4zqaMystOZydlT47YCpRzibJuz9Rk0L0cZ6jODPWfMk878Sqz6doBJ+Z1C tYMM44MqvCOIY13DV1HNZ3xc/HjtVnnUQ4jKe5pwnvAQ6S350gFhQM0VmAJ5EU8KE4ur 0ElVwhPPQLo0T8ykIT2wPvEnGJ5YE3sEZ7D+Mor7PiNnXm+Qo8AOiGkbBhg/CywM/k55 MQd4fGb6XJNig77+Jy/6um2IXTQie/gsPbMrBMQcs/m6m0ZPj3sdgVOn0u6Np/H1/529 bxpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=MKqS3BLTATH4DuiPK/kTOXd/5QoM6+S3iyHcd0Em+fM=; b=lJrJ+a8a66C0VO2d95+Pm1M6UWjtud10IdyfAn7i/lG27099IgDDagPu4y9xjBcVqC s7lLbSKEAaKC8yxg3vBytaI8zNWqZjXPVSewKZzkcTecSkv7oqmKYbkhSuZy/Phs1iOa YXauGZZL4rBDbG1go6PRVRcGBC+Bj1XvetzvzAFrCaSK6pedW0OxtBHNhUL4aSDjW6Fe qgIRMfj4zzdhXCd80LgCMXWwISbN6A2Nu+Jcm8lYhRnYe92lOBHjn9UEskjubCOLCmvz UfFiuP7Y2gk8uWb3kJK9rxZuHfhQcMC1OpiWCUH60ErrzHPjlQzQDAprB5/PuBKglMkC /QDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=IKbkJZmm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h68si3322466plb.375.2019.01.29.16.16.26; Tue, 29 Jan 2019 16:16:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=IKbkJZmm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727879AbfA3AQI (ORCPT + 99 others); Tue, 29 Jan 2019 19:16:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:36972 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727185AbfA3AQI (ORCPT ); Tue, 29 Jan 2019 19:16:08 -0500 Received: from [192.168.1.31] (cpe-70-114-128-244.austin.res.rr.com [70.114.128.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9F67B2082E; Wed, 30 Jan 2019 00:16:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548807366; bh=kV4y/UKkR9JubxBxOjz4MPk0cVTALkKyVGPebrRFNAQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=IKbkJZmmYd7AWgPNY+WmXpWx2z6MTsAOwva+m53cjcSGo35MMhu8kOtloRaCJLJOg LBsk4rBQYrzQfqyhgCDkrBOrKrbdrePWh5Q9WECLQnnA1H90rIKsQMwnlMDIjuOfAh i4DW7BTmS5vwLr30uhq4EzrmidsMBMb3ZKYODgFw= Subject: Re: [PATCH] ARM: socfpga: fix base address of SDR controller To: Simon Goldschmidt Cc: devicetree@vger.kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, Moritz Fischer , Rob Herring , Alan Tull , Mark Rutland , Russell King , linux-arm-kernel@lists.infradead.org References: <20190129200858.19773-1-goldsimon@gmx.de> From: Dinh Nguyen Openpgp: preference=signencrypt Autocrypt: addr=dinguyen@kernel.org; prefer-encrypt=mutual; keydata= mQINBFEnvWwBEAC44OQqJjuetSRuOpBMIk3HojL8dY1krl8T8GJjfgc/Gh97CfVbrqhV5yQ3 Sk/MW9mxO9KNvQCbZtthfn62YHmroNwipjZ6wKOMfKdtJR4+8JW/ShIJYnrMfwN8Wki6O+5a yPNNCeENHleV0FLVXw3aACxOcjEzGJHYmg4UC+56rfoxPEhKF6aGBTV5aGKMtQy77ywuqt12 c+hlRXHODmXdIeT2V4/u/AsFNAq6UFUEvHrVj+dMIyv2VhjRvkcESIGnG12ifPdU7v/+wom/ smtfOAGojgTCqpwd0Ay2xFzgGnSCIFRHp0I/OJqhUcwAYEAdgHSBVwiyTQx2jP+eDu3Q0jI3 K/x5qrhZ7lj8MmJPJWQOSYC4fYSse2oVO+2msoMTvMi3+Jy8k+QNH8LhB6agq7wTgF2jodwO yij5BRRIKttp4U62yUgfwbQtEUvatkaBQlG3qSerOzcdjSb4nhRPxasRqNbgkBfs7kqH02qU LOAXJf+y9Y1o6Nk9YCqb5EprDcKCqg2c8hUya8BYqo7y+0NkBU30mpzhaJXncbCMz3CQZYgV 1TR0qEzMv/QtoVuuPtWH9RCC83J5IYw1uFUG4RaoL7Z03fJhxGiXx3/r5Kr/hC9eMl2he6vH 8rrEpGGDm/mwZOEoG5D758WQHLGH4dTAATg0+ZzFHWBbSnNaSQARAQABtCFEaW5oIE5ndXll biA8ZGluZ3V5ZW5Aa2VybmVsLm9yZz6JAjgEEwECACIFAlbG5oQCGwMGCwkIBwMCBhUIAgkK CwQWAgMBAh4BAheAAAoJEBmUBAuBoyj0fIgQAICrZ2ceRWpkZv1UPM/6hBkWwOo3YkzSQwL+ AH15hf9xx0D5mvzEtZ97ZoD0sAuB+aVIFwolet+nw49Q8HA3E/3j0DT7sIAqJpcPx3za+kKT twuQ4NkQTTi4q5WCpA5b6e2qzIynB50b3FA6bCjJinN06PxhdOixJGv1qDDmJ01fq2lA7/PL cny/1PIo6PVMWo9nf77L6iXVy8sK/d30pa1pjhMivfenIleIPYhWN1ZdRAkH39ReDxdqjQXN NHanNtsnoCPFsqeCLmuUwcG+XSTo/gEM6l2sdoMF4qSkD4DdrVf5rsOyN4KJAY9Uqytn4781 n6l1NAQSRr0LPT5r6xdQ3YXIbwUfrBWh2nDPm0tihuHoH0CfyJMrFupSmjrKXF84F3cq0DzC yasTWUKyW/YURbWeGMpQH3ioDLvBn0H3AlVoSloaRzPudQ6mP4O8mY0DZQASGf6leM82V3t0 Gw8MxY9tIiowY7Yl2bHqXCorPlcEYXjzBP32UOxIK7y7AQ1JQkcv6pZ0/6lX6hMshzi9Ydw0 m8USfFRZb48gsp039gODbSMCQ2NfxBEyUPw1O9nertCMbIO/0bHKkP9aiHwg3BPwm3YL1UvM ngbze/8cyjg9pW3Eu1QAzMQHYkT1iiEjJ8fTssqDLjgJyp/I3YHYUuAf3i8SlcZTusIwSqnD uQINBFEnvWwBEADZqma4LI+vMqJYe15fxnX8ANw+ZuDeYHy17VXqQ7dA7n8E827ndnoXoBKB 0n7smz1C0I9StarHQPYTUciMLsaUpedEfpYgqLa7eRLFPvk/cVXxmY8Pk+aO8zHafr8yrFB1 cYHO3Ld8d/DvF2DuC3iqzmgXzaRQhvQZvJ513nveCa2zTPPCj5w4f/Qkq8OgCz9fOrf/CseM xcP3Jssyf8qTZ4CTt1L6McRZPA/oFNTTgS/KA22PMMP9i8E6dF0Nsj0MN0R7261161PqfA9h 5c+BBzKZ6IHvmfwY+Fb0AgbqegOV8H/wQYCltPJHeA5y1kc/rqplw5I5d8Q6B29p0xxXSfaP UQ/qmXUkNQPNhsMnlL3wRoCol60IADiEyDJHVZRIl6U2K54LyYE1vkf14JM670FsUH608Hmk 30FG8bxax9i+8Muda9ok/KR4Z/QPQukmHIN9jVP1r1C/aAEvjQ2PK9aqrlXCKKenQzZ8qbeC rOTXSuJgWmWnPWzDrMxyEyy+e84bm+3/uPhZjjrNiaTzHHSRnF2ffJigu9fDKAwSof6SwbeH eZcIM4a9Dy+Ue0REaAqFacktlfELeu1LVzMRvpIfPua8izTUmACTgz2kltTaeSxAXZwIziwY prPU3cfnAjqxFHO2TwEpaQOMf8SH9BSAaCXArjfurOF+Pi3lKwARAQABiQIfBBgBAgAJBQJR J71sAhsMAAoJEBmUBAuBoyj0MnIQAI+bcNsfTNltf5AbMJptDgzISZJrYCXuzOgv4+d1CubD 83s0k6VJgsiCIEpvELQJsr58xB6l+o3yTBZRo/LViNLk0jF4CmCdXWjTyaQAIceEdlaeeTGH d5GqAud9rv9q1ERHTcvmoEX6pwv3m66ANK/dHdBV97vXacl+BjQ71aRiAiAFySbJXnqj+hZQ K8TCI/6TOtWJ9aicgiKpmh/sGmdeJCwZ90nxISvkxDXLEmJ1prvbGc74FGNVNTW4mmuNqj/p oNr0iHan8hjPNXwoyLNCtj3I5tBmiHZcOiHDUufHDyKQcsKsKI8kqW3pJlDSACeNpKkrjrib 3KLQHSEhTQCt3ZUDf5xNPnFHOnBjQuGkumlmhkgD5RVguki39AP2BQYp/mdk1NCRQxz5PR1B 2w0QaTgPY24chY9PICcMw+VeEgHZJAhuARKglxiYj9szirPd2kv4CFu2w6a5HNMdVT+i5Hov cJEJNezizexE0dVclt9OS2U9Xwb3VOjs1ITMEYUf8T1j83iiCCFuXqH4U3Eji0nDEiEN5Ac0 Jn/EGOBG2qGyKZ4uOec9j5ABF7J6hyO7H6LJaX5bLtp0Z7wUbyVaR4UIGdIOchNgNQk4stfm JiyuXyoFl/1ihREfvUG/e7+VAAoOBnMjitE5/qUERDoEkkuQkMcAHyEyd+XZMyXY Message-ID: <0711a2e0-b4fb-fa12-7c5c-0b5da73c8b02@kernel.org> Date: Tue, 29 Jan 2019 18:16:04 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190129200858.19773-1-goldsimon@gmx.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/29/19 2:08 PM, Simon Goldschmidt wrote: > From: Simon Goldschmidt > > The documentation for socfpga gen5 says the base address of the sdram > controller is 0xffc20000, while the current devicetree says it is at > 0xffc25000. > > While this is not a problem for Linux, as it only accesses the registers > above 0xffc25000, it *is* a problem for U-Boot because the lower registers > are used during DDR calibration (up to now, the U-Boot driver does not use > the dts address, but that should change). > > To keep Linux and U-Boot devicetrees in sync, this patch changes the base > address to 0xffc20000 and adapts the 2 files where it is currently used. > > This patch changes the dts and 2 drivers with one commit to prevent > breaking the code if dts change and driver change would be split. > > Signed-off-by: Simon Goldschmidt > --- > > arch/arm/boot/dts/socfpga.dtsi | 4 ++-- > arch/arm/mach-socfpga/self-refresh.S | 4 ++-- > drivers/fpga/altera-fpga2sdram.c | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi > index f365003f0..8f6c1a5d6 100644 > --- a/arch/arm/boot/dts/socfpga.dtsi > +++ b/arch/arm/boot/dts/socfpga.dtsi > @@ -788,9 +788,9 @@ > reg = <0xfffec000 0x100>; > }; > > - sdr: sdr@ffc25000 { > + sdr: sdr@ffc20000 { > compatible = "altr,sdr-ctl", "syscon"; > - reg = <0xffc25000 0x1000>; > + reg = <0xffc20000 0x6000>; I don't see the U-Boot device tree having this change. Yes, the documentation does state that the SDR address starts at 0xffc20000, but all of the pertinent registers start at 0x5000 offset. Thus, the starting address should be 0xffc25000.[1] [1] https://www.intel.com/content/www/us/en/programmable/documentation/sfo1410143707420.html#sfo1411577366917 Dinh