Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 30 Jan 2019 11:18:46 +1100
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason <avarab@gmail.com>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org,
        Jacob Keller <jacob.e.keller@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
        Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH] Documentation/process: hardcoded core.abbrev considered
 harmful!
Message-ID: <20190130111846.0a6b8e2c@canb.auug.org.au>
In-Reply-To: <20181220000112.24891-1-avarab@gmail.com>
References: <1396949135-27122-1-git-send-email-jeffrey.t.kirsher@intel.com>
        <20181220000112.24891-1-avarab@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 boundary="Sig_/dJChQe94zNa2C9bkubqiTY_"; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/dJChQe94zNa2C9bkubqiTY_
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi all,

On Thu, 20 Dec 2018 01:01:12 +0100 =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason <=
avarab@gmail.com> wrote:
>
> Stop recommending that core.abbrev=3D12 be hardcoded when referring to
> kernel commits, and instead rely on the git's default abbreviation.
>=20
> Hardcoding this at "12" was done in
> 8401aa1f5997 ("Documentation/SubmittingPatches: describe the Fixes:
> tag", 2014-06-06), back then Linus's git/git@e6c587c733 ("abbrev: auto
> size the default abbreviation", 2016-09-30) had not yet landed, and
> the default abbreviation was "7".
>=20
> At the time linux.git had around 3.5 million objects, so if the auto
> sizing had been in effect "11" would have been picked. Now "12" is
> what we pick by default anyway.
>=20
> More importantly, we'll roll over to "13" at around 16 million
> objects, which given the growth rate isn't that far off. At that point
> this documentation will be worse than the default.
>=20
> Let's just stop doing this. Git versions as of 2.11 released over 2
> years ago use the auto-sizing, and it seems like a fair assumption
> that kernel developers use a fairly recent git version.
>=20
> Signed-off-by: =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason <avarab@gmail.com>

Acked-by: Stephen Rothwell <sfr@canb.auug.org.au>

Since I have been checking Fixes: tags, it has become obvious that some
kernel developers have core.abbrev set to 7, 9 or 10 (or maybe they are
running very old versions of git).  Hopefully this will encourage them
to remove that setting (and upgrade).

Can someone (Jon?) please apply this patch?
--=20
Cheers,
Stephen Rothwell

--Sig_/dJChQe94zNa2C9bkubqiTY_
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAlxQ7WYACgkQAVBC80lX
0Gz2EAgAnycT6wdRhJ5VkqzmzKI5gRqrTx+1y2qHLnQrfBylQiI0NW1+uBlV1weM
MncyaDfJwIukx4+0d7EpZtqWn/l6XjdTXGudBmnU+jRNA4Vil/M9rzYQ5PXb7Ym6
v9J8r1kQMzr1O4vpBH+srnoOBVf4xPBwnL7ZbpUQrpBbPbQwo97h1ku5KrovcWgF
phS97o4+8e5tACUfZ0Dh2W1S6WQ4BWxUCWLFFc00HXloB4ct/Q4jzG3D2/ASGg+b
qKwCN5ivXu3s5LF2sGlbjVq/E32KN9e24rS+OXxHDkCKWIULR4y/RQFK3TVaVCrs
r+WOOy0n3UoZ6a5HKf4hUTVaxuRUWw==
=Yv9u
-----END PGP SIGNATURE-----

--Sig_/dJChQe94zNa2C9bkubqiTY_--