Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190129004934.85885-1-tkjos@google.com> <20190129004934.85885-2-tkjos@google.com>
 <20190129081218.GL1795@kadam>
In-Reply-To: <20190129081218.GL1795@kadam>
From:   Todd Kjos <tkjos@google.com>
Date:   Tue, 29 Jan 2019 16:32:09 -0800
Message-ID: <CAHRSSEzjgtrouqJkhduaZt99RbmtA5a4Lc2xgyp_pt4cg7Vpmg@mail.gmail.com>
Subject: Re: [PATCH 1/7] binder: create userspace-to-binder-buffer copy function
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Todd Kjos <tkjos@android.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>,
        "open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Martijn Coenen <maco@google.com>, joel@joelfernandes.org,
        Android Kernel Team <kernel-team@android.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jan 29, 2019 at 12:12 AM Dan Carpenter <dan.carpenter@oracle.com> w=
rote:
>
> On Mon, Jan 28, 2019 at 04:49:28PM -0800, Todd Kjos wrote:
> > +/**
> > + * binder_alloc_copy_user_to_buffer() - copy src user to tgt user
> > + * @alloc: binder_alloc for this proc
> > + * @buffer: binder buffer to be accessed
> > + * @buffer_offset: offset into @buffer data
> > + * @from: userspace pointer to source buffer
> > + * @bytes: bytes to copy
> > + *
> > + * Copy bytes from source userspace to target buffer.
> > + *
> > + * Return: bytes remaining to be copied
> > + */
> > +unsigned long
> > +binder_alloc_copy_user_to_buffer(struct binder_alloc *alloc,
> > +                              struct binder_buffer *buffer,
> > +                              binder_size_t buffer_offset,
> > +                              const void __user *from,
> > +                              size_t bytes)
> > +{
> > +     if (!check_buffer(alloc, buffer, buffer_offset, bytes))
> > +             return bytes;
> > +
> > +     while (bytes) {
> > +             unsigned long size;
> > +             unsigned long ret;
> > +             struct page *page;
> > +             pgoff_t pgoff;
> > +             void *kptr;
> > +
> > +             page =3D binder_alloc_get_page(alloc, buffer,
> > +                                          buffer_offset, &pgoff);
> > +             size =3D min(bytes, (size_t)(PAGE_SIZE - pgoff));
>
> This code has so much more casting than necessary.  To me casting says
> that we haven't got the types correct or something.  I've just pulled
> this function out as an example really, but none of the casts here are
> required...  This could just be:
>
>                 size =3D min(bytes, PAGE_SIZE - pgoff);

Dan,

Thanks for the feedback.

The one above: "size =3D min(bytes, PAGE_SIZE - pgoff);", results in
32-bit compile warnings:

./include/linux/kernel.h:846:29: warning: comparison of distinct
pointer types lacks a cast
   (!!(sizeof((typeof(x) *)1 =3D=3D (typeof(y) *)1)))
[...]
drivers/android/binder_alloc.c:1157:10: note: in expansion of macro =E2=80=
=98min=E2=80=99
   size =3D min(bytes, PAGE_SIZE - pgoff);

so, I took your suggestion:

  size =3D min_t(size_t, bytes, PAGE_SIZE - pgoff);

>
> Btw, if you really need to do a cast inside a min() (you don't in this
> cast) then use min_t().
>
> > +             kptr =3D (void *)((uintptr_t)kmap(page) + pgoff);
>
> This would be a lot cleaner as:
>
>                 kptr =3D kmap(page) + pgoff;

It definitely is cleaner, but the clean version is doing arithmetic on
a void pointer which is generally not considered good practice (but is
supported by gcc). Is this acceptable in the kernel? I don't see any
statement on it in Documentation/process/coding-style.rst.

If so, I agree a bunch of these casts can go as you suggest.

-Todd

[...]

>
> regards,
> dan carpenter
>