Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5521242imu; Tue, 29 Jan 2019 22:09:07 -0800 (PST) X-Google-Smtp-Source: ALg8bN7Wc5rvdVLGgKepkPXYO6Rbs8H2Tu+cBJJwDxMbOzHeyQl3ZT0MlgXLj//5HG/vWxMNpRlb X-Received: by 2002:a17:902:9691:: with SMTP id n17mr29883776plp.9.1548828547000; Tue, 29 Jan 2019 22:09:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548828546; cv=none; d=google.com; s=arc-20160816; b=1GSG0DqcnowpDRhx2/xJmfxKPu+idex7L1m4i6ghS2/QHswzx+6mNTj91kSoRwjEDU NLKJU0CBYfGDHUn1UwgL+m67zF1yN0YlTxRcocbEsPMmMH3HqWTzHTcLU4aoNfw1yMHC 4RzeHEF1MNyhLV75D1Qr9ktgz56EjgtpT743MMfTWHc8RvOb9+bSh/1M7ifhlSLqXDBu EDX3hBEFdI/SMyJMnDEAmD8p7hbCOmx6ep7pBOrusI75CXs8IgatrkLvZ0VK3jEgtT8U o4Wrr+5ER/NJgziCgPRpop/P8e1jQAcP78XcP4/fwK5TmYFMIvLht1TgsC3d4X4mnjRf d6AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=tK9mSywMDOVGyM/DNFGFSATJj9vh7JMH2LOwZoMxCSU=; b=vrHJYohnyeXvDPOBi2UUvKsRs14VzD9UglvJledMbHRvWgMQMWxF8OB2clEF1B7xQk XGfMJHfy1PL8+ikPDd/oZF5APD8Qq9BS35Ig06q9DjNXuHTLo0NupBg3NUd2W3P9xt0+ s3qVGNlkm66cZFvSm38cMKLTr6BRQOgQEZov8INl5BwFhalW2FfC5XD7Bua3leQLw4xu p9zO/rrtspaYfdL3RWK6Fl8UrilpqknYFE2DZyaDmYusGsh4KTF2wbjJV9+zA/vXoVCW Bvy1qWRdjpI28aBQ5NkbCdVGdVXhj0nMAB3jo+LJpuOtgldkP0y06nCthrxldtOQGcl9 7m1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="C5OdNA/d"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bc3si634404plb.130.2019.01.29.22.08.49; Tue, 29 Jan 2019 22:09:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="C5OdNA/d"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727335AbfA3GIo (ORCPT + 99 others); Wed, 30 Jan 2019 01:08:44 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:39717 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725844AbfA3GIo (ORCPT ); Wed, 30 Jan 2019 01:08:44 -0500 Received: by mail-lj1-f193.google.com with SMTP id t9-v6so19640568ljh.6; Tue, 29 Jan 2019 22:08:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tK9mSywMDOVGyM/DNFGFSATJj9vh7JMH2LOwZoMxCSU=; b=C5OdNA/dZVLi++NRbdwbRb/GMtJvl/Xicn6gxjRWYNRcF3TmontlmU1lTiQEmkwqoB BhTTgGNx1w7iLP3IdZFH1owU2nUGy9gHn8zJo8hlPydipnQxMkhYFrwRLqRWJv8agl5+ krCF7oMQHMd4FSwPyuMQzmwT5jyyuPPDnyaM1IO1UTp1zqdyQZ0RZrqdrqR7xX5YsCeK kgHcAS7wC11OFPgUsjaE/XYl1xwrzjRn9V4ETMdTtSt/e8gvJ0tVgykOTsXTjb9xZQyA G7LUQ4BJh4vRXV/j7hgb+/N9PvFzZQhImxtWIHw1VUkAgPTkJ9Jj/fXlOvlvCdhM26RR RdEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tK9mSywMDOVGyM/DNFGFSATJj9vh7JMH2LOwZoMxCSU=; b=ImiNU2wG4DfpG+v8Vx7oWAwKuOOEh/4iyur/E5kzU3/I57UTlLsAVDX7c9n4p9ikNC y/Bimo5OsYwWAh3Zp3rRJP0VzW0DDMSPGXou2RWlkwwHUQJdPAGJ3xJ0abL9EIZZNiX3 sEVevW2M3yAHk0NWP4jMWt3Qh2ei3TZk+venBtBNQ+PQ2g1pdOXqguK+EPEIVu1Pz9v7 Huhq0t37agAM60lWnGUl1bAqPnFpeD9caDbWSdkPLFhLDknH7yVT9uejI160NJRUOc+R joeqKxFqlTQt2Yc7QmiZLojV1mAzyuCkNYLp2sgqiunpalMO5J9U4Hq0DTB5LVvsESz1 KLJQ== X-Gm-Message-State: AJcUukdxMId7GXtdO+0EiA//0ybIbn+xMvqjJZdP3KjjL1/ZGKSthSu/ P18IPte0ZCV53QHQ0bbtlQ1YEEsfd9OgRCLxa/I= X-Received: by 2002:a2e:9c87:: with SMTP id x7-v6mr22035012lji.196.1548828522133; Tue, 29 Jan 2019 22:08:42 -0800 (PST) MIME-Version: 1.0 References: <20190129200858.19773-1-goldsimon@gmx.de> In-Reply-To: From: Simon Goldschmidt Date: Wed, 30 Jan 2019 07:08:30 +0100 Message-ID: Subject: Re: [PATCH] ARM: socfpga: fix base address of SDR controller To: Alan Tull Cc: Dinh Nguyen , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-fpga@vger.kernel.org, linux-kernel , Moritz Fischer , Rob Herring , Mark Rutland , Russell King , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 29, 2019 at 11:31 PM Alan Tull wrote: > > On Tue, Jan 29, 2019 at 2:09 PM Simon Goldschmidt > wrote: > > Hi Simon, > > Thanks for submitting. A couple of things... > > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi > > index f365003f0..8f6c1a5d6 100644 > > --- a/arch/arm/boot/dts/socfpga.dtsi > > +++ b/arch/arm/boot/dts/socfpga.dtsi > > @@ -788,9 +788,9 @@ > > reg = <0xfffec000 0x100>; > > }; > > > > - sdr: sdr@ffc25000 { > > + sdr: sdr@ffc20000 { > > compatible = "altr,sdr-ctl", "syscon"; > > - reg = <0xffc25000 0x1000>; > > + reg = <0xffc20000 0x6000>; > > The binding doc will also need this change (in a separate patch) > Documentation/devicetree/bindings/arm/altera/socfpga-sdram-controller.txt Right. I didn't realise there is an actual address in that file as it says "Example"... But I'll make sure to change that if this patch is accepted. > > > diff --git a/arch/arm/mach-socfpga/self-refresh.S b/arch/arm/mach-socfpga/self-refresh.S > > index f2d7f883e..bd7759357 100644 > > --- a/arch/arm/mach-socfpga/self-refresh.S > > +++ b/arch/arm/mach-socfpga/self-refresh.S > > @@ -19,8 +19,8 @@ > > #define MAX_LOOP_COUNT 1000 > > > > /* Register offset */ > > -#define SDR_CTRLGRP_LOWPWREQ_ADDR 0x54 > > -#define SDR_CTRLGRP_LOWPWRACK_ADDR 0x58 > > +#define SDR_CTRLGRP_LOWPWREQ_ADDR 0x5054 > > +#define SDR_CTRLGRP_LOWPWRACK_ADDR 0x5058 > > These offsets are used for ldr/sdr and are limited to 12 bits. This > won't build if CONFIG_SOCFPGA_SUSPEND is enabled. > > /home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S: > Assembler messages: > /home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S:65: > Error: bad immediate value for offset (20564) > /home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S:67: > Error: bad immediate value for offset (20564) > /home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S:72: > Error: bad immediate value for offset (20568) > /home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S:101: > Error: bad immediate value for offset (20564) > /home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S:103: > Error: bad immediate value for offset (20564) > /home/atull/repos/linux-socfpga/arch/arm/mach-socfpga/self-refresh.S:108: > Error: bad immediate value for offset (20568) > /home/atull/repos/linux-socfpga/scripts/Makefile.build:367: recipe for > target 'arch/arm/mach-socfpga/self-refresh.o' failed Oops, you're right. Sorry for that. I just saw now that socfpga_defconfig leaves CONFIG_SOCFPGA_SUSPEND inactive. I'll make sure to test that if it comes to v2 (depending on the discussion). Thanks, Simon