Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5541548imu; Tue, 29 Jan 2019 22:35:19 -0800 (PST) X-Google-Smtp-Source: ALg8bN44NKFknjK55W7/FIK7IKY0Rd9ybpuZ8HobM07llmWrzbvKZtceUjAGIGTXa9bf56w6qMtr X-Received: by 2002:a63:334a:: with SMTP id z71mr26743319pgz.400.1548830119393; Tue, 29 Jan 2019 22:35:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548830119; cv=none; d=google.com; s=arc-20160816; b=y0GOebAkiCpOZleYTr7NHoSASDxl+YEqlmlNfWZEj4sBR4efD/EYw9nwdZOSl+qL3p vnY/3p4xRxdcIuW+GhHlWbZLbxi8Rltt/4kgqmGXf0yzgQy7RrnzdcFcfP9/3uVMBB5i pCFA3qE5ibAJURFE2IYf+A+pkXghA7c1UJWfgl9Px7lgsfBup1pIEtNG4ErRXIdWB3b1 F/h3mmYxIx5IZ4whKdgXWaSOMcb5dGict0YxOn5DaZqEBiATFGUGY0+kNS8b5fSQTZ6/ zL0E1fSMRY0thqVqxZIagWFk0NnZpnFjBzbekGBTmVHYoX/SaF1HZpOqoLPk7Ak+hpjE E8wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=jNE+4udC0izqltLgoNQtEx1CbuDQNuojldpq4eIFanM=; b=AOw5rhgBLQVi/yl/ojVqUDddyTxUTlSnVqC4lG158S7SSWEkXBJFGJui3cvYOj/Kt3 yU0j7F0hVGtv5aa6mtHLO7DhcjKwR/DaDVlnQVW0gX+sHgYSKfTzEknNkrZ3RHEeGgo2 jb59Bin84ZUqMryoZBSvvcXGIZcHvK0tCnJLn9jg6Cs1daIr4vAyaz26BI6RSzKYRWUq HrI3N0w82QKRKz8dyZG79DbALVZMjsk7kez7JKFs75vVUIykhagPNJ7S9BbcJ7l4edeZ /nulTLvcv6M50SIo68SzCQwAOV03AJXFFvtHlZEd0aIgXnPeX/YQznqFjcnE46SkQtgF gesw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PcNmju34; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d40si627120pla.427.2019.01.29.22.35.02; Tue, 29 Jan 2019 22:35:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PcNmju34; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725853AbfA3Ge7 (ORCPT + 99 others); Wed, 30 Jan 2019 01:34:59 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:47039 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725820AbfA3Ge7 (ORCPT ); Wed, 30 Jan 2019 01:34:59 -0500 Received: by mail-pf1-f194.google.com with SMTP id c73so10944958pfe.13 for ; Tue, 29 Jan 2019 22:34:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jNE+4udC0izqltLgoNQtEx1CbuDQNuojldpq4eIFanM=; b=PcNmju34AKOJkMXvsX37WqzCFdsnHpkdz2LmjdOnUruddbhgMa0AW8Ur/jaTbFmUsL Dk9t63qixe79JTpMPsw5XwIiU3S8vMWSnBnTcpUuHYTvmsGMt9ppoutuCdWMy7z2lNzZ na4L3ZLldkTd3V86Yl1kyCK0eBRfukiQIugwg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jNE+4udC0izqltLgoNQtEx1CbuDQNuojldpq4eIFanM=; b=F+J3jt+vBCzXWepkH7JBZarQQHPErA7vErHNeZHljjmD7054cF1RCubH+DGaNh4giG v/VcV3PpuI8RdKgmSGXCfWfGWuil4jn2zpBkMi9zS8qvLMlk/YX311TVXJvq1WPgZsig YYuZr3X44jlKEQq5BVOfbORaSadRj6utxhg9GkpGOQQeu0m3sagmbkjpCUqmwiL1w8Z0 ZfenE2p4e7w+nV07X3XvesXAPwhZBkPrfTZ663eLq+tps/6f9+DDH3GNBT3WXlZNXu7o ngYcxiNckAKngkO8Xh8Geizvhvfgc/fA5DPbcMDg6T37LAE2guPqeXKSpZjEjm7AGP+r eP8g== X-Gm-Message-State: AJcUukdobY4CwN28yYk1A6kSfOP6RjSksbAXYMxeisAtOm2WGSwKU+cL ApiRxnm86AYSzq/rnuTnOfC7VE5TtGw= X-Received: by 2002:a63:184a:: with SMTP id 10mr26170579pgy.81.1548830098223; Tue, 29 Jan 2019 22:34:58 -0800 (PST) Received: from localhost ([122.172.102.63]) by smtp.gmail.com with ESMTPSA id w128sm1093953pfw.79.2019.01.29.22.34.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 22:34:57 -0800 (PST) Date: Wed, 30 Jan 2019 12:04:55 +0530 From: Viresh Kumar To: Amit Kucheria Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Sudeep Holla , linux-pm@vger.kernel.org Subject: Re: [PATCH] cpufreq: Auto-register the driver as a thermal cooling device if asked Message-ID: <20190130063455.f7wuv27zias5k5kp@vireshk-i7> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180323-120-3dd1ac Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30-01-19, 10:52, Amit Kucheria wrote: > All cpufreq drivers do similar things to register as a cooling device. > Provide a cpufreq driver flag so drivers can just ask the cpufreq core > to register the cooling device on their behalf. This allows us to get > rid of duplicated code in the drivers. > > In order to allow this, we add a struct thermal_cooling_device pointer > to struct cpufreq_policy so that drivers don't need to store it in a > private data structure. > > Suggested-by: Stephen Boyd > Suggested-by: Viresh Kumar > Signed-off-by: Amit Kucheria > Reviewed-by: Matthias Kaehlcke > Tested-by: Matthias Kaehlcke > Acked-by: Viresh Kumar > --- > drivers/cpufreq/cpufreq.c | 11 +++++++++++ > include/linux/cpufreq.h | 9 +++++++++ > 2 files changed, 20 insertions(+) Thanks for the rework. This looks good now. -- viresh