Date: Fri, 5 Mar 2004 16:39:17 +0100
From: Tobias Diedrich <ranma@gmx.at>
To: Daniel McNeil <daniel@osdl.org>
Cc: Badari Pulavarty <pbadari@us.ibm.com>, Andrew Morton <akpm@osdl.org>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       "linux-aio@kvack.org" <linux-aio@kvack.org>,
       Suparna Bhattacharya <suparna@in.ibm.com>
Subject: Re: [PATCH 2.6.3-mm4] direct_io_worker-aio_complete patch (fixes AIO Oops)
Message-ID: <20040305153916.GA2779@melchior.yamamaya.is-a-geek.org>
Mail-Followup-To: Tobias Diedrich <ranma@gmx.at>,
	Daniel McNeil <daniel@osdl.org>,
	Badari Pulavarty <pbadari@us.ibm.com>, Andrew Morton <akpm@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-aio@kvack.org" <linux-aio@kvack.org>,
	Suparna Bhattacharya <suparna@in.ibm.com>
References: <20040228024815.GA2835@melchior.yamamaya.is-a-geek.org> <200403020954.44886.pbadari@us.ibm.com> <1078450281.1773.4.camel@ibm-c.pdx.osdl.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1078450281.1773.4.camel@ibm-c.pdx.osdl.net>
User-Agent: Mutt/1.5.5.1+cvs20040105i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 738
Lines: 20

Daniel McNeil wrote:

> Here is the fix to this AIO oops.  An AIO O_DIRECT request was extending
> the file so it was done synchronously.  However, the request got an
> EFAULT and direct_io_worker() was calling aio_complete() on the iocb and
> returning the EFAULT.  When io_submit_one() got the EFAULT return,
> it assume it had to call aio_complete() since the i/o never got
> queued.

Thanks, this does indeed fix the oops for me.

-- 
Tobias						PGP: http://9ac7e0bc.2ya.com
Be vigilant!

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/